chore: use ubuntu to lint code style

Author: Bambooin

.github/workflows/commit-ci.yml

@@ -11,33 +11,15 @@ on:
 
 jobs:
   lint:
-    runs-on: windows-latest
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout last commit
         uses: actions/checkout@v4
-      - name: Install clang-format@18
-        shell: pwsh
+
+      - name: Install clang-format-18
         run: |
-          $version = ""
-          if (Get-Command "clang-format" -ErrorAction SilentlyContinue){
-            $version = clang-format --version
-            $pat = ".*\s+(\d+\.\d+\.\d+)"
-            if ($version -match $pat) {
-              $version = $matches[1]
-            }
-          }
-          if ($version -ne "") {
-            Write-Host "clang-format version：$version"
-            if ([version]$version -eq [version]"18.1.8") {
-              Write-Host "clang-format OK"
-            } else {
-              Write-Host "clang-format version does not meet"
-              choco install llvm --version=18.1.8 --force
-            }
-          } else {
-            Write-Host "clang-format not installed"
-            choco install llvm --version=18.1.8
-          }
+          ./action-install-clang-format.sh 18
+
       - name: Code style lint
         run: make clang-format-lint
 

Makefile

@@ -47,10 +47,10 @@ all: release
 
 clang-format-lint:
 	find ${RIME_SOURCE_PATH} \! -path 'plugins/*/*' -a \( -name '*.cc' -o -name '*.h' \) | \
-	xargs clang-format -Werror --dry-run || { echo Please lint your code by '"'"make clang-format-apply"'"'.; false; }
+	xargs clang-format --style=file:.clang-format -Werror --dry-run || { echo Please lint your code by '"'"make clang-format-apply"'"'.; false; }
 
 clang-format-apply:
-	find ${RIME_SOURCE_PATH} \! -path 'plugins/*/*' -a \( -name '*.cc' -o -name '*.h' \) | xargs clang-format --verbose -i
+	find ${RIME_SOURCE_PATH} \! -path 'plugins/*/*' -a \( -name '*.cc' -o -name '*.h' \) | xargs clang-format --style=file:.clang-format --verbose -i
 
 deps:
 	$(MAKE) -f deps.mk

action-install-clang-format.sh

@@ -0,0 +1,8 @@
+#!/bin/bash
+
+# https://apt.llvm.org/
+sudo apt install -y wget
+wget https://apt.llvm.org/llvm.sh
+chmod +x llvm.sh
+sudo ./llvm.sh $1
+sudo update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-$1 100

src/rime/dict/corrector.cc

@@ -207,9 +207,10 @@ Distance EditDistanceCorrector::RestrictedDistance(const std::string& s1,
   for (size_t i = 1; i <= len1; ++i) {
     auto min_d = threshold + 1;
     for (size_t j = 1; j <= len2; ++j) {
-      d[index(i, j)] = (std::min)(
-          {d[index(i - 1, j)] + 2, d[index(i, j - 1)] + 2,
-           d[index(i - 1, j - 1)] + SubstCost(s1[i - 1], s2[j - 1])});
+      d[index(i, j)] =
+          (std::min)({d[index(i - 1, j)] + 2, d[index(i, j - 1)] + 2,
+                      d[index(i - 1, j - 1)] +
+                          SubstCost(s1[i - 1], s2[j - 1])});
       if (i > 1 && j > 1 && s1[i - 2] == s2[j - 1] && s1[i - 1] == s2[j - 2]) {
         d[index(i, j)] = (std::min)(d[index(i, j)], d[index(i - 2, j - 2)] + 2);
       }