fix: Detect blocked request correctly

Kevin Twesten · Kevin Twesten · commit 401f90facec7 · 2021-04-22T09:11:54.000+02:00
diff --git a/baqend/_resultGeneration.ts b/baqend/_resultGeneration.ts
@@ -160,8 +160,7 @@ async function createRun(db: baqend, data: WptView | undefined, testId: string,
   run.bytes = data.bytesIn
   run.hits = new db.Hits(countHits(data.requests))
   run.contentSize = new db.ContentSize(countContentSize(data.requests))
-  // Document request can not be failed if this code is executed because of validity check
-  run.documentRequestFailed = false
+  run.documentRequestFailed = hasDocumentRequestFailed(data.requests)
   run.basePageCDN = data.base_page_cdn
   run.largestContentfulPaint = getLCPFromWebPagetest(data)
 
diff --git a/src/helper/resultHelper.js b/src/helper/resultHelper.js
@@ -75,6 +75,10 @@ export function resultIsValid(competitorResult, speedKitResult, mainMetric, seco
     return false
   }
 
+  if (competitorResult.firstView.documentRequestFailed || speedKitResult.firstView.documentRequestFailed) {
+    return false
+  }
+
   if ((speedKitResult.testInfo && speedKitResult.testInfo.isSpeedKitComparison) || isPlesk) {
     return true
   }

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,10 @@ export function resultIsValid(competitorResult, speedKitResult, mainMetric, seco`
`75`	`75`	`return false`
`76`	`76`	`}`
`77`	`77`
	`78`	`+ if (competitorResult.firstView.documentRequestFailed \|\| speedKitResult.firstView.documentRequestFailed) {`
	`79`	`+ return false`
	`80`	`+ }`
	`81`	`+`
`78`	`82`	`if ((speedKitResult.testInfo && speedKitResult.testInfo.isSpeedKitComparison) \|\| isPlesk) {`
`79`	`83`	`return true`
`80`	`84`	`}`