async-profiler#1174: code cleanup & fix failure on macos due to thread_name length

Author: Baraa-Hasheesh

src/vmEntry.cpp

@@ -109,7 +109,7 @@ static void* resolveMethodIdEnd() {
 // Work around for JDK-8308341, as JNI might return a none initialized VM so we check for the existence of certain VM threads 
 // "VM Thread" and "Service Thread" in this case are used as indication that the VM is in a good enough state to be used
 bool VM::checkJvmThreads() {
-    char thread_name[20];
+    char thread_name[30];
     int thread_name_offset = 0;
     bool vm_thread = false, service_thread = false;
 

test/one/profiler/test/Runner.java

@@ -91,7 +91,7 @@ private static Jvm detectJvm() {
         return Jvm.HOTSPOT;
     }
 
-    protected static int detectJvmVersion() {
+    private static int detectJvmVersion() {
         String prop = System.getProperty("java.vm.specification.version");
         if (prop.startsWith("1.")) {
             prop = prop.substring(2);

test/test/nonjava/non_java_app.cpp

@@ -121,7 +121,6 @@ void startJvm() {
     // Start JVM
     JavaVMInitArgs vm_args;
     JavaVMOption options[1];
-    int pid = getpid();
 
     options[0].optionString = const_cast<char*>("-Djava.class.path=build/test");
     //options[1].optionString = const_cast<char*>("-Xcheck:jni");