revision2

Author: Bascy6

app/src/main/java/hexlet/code/schemas/NumberSchema.java

@@ -14,13 +14,7 @@ public NumberSchema required() {
     }
 
     public NumberSchema positive() {
-        Predicate<Integer> positive = e -> {
-            if (e == 0) {
-                return false;
-            } else {
-                return e > 0;
-            }
-        };
+        Predicate<Integer> positive = e -> e > 0;
         addCheck(numberIsPositive, positive);
         return this;
     }

app/src/test/java/hexlet/code/NumberSchemaTest.java

@@ -28,6 +28,8 @@ public void testRange() {
         NumberSchema numberSchema = new NumberSchema().range(10, 20);
 
         assertTrue(numberSchema.isValid(15));
+        assertTrue(numberSchema.isValid(10));
+        assertTrue(numberSchema.isValid(20));
         assertFalse(numberSchema.isValid(5));
         assertFalse(numberSchema.isValid(25));
     }

app/src/test/java/hexlet/code/StringSchemaTest.java

@@ -12,7 +12,6 @@ public void testRequired() {
 
         assertTrue(stringSchema.isValid("test"));
         assertFalse(stringSchema.isValid(""));
-        assertFalse(stringSchema.isValid(null));
     }
 
     @Test
@@ -43,4 +42,13 @@ public void testCombination() {
         assertFalse(stringSchema.isValid("test"));
         assertFalse(stringSchema.isValid(null));
     }
+
+    @Test
+    public void testWithoutRequired() {
+        StringSchema stringSchema = new StringSchema();
+
+        assertTrue(stringSchema.isValid(null));
+        assertTrue(stringSchema.isValid(""));
+        assertTrue(stringSchema.isValid("test"));
+    }
 }