Skip to content

Commit 662fefe

Browse files
committed
gizmo changes
1 parent a54c721 commit 662fefe

10 files changed

Lines changed: 769 additions & 41 deletions

File tree

Basis/Packages/com.basis.camera/Runtime/BasisHandHeldCameraPanelProvider.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@ private void BuildViewfinderGridControls(RectTransform content)
981981
{
982982
_viewfinderGridToggle = PanelToggle.CreateNewEntry(content);
983983
_viewfinderGridToggle.Descriptor.SetTitle(BasisLocalization.Get("camera.grid"));
984-
_viewfinderGridToggle.Descriptor.SetDescription(BasisLocalization.Get("camera.grid.description"));
984+
_viewfinderGridToggle.Descriptor.SetTooltip(BasisLocalization.Get("camera.grid.description"));
985985
_viewfinderGridToggle.OnValueChanged = v =>
986986
{
987987
_activeCamera?.SetViewfinderGridEnabled(v);
@@ -1006,7 +1006,7 @@ private void BuildViewfinderGridControls(RectTransform content)
10061006
BasisLocalization.Get("camera.grid.opacity"),
10071007
BasisHandHeldCamera.MinGridOpacity * 100f, BasisHandHeldCamera.MaxGridOpacity * 100f,
10081008
false, 0, ValueDisplayMode.Percentage));
1009-
_viewfinderGridOpacitySlider.Descriptor.SetDescription(BasisLocalization.Get("camera.grid.opacity.description"));
1009+
_viewfinderGridOpacitySlider.Descriptor.SetTooltip(BasisLocalization.Get("camera.grid.opacity.description"));
10101010
_viewfinderGridOpacitySlider.OnValueChanged = v => _activeCamera?.SetViewfinderGridOpacity(v / 100f);
10111011
}
10121012

@@ -1125,7 +1125,7 @@ private void BuildAutoBrightnessControls(RectTransform content)
11251125
{
11261126
_autoBrightnessToggle = PanelToggle.CreateNewEntry(content);
11271127
_autoBrightnessToggle.Descriptor.SetTitle(BasisLocalization.Get("camera.autoBrightness"));
1128-
_autoBrightnessToggle.Descriptor.SetDescription(BasisLocalization.Get("camera.autoBrightness.description"));
1128+
_autoBrightnessToggle.Descriptor.SetTooltip(BasisLocalization.Get("camera.autoBrightness.description"));
11291129
_autoBrightnessToggle.OnValueChanged = v =>
11301130
{
11311131
_activeCamera?.SetAutoBrightnessEnabled(v);
@@ -1149,23 +1149,23 @@ private void BuildAutoBrightnessControls(RectTransform content)
11491149
BasisLocalization.Get("camera.autoBrightness.target"),
11501150
BasisHandHeldCamera.MinBrightnessTarget * 100f, BasisHandHeldCamera.MaxBrightnessTarget * 100f,
11511151
false, 0, ValueDisplayMode.Percentage));
1152-
_autoBrightnessTargetSlider.Descriptor.SetDescription(BasisLocalization.Get("camera.autoBrightness.target.description"));
1152+
_autoBrightnessTargetSlider.Descriptor.SetTooltip(BasisLocalization.Get("camera.autoBrightness.target.description"));
11531153
_autoBrightnessTargetSlider.OnValueChanged = v => _activeCamera?.SetAutoBrightnessTarget(v / 100f);
11541154

11551155
_autoBrightnessSpeedSlider = PanelSlider.CreateNew(content);
11561156
_autoBrightnessSpeedSlider.SetSliderSettings(PanelSlider.SliderSettings.Advanced(
11571157
BasisLocalization.Get("camera.autoBrightness.speed"),
11581158
BasisHandHeldCamera.MinBrightnessSpeed, BasisHandHeldCamera.MaxBrightnessSpeed,
11591159
false, 1, ValueDisplayMode.Raw));
1160-
_autoBrightnessSpeedSlider.Descriptor.SetDescription(BasisLocalization.Get("camera.autoBrightness.speed.description"));
1160+
_autoBrightnessSpeedSlider.Descriptor.SetTooltip(BasisLocalization.Get("camera.autoBrightness.speed.description"));
11611161
_autoBrightnessSpeedSlider.OnValueChanged = v => _activeCamera?.SetAutoBrightnessSpeed(v);
11621162

11631163
_autoBrightnessRangeSlider = PanelSlider.CreateNew(content);
11641164
_autoBrightnessRangeSlider.SetSliderSettings(PanelSlider.SliderSettings.Advanced(
11651165
BasisLocalization.Get("camera.autoBrightness.range"),
11661166
BasisHandHeldCamera.MinBrightnessRange, BasisHandHeldCamera.MaxBrightnessRange,
11671167
false, 1, ValueDisplayMode.Raw));
1168-
_autoBrightnessRangeSlider.Descriptor.SetDescription(BasisLocalization.Get("camera.autoBrightness.range.description"));
1168+
_autoBrightnessRangeSlider.Descriptor.SetTooltip(BasisLocalization.Get("camera.autoBrightness.range.description"));
11691169
_autoBrightnessRangeSlider.OnValueChanged = v => _activeCamera?.SetAutoBrightnessRange(v);
11701170
}
11711171

@@ -1201,7 +1201,7 @@ private void BuildColorGroup(RectTransform parent)
12011201

12021202
_captureTonemappingDropdown = PanelDropdown.CreateNewEntry(content);
12031203
_captureTonemappingDropdown.Descriptor.SetTitle(BasisLocalization.Get("camera.tonemapping"));
1204-
_captureTonemappingDropdown.Descriptor.SetDescription(BasisLocalization.Get("camera.tonemapping.description"));
1204+
_captureTonemappingDropdown.Descriptor.SetTooltip(BasisLocalization.Get("camera.tonemapping.description"));
12051205
_captureTonemappingDropdown.AssignLocalizedEntries(
12061206
new List<string>(TonemappingKeys), new List<string>(TonemappingKeys));
12071207
_captureTonemappingDropdown.OnValueChanged = _ =>

0 commit comments

Comments
 (0)