bug fix in accordance with the bgc simulations

With the cent_bgc on, it turned out some tracer number counters were not
appropriately calculated. This fixes the problem. The default tests
were not affected.

test:
  configure & build: pass, edison, intel compiler
  unit test: pass
  regression test: pass
  mtest: pas

Author: jinyuntang

src/betr/betr_core/BeTRTracerType.F90

@@ -123,7 +123,6 @@ subroutine Init(this)
     implicit none
     class(BeTRtracer_type), intent(inout) :: this
 
-    this%ntracers=this%ngwmobile_tracers+this%nsolid_passive_tracers
     this%ntracer_groups = this%nsolid_passive_tracer_groups + this%ngwmobile_tracer_groups
 
     call this%InitAllocate()

src/betr/betr_core/TracerStateType.F90

@@ -120,7 +120,6 @@ subroutine InitAllocate(this, bounds, lbj, ubj, betrtracer_vars)
     this%tracer_conc_atm_col      (:,:) = nan
     allocate(this%tracer_conc_mobile_col        (begc:endc, lbj:ubj, 1:ntracers))
     this%tracer_conc_mobile_col       (:,:,:) =  nan
-    print*,'equil_solid',nsolid_equil_tracers
     allocate(this%tracer_conc_solid_equil_col   (begc:endc, lbj:ubj, 1:nsolid_equil_tracers))
     this%tracer_conc_solid_equil_col  (:,:,:) = nan
 

src/betr/betr_main/TracerBalanceMod.F90

@@ -217,22 +217,18 @@ subroutine betr_tracer_mass_summary(bounds, col, lbj, ubj, numf, filter, betrtra
               tracer_molarmass_col(c,jj) = &
                  tracerstate_vars%int_mass_mobile_col(1,nlevtrc_soil,c,jj,dz(c,1:nlevtrc_soil),betr_status)
               if(betr_status%check_status())return
-              print*,'mass1',betrtracer_vars%tracernames(jj),tracer_molarmass_col(c,jj) 
-              if(trim(betrtracer_vars%tracernames(jj))=='P_SOL')print*,tracer_conc_mobile(c,:,jj)
               if(is_adsorb(jj))then
                  tracer_molarmass_col(c,jj) = tracer_molarmass_col(c,jj) + &
                       tracerstate_vars%int_mass_adsorb_col(1,nlevtrc_soil,c,adsorbid(jj),&
                       dz(c,1:nlevtrc_soil),betr_status)
                  if(betr_status%check_status())return
               endif
-              print*,'mass2',betrtracer_vars%tracernames(jj),tracer_molarmass_col(c,jj) 
               if(is_frozen(jj))then
                  tracer_molarmass_col(c,jj) = tracer_molarmass_col(c,jj) + &
                       tracerstate_vars%int_mass_frozen_col(1,nlevtrc_soil,c,&
                       frozenid(jj),dz(c,1:nlevtrc_soil),betr_status)
                  if(betr_status%check_status())return
               endif
-              print*,'mass3',betrtracer_vars%tracernames(jj),tracer_molarmass_col(c,jj) 
            enddo
         enddo
       end associate

src/driver/shared/BeTRType.F90

@@ -311,12 +311,18 @@ subroutine step_without_drainage(this, betr_time, bounds, col, pft, &
          this%tracerboundaryconds, this%tracerfluxes, this%bgc_reaction,             &
          Rfactor, this%advection_on, betr_status)
     if(betr_status%check_status())return
-
+!    print*,'bf hydro'
+!    do j = 1, this%tracers%ntracers
+!      print*,j,this%tracers%tracernames(j),this%tracerstates%tracer_conc_mobile_col(1,1,j)
+!    enddo
     call surface_tracer_hydropath_update(betr_time, bounds, col, &
        num_soilc, filter_soilc,  biophysforc, this%tracers, this%tracerstates,    &
        this%tracercoeffs,  this%tracerfluxes, betr_status)
     if(betr_status%check_status())return
-
+!    print*,'bf reaction'
+!    do j = 1, this%tracers%ntracers
+!      print*,j,this%tracers%tracernames(j),this%tracerstates%tracer_conc_mobile_col(1,1,j)
+!    enddo
     if(this%reaction_on)                                       &
     call this%bgc_reaction%calc_bgc_reaction(bounds, col, lbj, ubj, &
          num_soilc,                                            &
@@ -333,6 +339,11 @@ subroutine step_without_drainage(this, betr_time, bounds, col, pft, &
          this%tracerboundaryconds,                             &
          this%plant_soilbgc, biogeo_flux, betr_status)
     if(betr_status%check_status())return
+!    print*,'af reaction'
+!    do j = 1, this%tracers%ntracers
+!      print*,j,this%tracers%tracernames(j),this%tracerstates%tracer_conc_mobile_col(1,1,j)
+!    enddo
+
     call tracer_gws_transport(betr_time, bounds, col, pft, num_soilc, filter_soilc, &
       Rfactor, biophysforc, biogeo_flux, this%tracers, this%tracerboundaryconds  , &
       this%tracercoeffs,  this%tracerstates, this%tracerfluxes, this%bgc_reaction, &
@@ -355,7 +366,12 @@ subroutine step_without_drainage(this, betr_time, bounds, col, pft, &
          this%tracerfluxes%tracer_flx_ebu_col(bounds%begc:bounds%endc, 1:this%tracers%nvolatile_tracers), &
          this%ebullition_on, betr_status)
     if(betr_status%check_status())return
-
+!    do j = 1, this%tracers%ntracers
+!      if(this%tracers%is_adsorb(j) .or. trim(this%tracers%tracernames(j))=='P_SOL')then
+!       print*,this%tracers%tracernames(j)
+!       print*,this%tracerstates%tracer_conc_mobile_col(1,:,j)
+!      endif
+!    enddo
     !update nitrogen storage pool
     call this%plant_soilbgc%plant_soilbgc_summary(bounds, lbj, ubj, pft, &
           num_soilc, filter_soilc,  dtime                              , &