Skip to content

Commit 36fceca

Browse files
committed
fix FTBFS and CI
1 parent ea798c9 commit 36fceca

4 files changed

Lines changed: 22 additions & 25 deletions

File tree

.github/workflows/linux.yml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,21 @@ jobs:
99
runs-on: ubuntu-24.04
1010
steps:
1111
- name: Checkout
12-
uses: actions/checkout@v4
12+
uses: actions/checkout@v6
1313
with:
1414
submodules: recursive
15+
- name: Install Qt
16+
uses: jurplel/install-qt-action@v4
17+
with:
18+
version: '6.11.0'
19+
modules: 'qtmultimedia'
1520
- name: Install build dept.
1621
run: |
1722
sudo apt update
18-
sudo apt install cmake qt6-base-dev qt6-multimedia-dev
23+
sudo apt install cmake
1924
# for linuxdeploy: https://github.com/AppImage/AppImageKit/wiki/FUSE
20-
# linuxdeploy-plugin-qt still requires qmake currently: https://github.com/linuxdeploy/linuxdeploy-plugin-qt/issues/156
2125
sudo add-apt-repository universe
22-
sudo apt install libfuse2 qmake6
26+
sudo apt install libfuse2
2327
- name: Get linuxdeploy
2428
run: |
2529
wget https://github.com/linuxdeploy/linuxdeploy/releases/download/continuous/linuxdeploy-x86_64.AppImage
@@ -31,13 +35,11 @@ jobs:
3135
cmake -B build .
3236
cmake --build build -j
3337
- name: Package
34-
env:
35-
QMAKE: /usr/bin/qmake6
3638
run: |
3739
./linuxdeploy-x86_64.AppImage --appdir AppDir -e build/thplayer -d assets/thplayer.desktop -i assets/thplayer.svg --icon-filename thplayer -p qt -o appimage
3840
mv TouHou_Player*.AppImage thplayer-linux.AppImage
3941
- name: Upload
40-
uses: actions/upload-artifact@v4
42+
uses: actions/upload-artifact@v6
4143
with:
4244
name: Linux-Build
4345
path: thplayer-linux.AppImage

.github/workflows/macos.yml

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,19 @@ jobs:
99
runs-on: macos-latest
1010
steps:
1111
- name: Checkout
12-
uses: actions/checkout@v4
12+
uses: actions/checkout@v6
1313
with:
1414
submodules: recursive
1515
- name: Install Qt
1616
uses: jurplel/install-qt-action@v3
1717
with:
18-
version: '6.7.0'
18+
version: '6.11.0'
1919
modules: 'qtmultimedia'
20-
- name: Install Conan
21-
id: conan
22-
working-directory: ./
23-
shell: bash
24-
run: |
25-
pip3 install wheel setuptools
26-
pip3 install conan --upgrade
27-
conan --version
28-
conan profile detect
2920
- name: Build
3021
working-directory: ./
3122
run: |
32-
conan install --requires=icu/74.2 --generator CMakeDeps --generator CMakeToolchain --build=missing
33-
cmake . --preset conan-release
34-
cmake --build --preset conan-release
23+
cmake -Bbuild . -DCMAKE_BUILD_TYPE=Release
24+
cmake --build build --config Release
3525
- name: Package
3626
id: package
3727
working-directory: ./
@@ -41,7 +31,7 @@ jobs:
4131
zip -r9 --symlinks thplayer-macos.zip thplayer.app
4232
- name: Upload
4333
if: steps.package.conclusion == 'success'
44-
uses: actions/upload-artifact@v4
34+
uses: actions/upload-artifact@v6
4535
with:
4636
name: macOS-Build
4737
path: thplayer-macos.zip

.gitignore

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
11
# User Config
2-
*.pro.user
2+
*.user
33

44
# Autosave
55
*.autosave
66

77
# Build Dir
88
[Bb]uild/
9+
build-*/
10+
11+
# IDE and clangd Files
12+
.vscode/
13+
.cache/
914

1015
# Debian Build Helper
1116
debian/.debhelper/

loopedpcmstreamer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ void LoopedPCMStreamer::load()
6464
if (!maph)
6565
{
6666
unload();
67-
return false;
67+
return;
6868
}
6969

7070
SYSTEM_INFO snfo;
@@ -79,7 +79,7 @@ void LoopedPCMStreamer::load()
7979
if (!mapped)
8080
{
8181
unload();
82-
return false;
82+
return;
8383
}
8484
#endif
8585

0 commit comments

Comments
 (0)