As pointed out in PR #164 , the edit_mdp() function should use the MDP parser.
This would also reduce extremely cryptic errors such as gmx grompp: -include is not an option, which happens when a custom template MDP file is used with gromacs.setup.MD() but the template does not contain an include = ... line, which edit_mdp() tries to replace but fails. The failed replacement is then interpreted as a commandline option for gromacs.grompp. Although that's pretty hacky/crappy code logic in the
function, writing a better
edit_mdp() (which could, for instance, insert variables as opposed to a simple search and replace, or could check if they are legal variables) would help.
As pointed out in PR #164 , the
edit_mdp()function should use the MDP parser.This would also reduce extremely cryptic errors such as
gmx grompp: -include is not an option, which happens when a custom template MDP file is used withgromacs.setup.MD()but the template does not contain aninclude = ...line, whichedit_mdp()tries to replace but fails. The failed replacement is then interpreted as a commandline option forgromacs.grompp. Although that's pretty hacky/crappy code logic in theGromacsWrapper/gromacs/setup.py
Line 796 in cda0874
edit_mdp()(which could, for instance, insert variables as opposed to a simple search and replace, or could check if they are legal variables) would help.