Approval and publish cannot be done after updates.

[douglm]

Currently we have an approve or publish button which also allows for updates to be made at the same time. Due to the way indexing and some other functions work this is no longer reliably possible.

Update and indexing of the changes needs to be carried out before approval/publish. That last stage is essentially a move into another calendar.

I;m going to look at using the onChange event for the form to make the button disappear when a change is made. Approve and publish will only be allowed when there are no changes to the form.

[tiarastore]

Going forward. We will make any changes to event during a review, save those changes with one button (save/update)

Then, we would return to the form and (approve/publish)?

This is a little slower for approval. Most events we approve do not require editing, so it should work fine, in our case.

[douglm]

On 11/7/22 10:10, Kyle Cook wrote: Going forward. We will make any changes to event during a review, save those changes with one button (save/update) Then, we would return to the form and (approve/publish)? This is a little slower for approval. Most events we approve do not require editing, so it should work fine, in our case.

Yes - as above. i tried to consider ways i could do the move as part of the same request and all became very complex - especially if an error occurred.

…

— Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAW2MBWQ67QDEZUNXJCB6G3WHELUZANCNFSM6AAAAAARYPX45U>. You are receiving this because you were assigned.Message ID: ***@***.***>

[tiarastore]

Right - it is preferable to make these actions all discrete since there are so many combinations of calendars, users, and updates.

[douglm]

So I looked at the possibility of disabling/removing the "Approve Event" button if a change is made. In theory it can be done but it's not easy - if indeed it works.

Instead I propose changing the update form to be only that - it will be used to modify master or instances as now but without the approve option. Instead I'll add an approve button/link to the main approve tab list. This will take us to a page which simply displays the event and offers the option of approve/delete or cancel.

I think it's clearer and avoids all sorts of trickery