Feat/currently installed panel (#296)

* feat: currently-installed tab, upgrade-from-details, robust package upgrade logic

UI:
- Add "Installed" rail tab showing all installed packages (marketplace + custom)
- Add "Upgrade now" button in package details panel for upgradable packages
- Replace p-listbox in upgrades panel with native styled list matching design system
- Surface per-package git error messages in upgrade failure toasts

Backend:
- Add cwd= parameter to run_cmd() to avoid mutating process-wide working directory
- Replace git checkout -- . with git stash/pop to preserve local module changes
- Fix operator precedence bug causing InstallationHandler to never run post-pull
- Add git reset --hard ORIG_HEAD rollback when dependency install fails after pull
- Return tuple[bool, str] from package.upgrade() so error text reaches the API caller
- Remove dead os.chdir() from package.update() (preceded a GitPython call, had no effect)
- Update upgrade API endpoint to include per-package error details in failure list

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* refactor: promote MMPMEnv from instance to class-level attribute

MMPMEnv is a singleton; instantiating it per-instance in __init__ was
redundant. Moving it to a class-level attribute (`env: MMPMEnv = MMPMEnv()`)
removes boilerplate across 14 classes and makes the singleton relationship
explicit. Tests updated to use patch.object instead of instance assignment
(blocked by __slots__ on MagicMirrorPackage).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: sync Mirror Preview with config.js saves and warn on uninstalled modules

- Config Editor now emits a configJsSaved$ signal via SharedStoreService
  whenever config.js is successfully saved; Mirror Preview subscribes and
  calls resetLayout() so the visual grid always reflects the saved file
- Added configJsDirty flag on SharedStoreService so Mirror Preview picks
  up the signal even when it was off-screen (destroyed by @if) at save time
- Persistent warning banner added to both Config Editor and Mirror Preview
  listing any modules referenced in config.js that are not installed;
  banner clears automatically when packages are installed
- Mirror Preview also re-evaluates the banner on every packages subscription
  emission so it stays live without requiring a manual reset
- Replaced O(n²) category count loop in mmpm list --categories with a
  single Counter pass

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: add 4.6.0 changelog entry

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: update placement in changelog

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Bee-Mar

CHANGELOG.md

@@ -414,3 +414,31 @@
 - Added 167 new unit tests, raising coverage from 66% to 99%
 - Added `TestDetectDisplayServerScript` covering X11, Wayland (via `XDG_SESSION_TYPE` and `WAYLAND_DISPLAY`), Windows, and the fallback path
 
+## Version 4.6.0
+
+### UI
+
+- Added "Currently Installed" tab in the navigation rail showing all installed packages (marketplace and custom) with search, sort, card, and table views
+- Mirror Preview: Config Editor save now automatically triggers a layout reset so the visual grid always reflects the saved `config.js` without requiring a manual Reset click
+- Mirror Preview: persistent warning banner lists any modules referenced in `config.js` that are not installed; clears automatically when the missing packages are installed
+- Config Editor: persistent warning banner below the toolbar lists the same uninstalled modules while `config.js` is active; updates live when packages are installed or the file is saved
+- Upgrades panel: replaced `p-listbox` with native-styled list matching the design system
+- Package details panel: "Upgrade now" button appears for installed packages that have an available upgrade
+
+### Backend
+
+- `MagicMirrorPackage.upgrade()` rewritten: uses `git stash` / `git stash pop` to preserve local changes before pulling, surfaces error text from git through to the API response and UI toasts, rolls back via `git reset --hard ORIG_HEAD` if dependency installation fails after a successful pull
+- `run_cmd()` gained an optional `cwd` parameter; `upgrade()` passes it instead of using process-global `os.chdir()`
+- `MMPMEnv` promoted from a per-instance `__init__` assignment to a class-level attribute across all 14 consumer classes, making the singleton relationship explicit
+- `mmpm list --categories` package count replaced O(n²) double-scan with a single `Counter` pass
+
+### Bug Fixes
+
+- Mirror Preview warning banner now fires on every code path including the localStorage cache early-return, not only when `config.js` is fetched from the API
+- Mirror Preview correctly picks up a `config.js` save made while the panel was off-screen (`@if`-destroyed), via a `configJsDirty` flag checked on remount
+
+### Tests
+
+- Fixed test suite after `MMPMEnv` class-level attribute refactor: replaced instance-attribute assignment (blocked by `__slots__`) with `patch.object(MagicMirrorPackage, "env", ...)` + `addCleanup`
+- All 245 tests passing
+

mmpm/__version__.py

@@ -1,5 +1,5 @@
 major = 4
-minor = 5
+minor = 6
 patch = 0
 
 version = f"{major}.{minor}.{patch}"

mmpm/api/endpoints/ep_configs.py

@@ -17,11 +17,12 @@ class Configs(Endpoint):
     including retrieving and updating various configuration files.
     """
 
+    env: MMPMEnv = MMPMEnv()
+
     def __init__(self):
         self.name = "configs"
         self.blueprint = Blueprint(self.name, __name__, url_prefix=f"/api/{self.name}")
         self.handler = None
-        self.env = MMPMEnv()
         self.mm_configs = MagicMirrorConfigs()
 
         @self.blueprint.route("/retrieve/<filename>", methods=[http.GET])

mmpm/api/endpoints/ep_env.py

@@ -17,10 +17,11 @@ class Env(Endpoint):
     including retrieving the current environment, the default environment, and updating the environment settings.
     """
 
+    env: MMPMEnv = MMPMEnv()
+
     def __init__(self):
         self.name = "env"
         self.blueprint = Blueprint(self.name, __name__, url_prefix=f"/api/{self.name}")
-        self.env = MMPMEnv()
 
         @self.blueprint.route("/", methods=[http.GET])
         def retrieve() -> Response:

mmpm/api/endpoints/ep_mmpm.py

@@ -15,10 +15,11 @@ class Mmpm(Endpoint):
     A Flask endpoint class for interacting with the MMPM application in more 'meta' manner.
     """
 
+    env: MMPMEnv = MMPMEnv()
+
     def __init__(self):
         self.name = "mmpm"
         self.blueprint = Blueprint(self.name, __name__, url_prefix=f"/api/{self.name}")
-        self.env = MMPMEnv()
 
         @self.blueprint.route("/version", methods=[http.GET])
         def version() -> Response:

mmpm/api/endpoints/ep_packages.py

@@ -130,13 +130,14 @@ def upgrade() -> Response:
 
             for package in packages:
                 pkg = MagicMirrorPackage(**package)
+                ok, error = pkg.upgrade()
 
-                if pkg.upgrade():
+                if ok:
                     logger.debug(f"Upgraded {pkg.title}")
                     success.append(package)
                 else:
-                    logger.debug(f"Failed to upgrade {pkg.title}")
-                    failure.append(package)
+                    logger.debug(f"Failed to upgrade {pkg.title}: {error}")
+                    failure.append({"title": pkg.title, "error": error})
 
             return self.success({"success": success, "failure": failure})
 

mmpm/magicmirror/controller.py

@@ -95,8 +95,9 @@ class MagicMirrorController(Singleton):
     or hide specific modules.
     """
 
+    env: MMPMEnv = MMPMEnv()
+
     def __init__(self):
-        self.env = MMPMEnv()
         self.factory = MagicMirrorClientFactory()
 
     def status(self):

mmpm/magicmirror/database.py

@@ -22,8 +22,9 @@ class MagicMirrorDatabase(Singleton):
     and managing the list of available MagicMirror modules and custom packages.
     """
 
+    env: MMPMEnv = MMPMEnv()
+
     def __init__(self):
-        self.env = MMPMEnv()
         self.packages: List[MagicMirrorPackage] = None
         self.last_update: datetime.datetime = None
         self.expiration_date: datetime.datetime = None

mmpm/magicmirror/magicmirror.py

@@ -16,8 +16,7 @@
 
 
 class MagicMirrorConfigs(Singleton):
-    def __init__(self) -> None:
-        self.env = MMPMEnv()
+    env: MMPMEnv = MMPMEnv()
 
     def get(self, name: str) -> Optional[Path]:
         match name:
@@ -68,8 +67,7 @@ class MagicMirror(Singleton):
     and removal functionalities.
     """
 
-    def __init__(self):
-        self.env = MMPMEnv()
+    env: MMPMEnv = MMPMEnv()
 
     def update(self):
         """

mmpm/magicmirror/package.py

@@ -35,6 +35,8 @@ class MagicMirrorPackage:
     MagicMirror package's metadata
     """
 
+    env: MMPMEnv = MMPMEnv()
+
     __slots__ = (
         "title",
         "author",
@@ -43,7 +45,6 @@ class MagicMirrorPackage:
         "category",
         "directory",
         "is_installed",
-        "env",
         "is_upgradable",
         "stars",
         "last_updated",
@@ -80,7 +81,6 @@ def __init__(
         Additional keyword arguments are ignored, but intentionally provided as a means to simplify API interaction.
         """
 
-        self.env = MMPMEnv()
         self.title = __sanitize__(title).strip()
         self.author = __sanitize__(author).strip()
         self.repository = repository.strip()
@@ -258,39 +258,76 @@ def update(self) -> None:
             self.is_upgradable = False
             return
 
-        os.chdir(modules_dir / self.directory)
-
         try:
             self.is_upgradable = repo_up_to_date(modules_dir / self.directory)
         except KeyboardInterrupt:
             logger.info("User killed process with CTRL-C")
             sys.exit(127)
 
-    def upgrade(self, force: bool = False) -> bool:
+    def upgrade(self, force: bool = False) -> tuple[bool, str]:
         """
         Upgrades the package by pulling the latest changes from the remote repository.
 
+        Local modifications are stashed before the pull and restored afterwards so
+        that a dirty working tree does not block the merge and user changes are not
+        silently discarded. If dependency installation fails after a successful pull
+        the commit is rolled back via ORIG_HEAD so the package is left in its last
+        known-good state.
+
         Parameters:
-            force (bool): If True, forces the upgrade even if the repository is up to date.
+            force (bool): If True, forces dependency reinstall even when already up to date.
 
         Returns:
-            bool: True if the upgrade is successful, False otherwise.
+            tuple[bool, str]: (True, "") on success; (False, error_message) on failure.
         """
-        modules_dir: PosixPath = self.env.MMPM_MAGICMIRROR_ROOT.get() / "modules"
+        pkg_dir: PosixPath = self.env.MMPM_MAGICMIRROR_ROOT.get() / "modules" / self.directory
 
-        os.chdir(modules_dir / self.directory)
+        # Stash any local modifications so git pull cannot be blocked by dirty-tree
+        # conflicts while still preserving the user's changes.
+        _, status_out, _ = run_cmd(["git", "status", "--porcelain"], progress=False, cwd=pkg_dir)
+        stashed = False
 
-        error_code, stdout, stderr = run_cmd(["git", "pull"], message="Retrieving changes")
+        if status_out.strip():
+            logger.debug(f"Stashing local changes in {self.directory} before upgrade")
+            stash_code, _, stash_err = run_cmd(["git", "stash"], message="Stashing local changes", cwd=pkg_dir)
 
-        if error_code or stderr:
-            logger.error(f"Failed to upgrade {self.title}: {stderr}")
-            return False
+            if stash_code:
+                return False, f"Failed to stash local changes: {stash_err.strip()}"
+
+            stashed = True
+
+        error_code, stdout, stderr = run_cmd(["git", "pull"], message="Retrieving changes", cwd=pkg_dir)
+
+        # Restore stashed changes regardless of pull outcome.
+        if stashed:
+            pop_code, _, pop_err = run_cmd(["git", "stash", "pop"], message="Restoring local changes", cwd=pkg_dir)
+
+            if pop_code:
+                # Conflicts between the stash and the pulled changes need manual resolution.
+                logger.warning(
+                    f"git stash pop had conflicts in {self.directory}. Run 'git stash pop' in the module directory to resolve them manually."
+                )
+
+        # Only a non-zero exit code signals failure — git writes fetch progress to
+        # stderr even on a successful pull, so checking stderr alone gives false negatives.
+        if error_code:
+            error_msg = (stderr or stdout).strip()
+            logger.error(f"Failed to upgrade {self.title}: {error_msg}")
+            return False, error_msg
+
+        pulled_changes = "Already up to date." not in stdout
+
+        if pulled_changes or force:
+            if not InstallationHandler(self).install():
+                # Roll back the pull so the package is not left with a broken dependency state.
+                logger.error(f"Dependency install failed after upgrading {self.title}; rolling back to previous commit")
+                run_cmd(["git", "reset", "--hard", "ORIG_HEAD"], progress=False, cwd=pkg_dir)
+                return False, "Upgrade pulled successfully but dependency installation failed; changes have been rolled back"
 
-        elif "up to date" not in stdout or force and InstallationHandler(self).install():
             print(f"Upgraded {color.n_green(self.title)}")
-            logger.debug(f"Upgraded {color.n_green(self.title)}")
+            logger.debug(f"Upgraded {self.title}")
 
-        return True
+        return True, ""
 
     @classmethod
     def from_json(cls, data: Dict[str, Any]):