Skip to content

Commit fdeb0f9

Browse files
committed
bug fix for git commands placing stdout in stderr position
1 parent d0f7338 commit fdeb0f9

3 files changed

Lines changed: 8 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,3 +198,8 @@
198198

199199
- Bug fix (#29). Corrected `log.info` to `log.logger.info` in utils.py within the
200200
`kill_magicmirror_processes` function
201+
202+
# Version 1.14
203+
204+
- Bug fix (#no number). Fixed issue with update command, where git commands place stdout in stderr
205+
position

mmpm/core.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def enhance_modules(modules: dict, update: bool = False, upgrade: bool = False,
183183

184184
if update:
185185
utils.plain_print(f"Checking {title} for updates")
186-
error_code, stdout, stderr = utils.run_cmd(["git", "fetch", "--dry-run"])
186+
error_code, _, stdout = utils.run_cmd(["git", "fetch", "--dry-run"])
187187

188188
if error_code:
189189
utils.error_msg(stderr)
@@ -405,7 +405,7 @@ def install_magicmirror(gui=False) -> bool:
405405
os.chdir(utils.MAGICMIRROR_ROOT)
406406

407407
print(colors.B_CYAN + "Checking for updates..." + colors.RESET)
408-
return_code, stdout, stderr = utils.run_cmd(['git', 'fetch', '--dry-run'])
408+
return_code, _, stdout = utils.run_cmd(['git', 'fetch', '--dry-run'])
409409

410410
if return_code:
411411
utils.error_msg(stderr)

mmpm/mmpm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import sys
44
from mmpm import utils, colors, core, opts
55

6-
__version__ = 1.13
6+
__version__ = 1.14
77

88

99
def main(argv):

0 commit comments

Comments
 (0)