Skip to content

Commit 7eaf0ec

Browse files
authored
Merge pull request #314 from acoulton/maint-cucumber-ci-scripts
ci: Add conventional title to gherkin update, error on missing asserts
2 parents b6557b0 + 80abbcc commit 7eaf0ec

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/update.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,4 @@ jobs:
9898
BRANCH_NAME: ${{ steps.check-existing-pr.outputs.commit_branch }}
9999
COMMIT_MSG: ${{ steps.cucumber.outputs.commit_msg }}
100100
PR_EXISTS: ${{ steps.check-existing-pr.outputs.exists }}
101-
PR_TITLE: Update to cucumber/gherkin ${{ steps.cucumber.outputs.cucumber_version }}
101+
PR_TITLE: "chore: Update to cucumber/gherkin ${{ steps.cucumber.outputs.cucumber_version }}"

bin/update_cucumber

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ set_error_handler(static fn ($code, $msg, $file, $line) => throw new ErrorExcept
1515
if (ini_get('zend.assertions') !== '1') {
1616
// Ensure our assertions are actually processed. Otherwise any code inside the assert() call is compiled out
1717
echo "This script must be run with zend.assertions set to 1\n";
18-
exit;
18+
exit(1);
1919
}
2020

2121
$updater = new

0 commit comments

Comments
 (0)