Prohibit square-bracket and key-less array; use list instead

Author: uuf6429

.php-cs-fixer.dist.php

@@ -22,5 +22,7 @@
         'yoda_style' => false,
         'concat_space' => ['spacing' => 'one'],
         'phpdoc_types_order' => ['null_adjustment' => 'always_first'],
+        'phpdoc_array_type' => true,
+        'phpdoc_list_type' => true,
     ])
     ->setFinder($finder);

src/Behat/Gherkin/Cache/MemoryCache.php

@@ -20,8 +20,14 @@
  */
 class MemoryCache implements CacheInterface
 {
-    private $features = [];
-    private $timestamps = [];
+    /**
+     * @var array<string, FeatureNode>
+     */
+    private array $features = [];
+    /**
+     * @var array<string, int>
+     */
+    private array $timestamps = [];
 
     /**
      * Checks that cache for feature exists and is fresh.

src/Behat/Gherkin/Filter/PathsFilter.php

@@ -25,7 +25,7 @@ class PathsFilter extends SimpleFilter
     /**
      * Initializes filter.
      *
-     * @param string[] $paths List of approved paths
+     * @param list<string> $paths List of approved paths
      */
     public function __construct(array $paths)
     {

src/Behat/Gherkin/Filter/TagFilter.php

@@ -126,7 +126,7 @@ public function isScenarioMatch(FeatureNode $feature, ScenarioInterface $scenari
     /**
      * Checks that node matches condition.
      *
-     * @param string[] $tags
+     * @param list<string> $tags
      *
      * @return bool
      */

src/Behat/Gherkin/Gherkin.php

@@ -26,11 +26,11 @@ class Gherkin
     public const VERSION = '4.8.0';
 
     /**
-     * @var LoaderInterface[]
+     * @var list<LoaderInterface>
      */
     protected $loaders = [];
     /**
-     * @var FeatureFilterInterface[]
+     * @var list<FeatureFilterInterface>
      */
     protected $filters = [];
 
@@ -57,7 +57,7 @@ public function addFilter(FeatureFilterInterface $filter)
     /**
      * Sets filters to the parser.
      *
-     * @param FeatureFilterInterface[] $filters
+     * @param list<FeatureFilterInterface> $filters
      */
     public function setFilters(array $filters)
     {
@@ -82,8 +82,8 @@ public function setBasePath($path)
     /**
      * Loads & filters resource with added loaders.
      *
-     * @param mixed                    $resource Resource to load
-     * @param FeatureFilterInterface[] $filters  Additional filters
+     * @param mixed                        $resource Resource to load
+     * @param list<FeatureFilterInterface> $filters  Additional filters
      *
      * @return array
      */

src/Behat/Gherkin/Loader/ArrayLoader.php

@@ -43,7 +43,7 @@ public function supports($resource)
      *
      * @param mixed $resource Resource to load
      *
-     * @return FeatureNode[]
+     * @return list<FeatureNode>
      */
     public function load($resource)
     {
@@ -195,7 +195,7 @@ protected function loadOutlineHash(array $hash, $line = 0)
     /**
      * Loads steps from provided hash.
      *
-     * @return StepNode[]
+     * @return list<StepNode>
      */
     private function loadStepsHash(array $hash)
     {

src/Behat/Gherkin/Loader/CucumberNDJsonAstLoader.php

@@ -65,7 +65,7 @@ private static function getFeature(array $json, $filePath)
     }
 
     /**
-     * @return string[]
+     * @return list<string>
      */
     private static function getTags(array $json)
     {
@@ -76,7 +76,7 @@ static function (array $tag) { return preg_replace('/^@/', '', $tag['name']); },
     }
 
     /**
-     * @return ScenarioInterface[]
+     * @return list<ScenarioInterface>
      */
     private static function getScenarios(array $json)
     {
@@ -140,7 +140,7 @@ static function ($child) {
     }
 
     /**
-     * @return StepNode[]
+     * @return list<StepNode>
      */
     private static function getSteps(array $json)
     {
@@ -159,7 +159,7 @@ static function (array $json) {
     }
 
     /**
-     * @return ExampleTableNode[]
+     * @return list<ExampleTableNode>
      */
     private static function getTables(array $json)
     {

src/Behat/Gherkin/Loader/DirectoryLoader.php

@@ -50,7 +50,7 @@ public function supports($path)
      *
      * @param string $path Resource to load
      *
-     * @return FeatureNode[]
+     * @return list<FeatureNode>
      */
     public function load($path)
     {

src/Behat/Gherkin/Loader/GherkinFileLoader.php

@@ -65,7 +65,7 @@ public function supports($path)
      *
      * @param string $path Resource to load
      *
-     * @return FeatureNode[]
+     * @return list<FeatureNode>
      */
     public function load($path)
     {

src/Behat/Gherkin/Loader/LoaderInterface.php

@@ -33,7 +33,7 @@ public function supports($resource);
      *
      * @param mixed $resource Resource to load
      *
-     * @return FeatureNode[]
+     * @return list<FeatureNode>
      */
     public function load($resource);
 }