Fix the implementation of the default dialect for the keywords provider#404
Merged
acoulton merged 1 commit intoBehat:masterfrom Dec 5, 2025
Merged
Fix the implementation of the default dialect for the keywords provider#404acoulton merged 1 commit intoBehat:masterfrom
acoulton merged 1 commit intoBehat:masterfrom
Conversation
The legacy KeywordsInterface was stateful, so we cannot assume that the _current_ language is the default one. We need to read the _initial_ language instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
=========================================
Coverage 95.66% 95.67%
Complexity 682 682
=========================================
Files 45 45
Lines 2009 2010 +1
=========================================
+ Hits 1922 1923 +1
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
acoulton
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy KeywordsInterface was stateful, so we cannot assume that the current language is the default one. We need to read the initial language instead.
Closes #403