Skip to content

Commit 259f757

Browse files
committed
Merge pull request godotengine#120443 from blueskythlikesclouds/input-attachment-regression
Fix input attachments triggering the texture type validation.
2 parents ceba8dd + f27af7a commit 259f757

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

servers/rendering/rendering_shader_container.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,9 @@ Error RenderingShaderContainer::reflect_spirv(const String &p_shader_name, Span<
453453
uniform.writable = false;
454454
}
455455

456-
if (is_image) {
456+
// Gather the texture type and format for runtime validation when creating uniform sets.
457+
// We cannot enforce the type for input attachments since they do not indicate whether the texture is 2D or 2D array for multiview.
458+
if (is_image && binding.descriptor_type != SPV_REFLECT_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) {
457459
uniform.texture_type = _spv_image_dim_to_texture_type(binding.image.dim, binding.image.arrayed);
458460
uniform.texture_format = _spv_image_format_to_data_format(binding.image.image_format);
459461

0 commit comments

Comments
 (0)