Skip to content

Commit cb59f42

Browse files
committed
Merge pull request godotengine#97588 from TML233/generated-raise-signal
[C#] Change generated On{SignalName} to EmitSignal{SignalName}
2 parents 66e6ee1 + f2d7efa commit cb59f42

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators.Tests/TestData/GeneratedSources/EventSignals_ScriptSignals.generated.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ partial class EventSignals
3232
add => backing_MySignal += value;
3333
remove => backing_MySignal -= value;
3434
}
35-
protected void OnMySignal(string str, int num)
35+
protected void EmitSignalMySignal(string str, int num)
3636
{
3737
EmitSignal(SignalName.MySignal, str, num);
3838
}

modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/ScriptSignalsGenerator.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ void AppendPartialContainingTypeDeclarations(INamedTypeSymbol? containingType)
282282
.Append(" -= value;\n")
283283
.Append("}\n");
284284

285-
// Generate On{EventName} method to raise the event
285+
// Generate EmitSignal{EventName} method to raise the event
286286

287287
var invokeMethodSymbol = signalDelegate.InvokeMethodData.Method;
288288
int paramCount = invokeMethodSymbol.Parameters.Length;
@@ -291,7 +291,7 @@ void AppendPartialContainingTypeDeclarations(INamedTypeSymbol? containingType)
291291
"private" :
292292
"protected";
293293

294-
source.Append($" {raiseMethodModifiers} void On{signalName}(");
294+
source.Append($" {raiseMethodModifiers} void EmitSignal{signalName}(");
295295
for (int i = 0; i < paramCount; i++)
296296
{
297297
var paramSymbol = invokeMethodSymbol.Parameters[i];

modules/mono/editor/bindings_generator.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3275,10 +3275,10 @@ Error BindingsGenerator::_generate_cs_signal(const BindingsGenerator::TypeInterf
32753275

32763276
p_output.append(CLOSE_BLOCK_L1);
32773277

3278-
// Generate On{EventName} method to raise the event.
3278+
// Generate EmitSignal{EventName} method to raise the event.
32793279
if (!p_itype.is_singleton) {
32803280
p_output.append(MEMBER_BEGIN "protected void ");
3281-
p_output << "On" << p_isignal.proxy_name;
3281+
p_output << "EmitSignal" << p_isignal.proxy_name;
32823282
if (is_parameterless) {
32833283
p_output.append("()\n" OPEN_BLOCK_L1 INDENT2);
32843284
p_output << "EmitSignal(SignalName." << p_isignal.proxy_name << ");\n";

0 commit comments

Comments
 (0)