Skip to content

Commit c0c9163

Browse files
bs2609bs2609
committed
Add some more missing cullfaces
1 parent 64fa2d3 commit c0c9163

File tree

7 files changed

+119
-115
lines changed

7 files changed

+119
-115
lines changed

‎src/main/java/twilightforest/block/BlockTFSpiralBrick.java‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,7 @@ public EnumFacing[] getValidRotations(World world, BlockPos pos) {
178178
}
179179

180180
@Override
181-
public boolean isFullCube(IBlockState state)
182-
{
181+
public boolean isFullCube(IBlockState state) {
183182
return false;
184183
}
185184

@@ -207,6 +206,11 @@ public BlockFaceShape getBlockFaceShape(IBlockAccess worldIn, IBlockState state,
207206
}
208207
}
209208

209+
@Override
210+
public boolean doesSideBlockRendering(IBlockState state, IBlockAccess world, BlockPos pos, EnumFacing face) {
211+
return getBlockFaceShape(world, state, pos, face) == BlockFaceShape.SOLID;
212+
}
213+
210214
@Override
211215
protected ItemStack getSilkTouchDrop(IBlockState state) {
212216
return new ItemStack(Item.getItemFromBlock(this));

‎src/main/resources/assets/twilightforest/models/block/jar.json‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,27 @@
88
},
99
"elements": [
1010
{
11-
"from": [ 3, 0, 3 ],
12-
"to": [ 13, 14, 13 ],
11+
"from": [ 3, 0, 3 ],
12+
"to": [ 13, 14, 13 ],
1313
"faces": {
1414
"down": { "uv": [ 3, 3, 13, 13 ], "texture": "#end", "cullface": "down" },
15-
"up": { "uv": [ 3, 3, 13, 13 ], "texture": "#end"},
16-
"north": { "uv": [ 3, 2, 13, 16 ], "texture": "#side"},
17-
"south": { "uv": [ 3, 2, 13, 16 ], "texture": "#side"},
18-
"west": { "uv": [ 3, 2, 13, 16 ], "texture": "#side"},
19-
"east": { "uv": [ 3, 2, 13, 16 ], "texture": "#side"}
15+
"up": { "uv": [ 3, 3, 13, 13 ], "texture": "#end" },
16+
"north": { "uv": [ 3, 2, 13, 16 ], "texture": "#side" },
17+
"south": { "uv": [ 3, 2, 13, 16 ], "texture": "#side" },
18+
"west": { "uv": [ 3, 2, 13, 16 ], "texture": "#side" },
19+
"east": { "uv": [ 3, 2, 13, 16 ], "texture": "#side" }
2020
}
2121
},
2222
{
23-
"from": [ 4, 12, 4 ],
24-
"to": [ 12, 16, 12 ],
23+
"from": [ 4, 12, 4 ],
24+
"to": [ 12, 16, 12 ],
2525
"faces": {
26-
"down": { "uv": [ 4, 4, 12, 12 ], "texture": "#cork"},
27-
"up": { "uv": [ 4, 4, 12, 12 ], "texture": "#cork"},
28-
"north": { "uv": [ 4, 0, 12, 4 ], "texture": "#cork"},
29-
"south": { "uv": [ 4, 0, 12, 4 ], "texture": "#cork"},
30-
"west": { "uv": [ 4, 0, 12, 4 ], "texture": "#cork"},
31-
"east": { "uv": [ 4, 0, 12, 4 ], "texture": "#cork"}
26+
"down": { "uv": [ 4, 4, 12, 12 ], "texture": "#cork" },
27+
"up": { "uv": [ 4, 4, 12, 12 ], "texture": "#cork", "cullface": "up" },
28+
"north": { "uv": [ 4, 0, 12, 4 ], "texture": "#cork" },
29+
"south": { "uv": [ 4, 0, 12, 4 ], "texture": "#cork" },
30+
"west": { "uv": [ 4, 0, 12, 4 ], "texture": "#cork" },
31+
"east": { "uv": [ 4, 0, 12, 4 ], "texture": "#cork" }
3232
}
3333
}
3434
]

‎src/main/resources/assets/twilightforest/models/block/spiral_bottom_left.json‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,100 +1,100 @@
11
{
22
"parent": "block/block",
33
"textures": {
4-
"pattern": "twilightforest:blocks/stone_spiral_large",
5-
"border": "blocks/stonebrick_carved",
4+
"pattern": "twilightforest:blocks/stone_spiral_large",
5+
"border": "blocks/stonebrick_carved",
66
"particle": "blocks/stonebrick_carved"
77
},
88
"elements": [
99
{
1010
"from": [ 0, 13, 0 ],
1111
"to": [ 8, 16, 16 ],
1212
"faces": {
13-
"up": { "texture": "#border" },
14-
"north": { "texture": "#inner_b" },
15-
"south": { "texture": "#border" },
16-
"west": { "uv": [ 8, 0, 16, 1.5 ], "texture": "#pattern" }
13+
"up": { "texture": "#border", "cullface": "up" },
14+
"north": { "texture": "#inner_b", "cullface": "north" },
15+
"south": { "texture": "#border", "cullface": "south" },
16+
"west": { "uv": [ 8, 0, 16, 1.5 ], "texture": "#pattern", "cullface": "west" }
1717
}
1818
},
1919
{
20-
"from": [ 0, 0, 13 ],
20+
"from": [ 0, 0, 13 ],
2121
"to": [ 8, 13, 16 ],
2222
"faces": {
23-
"down": { "texture": "#inner_a" },
24-
"south": { "texture": "#border" },
25-
"west": { "uv": [ 14.5, 1.5, 16, 8 ], "texture": "#pattern" }
23+
"down": { "texture": "#inner_a", "cullface": "down" },
24+
"south": { "texture": "#border", "cullface": "south" },
25+
"west": { "uv": [ 14.5, 1.5, 16, 8 ], "texture": "#pattern", "cullface": "west" }
2626
}
2727
},
2828
{
2929
"from": [ 0.5, 10, 0 ],
3030
"to": [ 8 , 13, 13 ],
3131
"faces": {
32-
"north": { "texture": "#inner_b" },
32+
"north": { "texture": "#inner_b", "cullface": "north" },
3333
"west": { "uv": [ 8, 1.5, 14.5, 3 ], "texture": "#pattern" }
3434
}
3535
},
3636
{
3737
"from": [ 1.5, 7, 0 ],
3838
"to": [ 8 , 10, 10 ],
3939
"faces": {
40-
"north": { "texture": "#inner_b" },
40+
"north": { "texture": "#inner_b", "cullface": "north" },
4141
"west": { "uv": [ 8, 3, 13, 4.5 ], "texture": "#pattern" }
4242
}
4343
},
4444
{
4545
"from": [ 2.5, 4, 0 ],
4646
"to": [ 8 , 7, 7 ],
4747
"faces": {
48-
"north": { "texture": "#inner_b" },
48+
"north": { "texture": "#inner_b", "cullface": "north" },
4949
"west": { "uv": [ 8, 4.5, 11.5, 6 ], "texture": "#pattern" }
5050
}
5151
},
5252
{
5353
"from": [ 3.5, 1, 0 ],
5454
"to": [ 8 , 4, 4 ],
5555
"faces": {
56-
"north": { "texture": "#inner_b" },
56+
"north": { "texture": "#inner_b", "cullface": "north" },
5757
"west": { "uv": [ 8, 6, 10, 7.5 ], "texture": "#pattern" }
5858
}
5959
},
6060
{
6161
"from": [ 0.25, 0, 10 ],
6262
"to": [ 8 , 10, 13 ],
6363
"faces": {
64-
"down": { "texture": "#inner_a" },
64+
"down": { "texture": "#inner_a", "cullface": "down" },
6565
"west": { "uv": [ 13, 3, 14.5, 8 ], "texture": "#pattern" }
6666
}
6767
},
6868
{
6969
"from": [ 1.25, 0, 7 ],
7070
"to": [ 8 , 7, 10 ],
7171
"faces": {
72-
"down": { "texture": "#inner_a" },
72+
"down": { "texture": "#inner_a", "cullface": "down" },
7373
"west": { "uv": [ 11.5, 4.5, 13, 8 ], "texture": "#pattern" }
7474
}
7575
},
7676
{
7777
"from": [ 2.25, 0, 4 ],
7878
"to": [ 8 , 4, 7 ],
7979
"faces": {
80-
"down": { "texture": "#inner_a" },
80+
"down": { "texture": "#inner_a", "cullface": "down" },
8181
"west": { "uv": [ 10, 6, 11.5, 8 ], "texture": "#pattern" }
8282
}
8383
},
8484
{
8585
"from": [ 3.25, 0, 1 ],
8686
"to": [ 8 , 1, 4 ],
8787
"faces": {
88-
"down": { "texture": "#inner_a" },
88+
"down": { "texture": "#inner_a", "cullface": "down" },
8989
"west": { "uv": [ 8.5, 7.5, 10, 8 ], "texture": "#pattern" }
9090
}
9191
},
9292
{
9393
"from": [ 4.25, 0, 0 ],
9494
"to": [ 8 , 1, 1 ],
9595
"faces": {
96-
"down": { "texture": "#inner_a" },
97-
"north": { "texture": "#inner_b" },
96+
"down": { "texture": "#inner_a", "cullface": "down" },
97+
"north": { "texture": "#inner_b", "cullface": "north" },
9898
"west": { "uv": [ 8, 7.5, 8.5, 8 ], "texture": "#pattern" }
9999
}
100100
},

‎src/main/resources/assets/twilightforest/models/block/spiral_bottom_right.json‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,100 +1,100 @@
11
{
22
"parent": "block/block",
33
"textures": {
4-
"pattern": "twilightforest:blocks/stone_spiral_large",
5-
"border": "blocks/stonebrick_carved",
4+
"pattern": "twilightforest:blocks/stone_spiral_large",
5+
"border": "blocks/stonebrick_carved",
66
"particle": "blocks/stonebrick_carved"
77
},
88
"elements": [
99
{
1010
"from": [ 0, 13, 0 ],
1111
"to": [ 8, 16, 16 ],
1212
"faces": {
13-
"up": { "texture": "#border" },
14-
"north": { "texture": "#inner_a" },
15-
"south": { "texture": "#border" },
16-
"west": { "uv": [ 8, 0, 16, 1.5 ], "texture": "#pattern" }
13+
"up": { "texture": "#border", "cullface": "up" },
14+
"north": { "texture": "#inner_a", "cullface": "north" },
15+
"south": { "texture": "#border", "cullface": "south" },
16+
"west": { "uv": [ 8, 0, 16, 1.5 ], "texture": "#pattern", "cullface": "west" }
1717
}
1818
},
1919
{
2020
"from": [ 0, 0, 13 ],
2121
"to": [ 8, 13, 16 ],
2222
"faces": {
23-
"down": { "texture": "#inner_b" },
24-
"south": { "texture": "#border" },
25-
"west": { "uv": [ 14.5, 1.5, 16, 8 ], "texture": "#pattern" }
23+
"down": { "texture": "#inner_b", "cullface": "down" },
24+
"south": { "texture": "#border", "cullface": "south" },
25+
"west": { "uv": [ 14.5, 1.5, 16, 8 ], "texture": "#pattern", "cullface": "west" }
2626
}
2727
},
2828
{
2929
"from": [ 0.75, 10, 0 ],
3030
"to": [ 8 , 13, 13 ],
3131
"faces": {
32-
"north": { "texture": "#inner_a" },
32+
"north": { "texture": "#inner_a", "cullface": "north" },
3333
"west": { "uv": [ 8, 1.5, 14.5, 3 ], "texture": "#pattern" }
3434
}
3535
},
3636
{
3737
"from": [ 1.75, 7, 0 ],
3838
"to": [ 8 , 10, 10 ],
3939
"faces": {
40-
"north": { "texture": "#inner_a" },
40+
"north": { "texture": "#inner_a", "cullface": "north" },
4141
"west": { "uv": [ 8, 3, 13, 4.5 ], "texture": "#pattern" }
4242
}
4343
},
4444
{
4545
"from": [ 2.75, 4, 0 ],
4646
"to": [ 8 , 7, 7 ],
4747
"faces": {
48-
"north": { "texture": "#inner_a" },
48+
"north": { "texture": "#inner_a", "cullface": "north" },
4949
"west": { "uv": [ 8, 4.5, 11.5, 6 ], "texture": "#pattern" }
5050
}
5151
},
5252
{
5353
"from": [ 3.75, 1, 0 ],
5454
"to": [ 8 , 4, 4 ],
5555
"faces": {
56-
"north": { "texture": "#inner_a" },
56+
"north": { "texture": "#inner_a", "cullface": "north" },
5757
"west": { "uv": [ 8, 6, 10, 7.5 ], "texture": "#pattern" }
5858
}
5959
},
6060
{
6161
"from": [ 0.5, 0, 10 ],
6262
"to": [ 8 , 10, 13 ],
6363
"faces": {
64-
"down": { "texture": "#inner_b" },
64+
"down": { "texture": "#inner_b", "cullface": "down" },
6565
"west": { "uv": [ 13, 3, 14.5, 8 ], "texture": "#pattern" }
6666
}
6767
},
6868
{
6969
"from": [ 1.5, 0, 7 ],
7070
"to": [ 8 , 7, 10 ],
7171
"faces": {
72-
"down": { "texture": "#inner_b" },
72+
"down": { "texture": "#inner_b", "cullface": "down" },
7373
"west": { "uv": [ 11.5, 4.5, 13, 8 ], "texture": "#pattern" }
7474
}
7575
},
7676
{
7777
"from": [ 2.5, 0, 4 ],
7878
"to": [ 8 , 4, 7 ],
7979
"faces": {
80-
"down": { "texture": "#inner_b" },
80+
"down": { "texture": "#inner_b", "cullface": "down" },
8181
"west": { "uv": [ 10, 6, 11.5, 8 ], "texture": "#pattern" }
8282
}
8383
},
8484
{
8585
"from": [ 3.5, 0, 1 ],
8686
"to": [ 8 , 1, 4 ],
8787
"faces": {
88-
"down": { "texture": "#inner_b" },
88+
"down": { "texture": "#inner_b", "cullface": "down" },
8989
"west": { "uv": [ 8.5, 7.5, 10, 8 ], "texture": "#pattern" }
9090
}
9191
},
9292
{
9393
"from": [ 4.25, 0, 0 ],
9494
"to": [ 8 , 1, 1 ],
9595
"faces": {
96-
"down": { "texture": "#inner_b" },
97-
"north": { "texture": "#inner_a" },
96+
"down": { "texture": "#inner_b", "cullface": "down" },
97+
"north": { "texture": "#inner_a", "cullface": "north" },
9898
"west": { "uv": [ 8, 7.5, 8.5, 8 ], "texture": "#pattern" }
9999
}
100100
},

0 commit comments

Comments
 (0)