Skip to content

Commit d9c050b

Browse files
authored
Remove refdes mode and update HDL submodule (#153)
By removing the argument, this uses the new refdes + pathname in value, which should be a good all-around mode.
1 parent 8e7bf68 commit d9c050b

File tree

3 files changed

+2
-39
lines changed

3 files changed

+2
-39
lines changed

PolymorphicBlocks

Submodule PolymorphicBlocks updated 191 files

src/main/scala/edg_ide/runner/CompileProcessHandler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ class CompileProcessHandler(
422422
ElemBuilder.LibraryPath(packagePrefix + "edg.electronics_model.NetlistBackend"),
423423
compiled,
424424
compiler.getAllSolved,
425-
Map("RefdesMode" -> options.toggle.toString)
425+
Map()
426426
).mapErr(msg => s"while netlisting: $msg")
427427
.get
428428
require(netlist.size == 1)

src/main/scala/edg_ide/runner/DesignTopRunConfigurationType.scala

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -47,21 +47,9 @@ class DesignTopConfigurationFactory(confType: ConfigurationType) extends Configu
4747
classOf[DesignTopRunConfigurationOptions]
4848
}
4949

50-
object RefdesMode extends Enumeration {
51-
type selections = Value
52-
53-
val refdes = Value(0, "refdes")
54-
val pathName = Value(1, "pathName")
55-
56-
def toEnum(s: String): Option[Value] = {
57-
values.find(_.toString == s)
58-
}
59-
}
60-
6150
class DesignTopRunConfigurationOptions extends RunConfigurationOptions {
6251
var designName: String = ""
6352
var netlistFile: String = ""
64-
var toggle: RefdesMode.selections = RefdesMode.refdes
6553
var bomFile: String = ""
6654
var pdfFile: String = ""
6755
}
@@ -95,7 +83,6 @@ class DesignTopRunConfiguration(project: Project, factory: ConfigurationFactory,
9583

9684
val kFieldDesignName = "DESIGN_NAME"
9785
val kFieldNetlistName = "NETLIST_NAME"
98-
val kFieldRefdesMode = "REFDESMODE_NAME"
9986
val kPdfFileName = "PDF_NAME"
10087
val kBomFileName = "BOM_NAME"
10188

@@ -104,7 +91,6 @@ class DesignTopRunConfiguration(project: Project, factory: ConfigurationFactory,
10491
super.readExternal(element)
10592
options.designName = JDOMExternalizerUtil.readField(element, kFieldDesignName, "")
10693
options.netlistFile = JDOMExternalizerUtil.readField(element, kFieldNetlistName, "")
107-
RefdesMode.toEnum(JDOMExternalizerUtil.readField(element, kFieldRefdesMode)).foreach(options.toggle = _)
10894
options.bomFile = JDOMExternalizerUtil.readField(element, kBomFileName, "")
10995
options.pdfFile = JDOMExternalizerUtil.readField(element, kPdfFileName, "")
11096
}
@@ -113,7 +99,6 @@ class DesignTopRunConfiguration(project: Project, factory: ConfigurationFactory,
11399
super.writeExternal(element)
114100
JDOMExternalizerUtil.writeField(element, kFieldDesignName, options.designName)
115101
JDOMExternalizerUtil.writeField(element, kFieldNetlistName, options.netlistFile)
116-
JDOMExternalizerUtil.writeField(element, kFieldRefdesMode, options.toggle.toString)
117102
JDOMExternalizerUtil.writeField(element, kBomFileName, options.bomFile)
118103
JDOMExternalizerUtil.writeField(element, kPdfFileName, options.pdfFile)
119104
}
@@ -122,20 +107,13 @@ class DesignTopRunConfiguration(project: Project, factory: ConfigurationFactory,
122107
class DesignTopSettingsEditor(project: Project) extends SettingsEditor[DesignTopRunConfiguration] {
123108
protected val designName = new JTextField()
124109
protected val netlistFile = new JTextField() // no browse button b/c FileChooser can't create new files
125-
protected val toggleRefdes = new JBRadioButton()
126-
protected val togglePathname = new JBRadioButton()
127-
protected val toggleButtons = new ButtonGroup()
128-
toggleButtons.add(toggleRefdes)
129-
toggleButtons.add(togglePathname)
130110
protected val bomFile = new JTextField()
131111
protected val pdfFile = new JTextField()
132112

133113
protected val panel = FormBuilder
134114
.createFormBuilder()
135115
.addLabeledComponent(new JBLabel("Design top name"), designName, false)
136116
.addLabeledComponent(new JBLabel("Netlist output file"), netlistFile, false)
137-
.addLabeledComponent(new JBLabel("Select Netlist Refdes value"), toggleRefdes)
138-
.addLabeledComponent(new JBLabel("Select Netlist Path Name"), togglePathname)
139117
.addLabeledComponent(new JBLabel("BOM output file"), bomFile, false)
140118
.addLabeledComponent(new JBLabel("PDF output file"), pdfFile, false)
141119
.addComponentFillVertically(new JPanel(), 0)
@@ -144,28 +122,13 @@ class DesignTopSettingsEditor(project: Project) extends SettingsEditor[DesignTop
144122
override def resetEditorFrom(s: DesignTopRunConfiguration): Unit = {
145123
designName.setText(s.options.designName)
146124
netlistFile.setText(s.options.netlistFile)
147-
s.options.toggle match {
148-
case RefdesMode.refdes =>
149-
toggleRefdes.setSelected(true)
150-
togglePathname.setSelected(false)
151-
case RefdesMode.pathName =>
152-
toggleRefdes.setSelected(false)
153-
togglePathname.setSelected(true)
154-
}
155125
bomFile.setText(s.options.bomFile)
156126
pdfFile.setText(s.options.pdfFile)
157127
}
158128

159129
override def applyEditorTo(s: DesignTopRunConfiguration): Unit = {
160130
s.options.designName = designName.getText
161131
s.options.netlistFile = netlistFile.getText
162-
if (toggleRefdes.isSelected) {
163-
s.options.toggle = RefdesMode.refdes
164-
} else if (togglePathname.isSelected) {
165-
s.options.toggle = RefdesMode.pathName
166-
} else {
167-
// Ignore invalid user selection
168-
}
169132
s.options.bomFile = bomFile.getText
170133
s.options.pdfFile = pdfFile.getText
171134
}

0 commit comments

Comments
 (0)