Skip to content

Commit f6d533a

Browse files
committed
fix req changes from greptile
1 parent 28506f8 commit f6d533a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

litellm/litellm_core_utils/litellm_logging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ def update_from_kwargs(
589589
if "litellm_metadata" in kwargs and isinstance(
590590
kwargs["litellm_metadata"], dict
591591
):
592-
base_litellm_params["litellm_metadata"] = kwargs["litellm_metadata"]
592+
base_litellm_params["litellm_metadata"] = kwargs["litellm_metadata"].copy()
593593

594594
if litellm_params:
595595
base_litellm_params.update(litellm_params)

tests/test_litellm/litellm_core_utils/test_litellm_logging.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,8 @@ def test_merge_survives_litellm_params_update(self, logging_obj):
270270
result_meta = logging_obj.litellm_params["metadata"]
271271
assert result_meta["from_caller"] is True
272272
assert result_meta["user_api_key_hash"] == "hashed-xyz"
273+
# caller's dict must not be mutated by the merge
274+
assert "user_api_key_hash" not in caller_metadata
273275

274276
def test_merge_handles_metadata_none(self, logging_obj):
275277
"""When metadata=None is explicitly in kwargs alongside litellm_metadata,

0 commit comments

Comments
 (0)