Skip to content

Move large text to conftest fixture #10662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomukmatthews
Copy link
Contributor

@tomukmatthews tomukmatthews commented May 8, 2025

Move large text to conftest fixture

Fixes import issues when running unit tests by making a test asset a fixture in the root conftest.py

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix
🧹 Refactoring

Screenshot 2025-05-08 at 16 37 51

Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 3:24pm

@msabramo
Copy link
Contributor

msabramo commented May 10, 2025

This sounds like it solves the same problem as #10606 and maybe it’s even nicer in that it puts it in conftest.py so there is no need for imports. I haven’t tested this as I’m on my phone but I like the idea.

@msabramo
Copy link
Contributor

Tested this and it works great! @krrishdholakia and @ishaan-jaff: do you think this could be merged? I haven't been able to run make test-unit successfully in a while and this fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants