Skip to content

Honor include block when loading config from bucket #10765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Bharat23
Copy link

Title

Honor include block when loading config from S3/GCS bucket
https://docs.litellm.ai/docs/proxy/config_management#examples-using-include

Relevant issues

Fixes #10632

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🆕 New Feature
✅ Test

Changes

  • Add process_includes_from_bucket in load_config_utils.py to recursively load include
  • Make get_file_contents_from_s3 async to make it consistent with get_config_file_contents_from_gcs
  • Add moto package to mock and test AWS S3
  • Add test cases for config loading using S3 with include.
Screenshot 2025-05-12 at 12 05 07

Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 4:00am

@CLAassistant
Copy link

CLAassistant commented May 12, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow include block in config to work with S3/GCS buckets
2 participants