Move hardcoded snowflakes into src/config.ts

The BetterDiscord guild id appeared four times across three files, the
developer role ids five times across two, and the account-issues channel and
AutoMod rule ids were inline constants in the files that used them. Changing
any of them meant grepping for a number.

src/config.ts collects all seven, each overridable by an environment variable
so the bot can be pointed at a test server without editing source:

  BD_GUILD_ID, BD_ROLE_PLUGIN_DEV, BD_ROLE_THEME_DEV,
  COMMUNITY_ROLE_PLUGIN_DEV, COMMUNITY_ROLE_THEME_DEV,
  BD_CHANNEL_ACCOUNT_ISSUES, BD_AUTOMOD_SPAM_LINK_RULE

Defaults are the values that were already inline, so behaviour is unchanged
with no environment set. Verified: all seven defaults match the literals they
replaced, and setting BD_GUILD_ID overrides that one while leaving the rest
alone.

src/util/web.ts keeps its release-channel ids. They are BetterDiscord website
data copied from the client repository rather than deployment configuration,
and the file documents its upstream source.

No inline snowflakes remain in src/ outside config.ts and web.ts.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hDX4g1EjTN7424A5wnptE

Author: claude

src/commands/developer.ts

@@ -1,5 +1,6 @@
 import {ApplicationCommandOptionType, ApplicationCommandType, ChatInputCommandInteraction, InteractionContextType, type GuildTextBasedChannel} from "discord.js";
 import {defineCommand} from "../framework";
+import config from "../config";
 import {guildDB} from "../db";
 import * as notices from "../util/notices";
 
@@ -35,8 +36,8 @@ async function add(interaction: ChatInputCommandInteraction<"cached">) {
     const targetUser = interaction.options.getUser("user", true);
     const roleName = interaction.options.getString("role", true);
 
-    const bdRoleId = roleName.toLowerCase().includes("plugin") ? "125166040689803264" : "165005972970930176";
-    const bdGuild = await interaction.client.guilds.fetch("86004744966914048");
+    const bdRoleId = roleName.toLowerCase().includes("plugin") ? config.roles.pluginDeveloper : config.roles.themeDeveloper;
+    const bdGuild = await interaction.client.guilds.fetch(config.guilds.betterDiscord);
     try {
         const member = await bdGuild.members.fetch(targetUser);
         try {
@@ -89,12 +90,12 @@ async function add(interaction: ChatInputCommandInteraction<"cached">) {
 
 async function sync(interaction: ChatInputCommandInteraction<"cached">) {
     const targetUser = interaction.options.getUser("user", true);
-    const bdGuild = await interaction.client.guilds.fetch("86004744966914048");
+    const bdGuild = await interaction.client.guilds.fetch(config.guilds.betterDiscord);
     const bdMember = await bdGuild.members.fetch(targetUser);
     if (!bdMember) return await interaction.reply(notices.error("User is not in BetterDiscord server!", {ephemeral: true}));
-    const isPluginDev = bdMember.roles.cache.has("125166040689803264");
-    const isThemeDev = bdMember.roles.cache.has("165005972970930176");
-    const rolesToAdd = [isPluginDev ? "948627723830591568" : "", isThemeDev ? "948627648706392104" : ""].filter(r => r);
+    const isPluginDev = bdMember.roles.cache.has(config.roles.pluginDeveloper);
+    const isThemeDev = bdMember.roles.cache.has(config.roles.themeDeveloper);
+    const rolesToAdd = [isPluginDev ? config.roles.communityPluginDeveloper : "", isThemeDev ? config.roles.communityThemeDeveloper : ""].filter(r => r);
 
     const communityMember = await interaction.guild.members.fetch(targetUser);
 

src/commands/spam.ts

@@ -1,11 +1,12 @@
 import {ApplicationCommandOptionType, ApplicationCommandType, ChatInputCommandInteraction, InteractionContextType, PermissionFlagsBits} from "discord.js";
 import {defineCommand} from "../framework";
+import config from "../config";
 import * as notices from "../util/notices";
 
 
 // TODO: move detectspam from moderation to here
 async function addLink(interaction: ChatInputCommandInteraction<"cached">) {
-    const rule = await interaction.guild.autoModerationRules.fetch("1256935881168781332");
+    const rule = await interaction.guild.autoModerationRules.fetch(config.automod.spamLinkRule);
     if (!rule) return await interaction.reply(notices.error("Spam link filter rule not found! Report this to Zerebos!", {ephemeral: true}));
 
     const existing = rule.triggerMetadata?.keywordFilter ?? [];

src/config.ts

@@ -0,0 +1,39 @@
+/**
+ * Every Discord snowflake and community-specific constant the bot depends on.
+ *
+ * These were inline literals scattered across six files — the BetterDiscord
+ * guild id appeared four times, the developer role ids five. Each entry may be
+ * overridden by an environment variable so the bot can be pointed at a test
+ * server without editing source.
+ */
+
+const id = (key: string, fallback: string): string => process.env[key] || fallback;
+
+export const config = {
+    guilds: {
+        /** The main BetterDiscord server. */
+        betterDiscord: id("BD_GUILD_ID", "86004744966914048")
+    },
+
+    roles: {
+        /** Roles in the main server that mark someone as a verified developer. */
+        pluginDeveloper: id("BD_ROLE_PLUGIN_DEV", "125166040689803264"),
+        themeDeveloper: id("BD_ROLE_THEME_DEV", "165005972970930176"),
+
+        /** The equivalents in the developer community server, kept in sync. */
+        communityPluginDeveloper: id("COMMUNITY_ROLE_PLUGIN_DEV", "948627723830591568"),
+        communityThemeDeveloper: id("COMMUNITY_ROLE_THEME_DEV", "948627648706392104")
+    },
+
+    channels: {
+        /** Where compromised-account warnings are posted. */
+        accountIssues: id("BD_CHANNEL_ACCOUNT_ISSUES", "1465301762821853204")
+    },
+
+    automod: {
+        /** The AutoMod rule whose keyword list `/spam link` appends to. */
+        spamLinkRule: id("BD_AUTOMOD_SPAM_LINK_RULE", "1256935881168781332")
+    }
+} as const;
+
+export default config;

src/events/detectcryptoscam.ts

@@ -1,11 +1,10 @@
 import {Events, Message, PermissionFlagsBits} from "discord.js";
+import config from "../config";
 import {guildDB} from "../db";
 import {sendModLog} from "../util/modlog";
 
 
 const TIMEOUT_DURATION = 60 * 60 * 1000; // 1 hour in milliseconds
-const TARGET_GUILD_ID = "86004744966914048";
-const ACCOUNT_ISSUES_CHANNEL_ID = "1465301762821853204";
 const sketchyImageRegex = /https:\/\/(?:cdn|media)\.(?:discord|discordapp)\.(?:com|net)\/attachments\/\d+\/\d+\/(?:[1234]|image)\.(?:jpg|png|webp)(?:\?.*?)?(?:\s+|$)/;
 
 // TODO: consider de-duping with invitefilter event
@@ -16,7 +15,7 @@ export default {
         // Ignore DM messages and owner messages and people with manage messages perms
         if (!message.inGuild() || message.author.id === process.env.BOT_OWNER_ID) return;
         if (message.author.id === message.client.user.id) return;
-        if (message.guild.id !== TARGET_GUILD_ID) return;
+        if (message.guild.id !== config.guilds.betterDiscord) return;
         if (message.channel.permissionsFor(message.author)?.has(PermissionFlagsBits.ManageMessages)) return;
 
         // Obviously if this is disabled we don't need to do this stuff either
@@ -48,7 +47,7 @@ export default {
             console.error("Could not timeout member. Likely permissions.");
         }
 
-        const accountIssuesChannel = message.guild.channels.cache.get(ACCOUNT_ISSUES_CHANNEL_ID);
+        const accountIssuesChannel = message.guild.channels.cache.get(config.channels.accountIssues);
         if (accountIssuesChannel && accountIssuesChannel.isTextBased()) {
             await accountIssuesChannel.send({content: `${message.author.toString()} (${message.author.id}) your account may be compromised! Change your password and remove any unfamiliar account connections and authorized apps.`});
         }

src/events/developer.ts

@@ -1,17 +1,18 @@
 import {Events, GuildMember} from "discord.js";
+import config from "../config";
 
 
 export default {
     name: Events.GuildMemberAdd,
 
     async execute(member: GuildMember) {
-        const bdGuild = await member.client.guilds.fetch("86004744966914048");
+        const bdGuild = await member.client.guilds.fetch(config.guilds.betterDiscord);
         const bdMember = await bdGuild.members.fetch(member);
         if (!bdMember) return;
 
-        const isPluginDev = bdMember.roles.cache.has("125166040689803264");
-        const isThemeDev = bdMember.roles.cache.has("165005972970930176");
-        const rolesToAdd = [isPluginDev ? "948627723830591568" : "", isThemeDev ? "948627648706392104" : ""].filter(r => r);
+        const isPluginDev = bdMember.roles.cache.has(config.roles.pluginDeveloper);
+        const isThemeDev = bdMember.roles.cache.has(config.roles.themeDeveloper);
+        const rolesToAdd = [isPluginDev ? config.roles.communityPluginDeveloper : "", isThemeDev ? config.roles.communityThemeDeveloper : ""].filter(r => r);
 
         try {
             await member.roles.add(rolesToAdd, "Syncing roles from main server");