Skip to content

element drawers should not be stored statically #336

@ivanjx

Description

@ivanjx

each ElementDrawers have its own SKCanvas and on servers it can cause SkiaSharp to crash. some objects may also not be rendered correctly or skipped being rendered entirely with the current approach.

Fatal error.
0xC0000005
at SkiaSharp.SkiaApi.sk_canvas_draw_text_blob(IntPtr, IntPtr, Single, Single, IntPtr)
at SkiaSharp.SKCanvas.DrawText(SkiaSharp.SKTextBlob, Single, Single, SkiaSharp.SKPaint)
at SkiaSharp.HarfBuzz.CanvasExtensions.DrawShapedText(SkiaSharp.SKCanvas, SkiaSharp.HarfBuzz.SKShaper, System.String, Single, Single, SkiaSharp.SKTextAlign, SkiaSharp.SKFont, SkiaSharp.SKPaint)
at SkiaSharp.HarfBuzz.CanvasExtensions.DrawShapedText(SkiaSharp.SKCanvas, System.String, Single, Single, SkiaSharp.SKTextAlign, SkiaSharp.SKFont, SkiaSharp.SKPaint)
at SkiaSharp.HarfBuzz.CanvasExtensions.DrawShapedText(SkiaSharp.SKCanvas, System.String, Single, Single, SkiaSharp.SKFont, SkiaSharp.SKPaint)
at BinaryKits.Zpl.Viewer.ElementDrawers.BarcodeDrawerBase.DrawInterpretationLine(System.String, SkiaSharp.SKFont, Single, Single, Int32, Int32, Boolean, BinaryKits.Zpl.Label.FieldOrientation, Boolean, BinaryKits.Zpl.Viewer.ElementDrawers.DrawerOptions)
...

a fix like this eliminates the error and the buggy behavior: ivanjx@56ed1f9

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions