Wrap zarr-java S3 failures in StoreAccessException

S3Store reported S3 errors as the AWS SDK's unchecked SdkException, which
escaped the StoreException-only catch and surfaced unhandled in Fiji. Catch
both exception types now and drop the MockedConstruction from
storeAccessErrorIsReportedToErrorHandler so ZARR_JAVA exercises the same
real path as N5.

Author: stefanhahmann

ome-zarr-fiji-ui/src/test/java/ome/zarr/fijiui/open/ZarrOpenActionsTest.java

@@ -42,7 +42,6 @@
 import static org.mockito.Mockito.mockStatic;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
 import static ome.zarr.ZarrTestUtils.IMAGE_NAME;
 
 import net.imagej.Dataset;
@@ -95,8 +94,6 @@
 import ij.ImagePlus;
 import ome.zarr.fijiui.settings.UserScriptSettings;
 import ome.zarr.fiji.Pyramidal;
-import ome.zarr.zarrjava.ZarrJavaPyramidBackend;
-import ome.zarr.imglib2.exceptions.StoreAccessException;
 import ome.zarr.imglib2.PyramidBackend;
 import ome.zarr.imglib2.PyramidContents;
 import ome.zarr.fiji.open.ZarrOpener;
@@ -685,29 +682,10 @@ void storeAccessErrorIsReportedToErrorHandler( final ZarrReaderBackend backend )
 			final ZarrOpeningSettings settings = new ZarrOpeningSettings();
 			settings.setReaderBackend( backend );
 
-			if ( backend == ZarrReaderBackend.ZARR_JAVA )
-			{
-				try (MockedConstruction< ZarrJavaPyramidBackend > mock = mockConstruction(
-						ZarrJavaPyramidBackend.class,
-						( mockBackend, ctx ) -> when( mockBackend.load( any() ) )
-								.thenThrow( new StoreAccessException( uri.toString(),
-										new RuntimeException( "Access Denied (403)" ) ) ) ))
-				{
-					final ZarrOpenActions actions = new ZarrOpenActions( uri, context, settings, capturedError::set );
-					assertDoesNotThrow( () -> {
-						actions.openIJWithImage();
-					} );
-					assertEquals( 1, mock.constructed().size(), "Expected exactly one ZarrJavaPyramidBackend to be constructed" );
-				}
-			}
-			else
-			{
-				// N5 backend throws N5Exception.N5IOException immediately (local failure, no network needed)
-				final ZarrOpenActions actions = new ZarrOpenActions( uri, context, settings, capturedError::set );
-				assertDoesNotThrow( () -> {
-					actions.openIJWithImage();
-				} );
-			}
+			final ZarrOpenActions actions = new ZarrOpenActions( uri, context, settings, capturedError::set );
+			assertDoesNotThrow( () -> {
+				actions.openIJWithImage();
+			}, "Store access failures must not escape openIJWithImage() for backend " + backend );
 
 			assertNotNull( capturedError.get(), "Error handler should have been called for backend " + backend );
 			assertTrue( capturedError.get().contains( uri.toString() ),

ome-zarr-zarrjava/src/main/java/ome/zarr/zarrjava/ZarrJavaPyramidBackend.java

@@ -61,6 +61,7 @@
 import software.amazon.awssdk.auth.credentials.AnonymousCredentialsProvider;
 import software.amazon.awssdk.auth.credentials.AwsCredentialsProviderChain;
 import software.amazon.awssdk.auth.credentials.DefaultCredentialsProvider;
+import software.amazon.awssdk.core.exception.SdkException;
 import software.amazon.awssdk.regions.Region;
 import software.amazon.awssdk.services.s3.S3Client;
 
@@ -260,11 +261,9 @@ else if ( "s3".equalsIgnoreCase( scheme ) )
 		{
 			return openMultiscaleImageFromHandle( store.resolve() );
 		}
-		catch ( StoreException e )
+		catch ( StoreException | SdkException e )
 		{
-			// Store-level failure (e.g., S3 auth failure, missing bucket, network
-			// error) before we could reach the dataset. Wrap in a backend-agnostic
-			// exception.
+			// Store-level failures. Wrap them in a backend-agnostic exception.
 			throw new StoreAccessException( inputUri.toString(), e );
 		}
 	}