Agent search: fast recent list with lazy per-card snippet loading (#74)

* Agent search recent open state and footer hints

* Agent search global Cmd+O shortcut

* Agent search keyboard scroll follow

* recent-agents: add limit param to getRecentAgents and GET /agents/recent

- agents-db.ts: getRecentAgents(query?, limit?) applies LIMIT in SQL before returning rows
- get-recent-agents.ts: parse ?limit= query param, validate positive integer, pass to agentsDB
- Tests for both: failing first (TDD), then implementation

* recent-agents: pass limit=50 from AgentSearchDialog; add limit param to fetchRecentAgents

- agents-api.ts: fetchRecentAgents(workspaceId, query?, limit?) passes ?limit=N in URL
- AgentSearchDialog.tsx: call fetchRecentAgents with RECENT_LIMIT=50; remove client-side slice
- AgentSearchDialog.test.tsx: update assertions to match new call signature

* recent-agents: strip message loading from list endpoint; add /messages/snippet

- get-recent-agents.ts: returns DB rows only — no harness calls, no Promise.all
- get-agent-snippet.ts: new endpoint GET /agents/:id/messages/snippet, returns
  lastMessageAt/lastUserMessage/lastAgentMessage for one agent
- agents.ts: register snippet route before /:id/messages to avoid Hono match order issue
- agents.recent.test.ts: remove message-context describe block, update response shape assertions
- get-agent-snippet.test.ts: new TDD tests for snippet endpoint

* Agent search: lazy-load recent snippets per visible card

* Agent search: hide unloaded recent timestamps

* WorkspaceLayout: separate palette and agent-search bindings

Prevent the user-configured command palette shortcut from being overwritten when it collides with +o. Add a regression test that verifies both shortcuts stay active when they share the same key combo.

* AgentTypeahead: lazy-load @@ snippet previews

* Change keyboard shortcuts

* Agent search: Right Shift again dismisses the peek

* Revert "Agent search: Right Shift again dismisses the peek"

This reverts commit 9e66c06.

* AgentModal: Right Shift dismisses the peek (mirrors Escape)

* Agent search: pointer-move intent gate prevents mouse hijacking keyboard selection

* docs: document Corvu mock prop forwarding and render helper side effects

* Agent search: suppress hover highlight during keyboard navigation

* Agent search: restyle footer hints — label first, key second

* Agent search: footer hints — bold action labels, mono shortcut keys

* Agent search: reorder footer hints — navigate, open, peek

Author: crayment

projects/birdhouse/docs/code-review/testing.md

@@ -30,15 +30,60 @@ createEffect(() => {
 
 ---
 
-## Coming Soon
-
-This guide will cover:
-- Component testing patterns
-- Testing user interactions
-- Snapshot testing
-- Mock strategies
-
-**For now, see:**
-- `src/components/ui/Button.test.tsx` - Example component test
-- `src/workspace-config/components/WorkspaceConfigDialog.test.tsx` - Resource error testing
-- Run: `bun run test` or `bun run test:watch`
+## Corvu Component Mocks Are Load-Bearing
+
+When a Corvu primitive (Dialog, Popover, Drawer, etc.) is mocked in a test file, the mock's
+prop interface becomes part of the test infrastructure. If the real component adds a new event
+handler prop — `onKeyUp`, `onFocus`, `onPointerDown`, etc. — and the mock doesn't forward it,
+the handler silently disappears. The test won't fail with a clear error; it will just never fire.
+
+**Symptom:** You add a new event handler to a Corvu component in production code. Tests that
+exercise that handler pass zero calls to the mock function, even though the handler works in
+the browser.
+
+**Cause:** The mock `Dialog.Content` (or equivalent) only forwards the props it was originally
+written to accept. New props are ignored unless explicitly added.
+
+**Fix:** Keep the mock's prop type in sync with what the component actually uses. When you add
+a handler to `Dialog.Content` in the component, add the same prop to the mock:
+
+```tsx
+// In the test file's vi.mock("corvu/dialog", ...) block:
+Dialog.Content = (props: {
+  children: JSX.Element;
+  class?: string;
+  onKeyDown?: (e: KeyboardEvent) => void;
+  onKeyUp?: (e: KeyboardEvent) => void;  // ← add when component uses it
+}) => (
+  <div role="presentation" onKeyDown={props.onKeyDown} onKeyUp={props.onKeyUp}>
+    {props.children}
+  </div>
+);
+```
+
+The mock in `AgentSearchDialog.test.tsx` is the canonical reference for this pattern.
+
+---
+
+## Test Helper Side Effects
+
+Test files often define small helpers like `renderDialog()` that set up shared mutable state
+before rendering. If that helper resets state you've already configured, tests silently use the
+wrong setup.
+
+**Symptom:** You set a shared variable (e.g. `mockModalStack`) before calling a render helper,
+but the test behaves as if your assignment never happened.
+
+**Cause:** The render helper resets the variable as a side effect.
+
+**Fix:** Document the side effects on the helper, and in tests that need non-default state,
+set the variable *after* calling the helper:
+
+```ts
+// renderDialog resets mockModalStack as a side effect — set it after if needed
+renderDialog();
+mockModalStack = [{ type: "agent-search", id: "main" }, { type: "agent", id: "agent-1" }];
+await screen.findByLabelText("Search agent messages");
+```
+
+See `AgentSearchDialog.test.tsx` for a working example of both patterns.

projects/birdhouse/frontend/src/components/AgentModal.tsx

@@ -50,6 +50,11 @@ const AgentModal: Component<AgentModalProps> = (props) => {
             "max-width": `calc(1792px - ${sizeReduction}px)`,
             "z-index": baseZIndex + 2,
           }}
+          onKeyUp={(e: KeyboardEvent) => {
+            if (e.code === "ShiftRight" && !e.metaKey && !e.ctrlKey && !e.altKey && props.isTop) {
+              props.onClose();
+            }
+          }}
         >
           {/* Provide increased z-index context to children (dialogs, popovers) */}
           <ZIndexProvider baseZIndex={baseZIndex + 10}>