Skip to content

Commit c694f01

Browse files
Vladimir Nikolićlcoombe
andauthored
Update parameters (#378)
* Update parameters Co-authored-by: Lauren Coombe <lauren.e.coombe@gmail.com>
1 parent 3e21675 commit c694f01

2 files changed

Lines changed: 15 additions & 6 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -474,14 +474,14 @@ Parameters of the driver script, `abyss-pe`
474474
* `kc`: minimum k-mer count threshold for Bloom filter assembly [`2`]
475475
* `K`: the length of a single k-mer in a k-mer pair (bp)
476476
* `l`: minimum alignment length of a read (bp) [`40`]
477-
* `m`: minimum overlap of two unitigs (bp) [`0` (interpreted as `k - 1`)]
477+
* `m`: minimum overlap of two unitigs (bp) [`0` (interpreted as `k - 1`) if `mp` is provided or if `k<=50`, otherwise `50`]
478478
* `n`: minimum number of pairs required for building contigs [`10`]
479-
* `N`: minimum number of pairs required for building scaffolds [`n`]
479+
* `N`: minimum number of pairs required for building scaffolds [`15-20`]
480480
* `np`: number of MPI processes [`1`]
481481
* `p`: minimum sequence identity of a bubble [`0.9`]
482482
* `q`: minimum base quality [`3`]
483483
* `s`: minimum unitig size required for building contigs (bp) [`1000`]
484-
* `S`: minimum contig size required for building scaffolds (bp) [`1000-10000`]
484+
* `S`: minimum contig size required for building scaffolds (bp) [`100-5000`]
485485
* `t`: maximum length of blunt contigs to trim [`k`]
486486
* `v`: use `v=-v` for verbose logging, `v=-vv` for extra verbose
487487
* `x`: spaced seed (Bloom filter assembly only)

bin/abyss-pe

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,9 @@ endif
153153
endif
154154

155155
pe?=$(lib)
156+
ifdef mp
157+
mp_provided=1
158+
endif
156159
mp?=$(pe)
157160

158161
# Strip spaces from the file paths
@@ -233,7 +236,13 @@ abyssopt += $(dbopt) $(SS) --coverage-hist=coverage.hist -s $*-bubbles.fa
233236
endif
234237

235238
# AdjList parameters
236-
m?=0
239+
ifdef mp_provided
240+
m?=0
241+
else ifeq ($(shell test $(k) -le 50; echo $$?),0)
242+
m?=0
243+
else
244+
m?=50
245+
endif
237246
alopt += $v $(dbopt) $(SS) -k$k -m$m
238247
ifndef B
239248
ifdef K
@@ -337,8 +346,8 @@ mcopt += $v $(dbopt) -k$k
337346

338347
# Scaffold parameters
339348
L?=$l
340-
S?=1000-10000
341-
N?=$n
349+
S?=100-5000
350+
N?=15-20
342351
SCAFFOLD_DE_S?=$(shell echo $S | sed 's/-.*//')
343352
SCAFFOLD_DE_N?=$N
344353
SCAFFOLD_DE_OPTIONS?=$(DISTANCEEST_OPTIONS)

0 commit comments

Comments
 (0)