Skip to content

Commit 2d294d3

Browse files
committed
Clean up comments
1 parent 167e067 commit 2d294d3

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

.github/workflows/cpp_extra.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,6 @@ jobs:
384384
run-options: >-
385385
-e ARROW_FLIGHT_SQL_ODBC_INSTALLER=ON
386386
-e ODBC_PACKAGE_FORMAT=RPM
387-
# -AL- todo add DEB
388387
- image: ubuntu-cpp-odbc
389388
title: AMD64 Ubuntu DEB Release
390389
build-type: release

cpp/src/arrow/flight/sql/odbc/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -178,16 +178,14 @@ if(ARROW_FLIGHT_SQL_ODBC_INSTALLER)
178178
# Linux
179179
set(CPACK_PACKAGE_INSTALL_DIRECTORY "${CPACK_PACKAGE_NAME}")
180180
if(${ODBC_PACKAGE_FORMAT} STREQUAL "DEB")
181-
# -AL- todo delete all `GH-49595` comments
182-
# -AL- todo implement.
183-
184181
set(CPACK_DEBIAN_PACKAGE_ARCHITECTURE amd64)
185182
set(CPACK_GENERATOR DEB)
186183
set(CPACK_RPM_POST_INSTALL_SCRIPT_FILE
187184
"${CMAKE_CURRENT_SOURCE_DIR}/install/linux/postinst")
188185
set(CPACK_DEBIAN_FILE_NAME "${ODBC_UNIX_FILE_NAME}.deb")
189186
set(CPACK_DEBIAN_PACKAGE_MAINTAINER "${CPACK_PACKAGE_CONTACT}")
190187
set(CPACK_DEBIAN_PACKAGE_SHLIBDEPS OFF)
188+
# Exclude Unspecified components
191189
set(CPACK_DEB_COMPONENT_INSTALL ON)
192190
set(CPACK_COMPONENTS_GROUPING ALL_COMPONENTS_IN_ONE)
193191
elseif(${ODBC_PACKAGE_FORMAT} STREQUAL "RPM")

0 commit comments

Comments
 (0)