Windows CI to Support ODBC DLL & MSI Signing

* Add draft code for CI A and CI B

Attempt workflow dispatch

Only ODBC Windows original workflow should run.
Later need to add `github.event_name != 'workflow_dispatch' ||` to all existing workflows after uncomment

Use `GITHUB_REF_NAME` directly via push

Add `workflow_dispatch` definitions

Add `ODBC Windows Upload DLL`

Use common ODBC Windows environment variables

Use ODBC as composite action

Create cpp_odbc.yml

Initial draft

temp disable test step

Temp disable non-ODBC Windows workflows

* Clean Up Code

* Remove comments

* Fix Installer path for MSI

Trigger CI

Fix issue with `secrets.GITHUB_TOKEN`

Change `odbc_msi_upload` to boolean input

Change `odbc-msvc-upload-dll` to be triggered via rc tag and can be invoked manually

Work on Bryce's code review comments

Author: alinaliBQ

.github/actions/odbc-windows/action.yml

@@ -0,0 +1,96 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: ODBC Windows Reusable
+inputs:
+  github-token:
+    description: 'GITHUB_TOKEN for vcpkg caching'
+    required: true
+runs:
+  using: "composite"
+  steps:
+    - name: Disable Crash Dialogs
+      shell: pwsh
+      run: |
+        reg add `
+          "HKCU\SOFTWARE\Microsoft\Windows\Windows Error Reporting" `
+          /v DontShowUI `
+          /t REG_DWORD `
+          /d 1 `
+          /f
+    - name: Download Timezone Database
+      shell: bash
+      run: ci/scripts/download_tz_database.sh
+    - name: Install ccache
+      shell: bash
+      run: |
+        ci/scripts/install_ccache.sh 4.12.1 /usr
+    - name: Setup ccache
+      shell: bash
+      run: |
+        ci/scripts/ccache_setup.sh
+    - name: ccache info
+      id: ccache-info
+      shell: bash
+      run: |
+        echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT
+    - name: Cache ccache
+      uses: actions/cache@v5
+      with:
+        path: ${{ steps.ccache-info.outputs.cache-dir }}
+        key: cpp-odbc-ccache-windows-x64-${{ hashFiles('cpp/**') }}
+        restore-keys: cpp-odbc-ccache-windows-x64-
+    - name: Checkout vcpkg
+      uses: actions/checkout@v6
+      with:
+        persist-credentials: false
+        fetch-depth: 0
+        path: vcpkg
+        repository: microsoft/vcpkg
+    - name: Bootstrap vcpkg
+      shell: pwsh
+      run: |
+        vcpkg\bootstrap-vcpkg.bat
+        $VCPKG_ROOT = $(Resolve-Path -LiteralPath "vcpkg").ToString()
+        Write-Output ${VCPKG_ROOT} | `
+          Out-File -FilePath ${Env:GITHUB_PATH} -Encoding utf8 -Append
+        Write-Output "VCPKG_ROOT=${VCPKG_ROOT}" | `
+          Out-File -FilePath ${Env:GITHUB_ENV} -Encoding utf8 -Append
+    - name: Setup NuGet credentials for vcpkg caching
+      shell: bash
+      run: |
+        $(vcpkg fetch nuget | tail -n 1) \
+          sources add \
+          -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \
+          -storepasswordincleartext \
+          -name "GitHub" \
+          -username "$GITHUB_REPOSITORY_OWNER" \
+          -password "${{ inputs.github-token }}"
+        $(vcpkg fetch nuget | tail -n 1) \
+          setapikey "${{ inputs.github-token }}" \
+          -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"
+    - name: Build
+      shell: cmd
+      run: |
+        set VCPKG_ROOT_KEEP=%VCPKG_ROOT%
+        call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
+        set VCPKG_ROOT=%VCPKG_ROOT_KEEP%
+        bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build"
+    - name: Register Flight SQL ODBC Driver
+      shell: cmd
+      run: |
+        call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll

.github/workflows/cpp_extra.yml

@@ -559,81 +559,16 @@ jobs:
       VCPKG_BINARY_SOURCES: 'clear;nugettimeout,600;nuget,GitHub,readwrite'
       VCPKG_DEFAULT_TRIPLET: x64-windows
     steps:
-      - name: Disable Crash Dialogs
-        run: |
-          reg add `
-            "HKCU\SOFTWARE\Microsoft\Windows\Windows Error Reporting" `
-            /v DontShowUI `
-            /t REG_DWORD `
-            /d 1 `
-            /f
       - name: Checkout Arrow
         uses: actions/checkout@v6
         with:
           persist-credentials: false
           fetch-depth: 0
           submodules: recursive
-      - name: Download Timezone Database
-        shell: bash
-        run: ci/scripts/download_tz_database.sh
-      - name: Install ccache
-        shell: bash
-        run: |
-          ci/scripts/install_ccache.sh 4.12.1 /usr
-      - name: Setup ccache
-        shell: bash
-        run: |
-          ci/scripts/ccache_setup.sh
-      - name: ccache info
-        id: ccache-info
-        shell: bash
-        run: |
-          echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT
-      - name: Cache ccache
-        uses: actions/cache@v5
+      - name: Build ODBC Windows
+        uses: ./.github/actions/odbc-windows
         with:
-          path: ${{ steps.ccache-info.outputs.cache-dir }}
-          key: cpp-odbc-ccache-windows-x64-${{ hashFiles('cpp/**') }}
-          restore-keys: cpp-odbc-ccache-windows-x64-
-      - name: Checkout vcpkg
-        uses: actions/checkout@v6
-        with:
-          persist-credentials: false
-          fetch-depth: 0
-          path: vcpkg
-          repository: microsoft/vcpkg
-      - name: Bootstrap vcpkg
-        run: |
-          vcpkg\bootstrap-vcpkg.bat
-          $VCPKG_ROOT = $(Resolve-Path -LiteralPath "vcpkg").ToString()
-          Write-Output ${VCPKG_ROOT} | `
-            Out-File -FilePath ${Env:GITHUB_PATH} -Encoding utf8 -Append
-          Write-Output "VCPKG_ROOT=${VCPKG_ROOT}" | `
-            Out-File -FilePath ${Env:GITHUB_ENV} -Encoding utf8 -Append
-      - name: Setup NuGet credentials for vcpkg caching
-        shell: bash
-        run: |
-          $(vcpkg fetch nuget | tail -n 1) \
-            sources add \
-            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \
-            -storepasswordincleartext \
-            -name "GitHub" \
-            -username "$GITHUB_REPOSITORY_OWNER" \
-            -password "${{ secrets.GITHUB_TOKEN }}"
-          $(vcpkg fetch nuget | tail -n 1) \
-            setapikey "${{ secrets.GITHUB_TOKEN }}" \
-            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"
-      - name: Build
-        shell: cmd
-        run: |
-          set VCPKG_ROOT_KEEP=%VCPKG_ROOT%
-          call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
-          set VCPKG_ROOT=%VCPKG_ROOT_KEEP%
-          bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build"
-      - name: Register Flight SQL ODBC Driver
-        shell: cmd
-        run: |
-          call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll
+          github-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Test
         shell: cmd
         run: |
@@ -656,7 +591,7 @@ jobs:
           wix --version
           cd build/cpp
           cpack
-      - name: Upload the artifacts to the job
+      - name: Upload ODBC MSI to the job
         uses: actions/upload-artifact@v7
         with:
           name: flight-sql-odbc-msi-installer
@@ -745,40 +680,6 @@ jobs:
           remote_key: ${{ secrets.NIGHTLIES_RSYNC_KEY }}
           remote_host_key: ${{ secrets.NIGHTLIES_RSYNC_HOST_KEY }}
 
-  odbc-release:
-    needs: odbc-msvc
-    name: ODBC release
-    runs-on: ubuntu-latest
-    if: ${{ startsWith(github.ref_name, 'apache-arrow-') && contains(github.ref_name, '-rc') }}
-    permissions:
-      # Upload to GitHub Release
-      contents: write
-    steps:
-      - name: Checkout Arrow
-        uses: actions/checkout@v6
-        with:
-          persist-credentials: false
-          fetch-depth: 0
-          submodules: recursive
-      - name: Download the artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: flight-sql-odbc-msi-installer
-      - name: Wait for creating GitHub Release
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          dev/release/utils-watch-gh-workflow.sh \
-            ${GITHUB_REF_NAME} \
-            release_candidate.yml
-      - name: Upload the artifacts to GitHub Release
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          gh release upload ${GITHUB_REF_NAME} \
-            --clobber \
-            Apache-Arrow-Flight-SQL-ODBC-*-win64.msi
-
   report-extra-cpp:
     if: github.event_name == 'schedule' && always()
     needs: