Accept unknown witness versions for future softforks

afk11 · afk11 · commit 5e404b66c4b8 · 2019-11-08T00:14:50.000Z
diff --git a/src/Script/Interpreter/Interpreter.php b/src/Script/Interpreter/Interpreter.php
@@ -184,7 +184,8 @@ private function verifyWitnessProgram(WitnessProgram $witnessProgram, ScriptWitn
         } elseif ($flags & self::VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM) {
             return false;
         } else {
-            return false;
+            // Unknown versions are always 'valid' to permit future soft forks
+            return true;
         }
 
         $mainStack = new Stack();

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,8 @@ private function verifyWitnessProgram(WitnessProgram $witnessProgram, ScriptWitn`
`184`	`184`	`} elseif ($flags & self::VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM) {`
`185`	`185`	`return false;`
`186`	`186`	`} else {`
`187`		`- return false;`
	`187`	`+ // Unknown versions are always 'valid' to permit future soft forks`
	`188`	`+ return true;`
`188`	`189`	`}`
`189`	`190`
`190`	`191`	`$mainStack = new Stack();`