Skip to content

Commit 6b34fad

Browse files
committed
OP-551: Adjust FE compilation
1 parent 9b4101f commit 6b34fad

28 files changed

+74
-249
lines changed

doc/01-installation.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -117,18 +117,12 @@ bin/console doctrine:migrations:migrate
117117

118118
We recommend you to use Webpack (Encore), for which we have prepared four different instructions on how to add this plugin's assets to your project:
119119

120-
- [Import webpack config](./01.1-webpack-config.md)*
121-
- [Add entry to existing config](./01.2-webpack-entry.md)
122-
- [Import entries in your entry.js files](./01.3-import-entry.md)
123-
- [Your own custom config](./01.4-custom-solution.md)
120+
- [Add entry to existing config](./01.1-webpack-entry.md)
121+
- [Import entries in your entry.js files](./01.2-import-entry.md)
122+
- [Your own custom config](./01.3-custom-solution.md)
124123

125124
<small>* Default option for plugin development</small>
126125

127-
128-
However, if you are not using Webpack, here are instructions on how to add optimized and compressed assets directly to your project templates:
129-
130-
- [Non webpack solution](./01.5-non-webpack.md)
131-
132126
## Asynchronous Messenger case
133127

134128
In case you use asynchronous Messenger transport by default, there is a need to configure all Wishlist commands to sync transport.

doc/01.1-webpack-config.md

Lines changed: 0 additions & 67 deletions
This file was deleted.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414
// ./webpack.config.js
1515

1616
// Shop config
17-
.addEntry('bitbag-wishlist-shop', 'vendor/bitbag/wishlist-plugin/src/Resources/assets/shop/entry.js')
17+
.addEntry('bitbag-wishlist-shop', 'vendor/bitbag/wishlist-plugin/src/Resources/assets/shop/entrypoint.js')
1818

1919
// Admin config
20-
.addEntry('bitbag-wishlist-admin', 'vendor/bitbag/wishlist-plugin/src/Resources/assets/admin/entry.js')
20+
.addEntry('bitbag-wishlist-admin', 'vendor/bitbag/wishlist-plugin/src/Resources/assets/admin/entrypoint.js')
2121
```
2222

2323
2. Add encore functions to your templates
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,20 @@
22

33
- [⬅️ Back](./01-installation.md)
44

5-
## Installation - Import plugin entry into existing project entry.js files
5+
## Installation - Import plugin entry into existing project entrypoint.js files
66

77
- ✔️ Same webpack configuration for plugin and project assets
88
- ✔️ No need to edit templates - it's good for quick testing
99
- ⚠ Assets are loaded globally which can affect page speed
1010

1111
<br>
1212

13-
1. Just add these imports into your entry.js files
13+
1. Just add these imports into your entrypoint.js files
1414

1515
```js
16-
// ./assets/shop/entry.js
17-
import '../../vendor/bitbag/wishlist-plugin/src/Resources/assets/shop/entry.js';
16+
// ./assets/shop/entrypoint.js
17+
import '../../vendor/bitbag/wishlist-plugin/src/Resources/assets/shop/entrypoint.js';
1818

19-
// ./assets/admin/entry.js
20-
import '../../vendor/bitbag/wishlist-plugin/src/Resources/assets/admin/entry.js';
19+
// ./assets/admin/entrypoint.js
20+
import '../../vendor/bitbag/wishlist-plugin/src/Resources/assets/admin/entrypoint.js';
2121
```
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ Main entry points:
1010

1111
```js
1212
// shop
13-
.addEntry('/vendor/bitbag/wishlist-plugin/src/Resources/assets/shop/entry.js')
13+
.addEntry('/vendor/bitbag/wishlist-plugin/src/Resources/assets/shop/entrypoint.js')
1414

1515
// admin
16-
.addEntry('/vendor/bitbag/wishlist-plugin/src/Resources/assets/admin/entry.js')
16+
.addEntry('/vendor/bitbag/wishlist-plugin/src/Resources/assets/admin/entrypoint.js')
1717
```
1818

1919
Style entry points:
@@ -33,4 +33,4 @@ Location of the pictures:
3333

3434
---
3535

36-
More information: [Advanced Webpack Config](https://symfony.com/doc/current/frontend/encore/advanced-config.html)
36+
More information: [Advanced Webpack Config](https://symfony.com/doc/current/frontend/encore/advanced-config.html)

doc/01.5-non-webpack.md

Lines changed: 0 additions & 40 deletions
This file was deleted.

src/Resources/public/bitbag-wishlist-admin.css

Whitespace-only changes.

src/Resources/public/bitbag-wishlist-admin.js

Whitespace-only changes.

0 commit comments

Comments
 (0)