sha256 bug

[evgenykzz2]

Hi Nerds, i have found critical bug in nerdSHA256plus.cpp
There are invalid W size, it should be 64 bytes. I tested and compared with generic mbedtls_sha256_starts_ret.
Looks like current version calculates wrong sha256.

Also i have few optimization, i can increase hash rate up to 83KH/s.
Another thing - hardware sha256, hash rate is much better

Completed 0 share(s), 5678141 Khashes, avg. hashrate 130.87 KH/s

[BitMaker-hub]

Hi! this is interesting, can you write this into a PR or an issue to review it properly.
The current optimized lib was contrasted with other standard ones and there weren't any issue.
I also tested in past the hardware sha256 and directly I decided to not use it due to its poor timings.
Is surprising to me to know it's faster the Hw sha than the current lib

[evgenykzz2]

I have forked repo.
https://github.com/evgenykzz2/NerdMiner_v2
There is few thread fixes (i hope), crazy hashrate 197.80 KH/s (HW+SW).
Also i add mutex, and tiny nerdSha256 optimization.

About nerdsha256 bug. I got this message in debug:
nerdSHA256plus.cpp(666): error C4789: buffer 'W' of size 64 bytes will be overrun; 4 bytes will be written starting at offset 248

[BitMaker-hub]

Checked your work and looks pretty good, I'll try to test this week and create a PR. Seems a very cool achivement, congratulations!

[andrewjswan]

Checked your work and looks pretty good, I'll try to test this week and create a PR. Seems a very cool achivement, congratulations!

Any news?

[m8ax]

Hi Nerds, i have found critical bug in nerdSHA256plus.cpp There are invalid W size, it should be 64 bytes. I tested and compared with generic mbedtls_sha256_starts_ret. Looks like current version calculates wrong sha256.

Also i have few optimization, i can increase hash rate up to 83KH/s. Another thing - hardware sha256, hash rate is much better

Completed 0 share(s), 5678141 Khashes, avg. hashrate 130.87 KH/s

23:18:25.217 > >>> Completados 41 share(s), 170106 Khashes, Prom. hashrate 156.40 KH/s
23:18:26.107 > E (914133) task_wdt: Task watchdog got triggered. The following tasks did not reset the watchdog in time:
23:18:26.109 > E (914133) task_wdt: - MinerHw-0 (CPU 0/1)
23:18:26.113 > E (914133) task_wdt: Tasks currently running:
23:18:26.116 > E (914133) task_wdt: CPU 0: MinerHw-0
23:18:26.120 > E (914133) task_wdt: CPU 1: MinerSw-1
23:18:26.123 > E (914133) task_wdt: Aborting.
23:18:26.571 >
23:18:26.899 > abort() was called at PC 0x42046d78 on core 0
23:18:26.899 >
23:18:26.899 >
23:18:26.899 > Backtrace: 0x4037df92:0x3fc9d400 0x40383ea9:0x3fc9d420 0x40389c11:0x3fc9d440 0x42046d78:0x3fc9d4c0 0x4037f671:0x3fc9d4e0 0x420fc8da:0x3fcb8ea0 0x42011573:0x3fcb8ec0
23:18:26.899 >
23:18:26.899 > #0 0x4037df92:0x3fc9d400 in panic_abort at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/panic.c:408
23:18:26.899 > #1 0x40383ea9:0x3fc9d420 in esp_system_abort at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/esp_system.c:137
23:18:26.899 > #2 0x40389c11:0x3fc9d440 in abort at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/newlib/abort.c:46
23:18:26.899 > #3 0x42046d78:0x3fc9d4c0 in task_wdt_isr at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/task_wdt.c:176 (discriminator 3)
23:18:26.899 > #4 0x4037f671:0x3fc9d4e0 in _xt_lowint1 at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/freertos/port/xtensa/xtensa_vectors.S:1114
23:18:26.899 > #5 0x420fc8da:0x3fcb8ea0 in esp_dport_access_read_buffer at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_hw_support/port/esp32s3/dport_access.c:15 (discriminator 3)
23:18:26.899 > #6 0x42011573:0x3fcb8ec0 in minerWorkerHw(void*) at C:/Users/kuug3/.platformio/packages/framework-arduinoespressif32/tools/sdk/esp32s3/include/hal/esp32s3/include/hal/sha_ll.h:131
23:18:26.899 > (inlined by) minerWorkerHw(void*) at src/mining.cpp:497
23:18:26.899 >
23:18:26.899 >
23:18:26.899 >
23:18:26.899 >
23:18:26.899 > ELF file SHA256: fc06bd4236c48330
23:18:26.899 >
23:18:26.899 > Rebooting...

[holdupmaster]

how can we use the I2C? Does this allow multiple headless miners to share their hashrate with a esp that has a display ?

[jpduhen]

how can we use the I2C? Does this allow multiple headless miners to share their hashrate with a esp that has a display ?

Perhaps also share one central/shared WiFi-connection/-IP, I kind of run out of them in my home-network ;-)

[holdupmaster]

I suspect I2C doesn't have the bandwidth for that. I was thinking of a scenario where you have maybe 10 super mini's all mining, and providing their hashing data to a CYD miner - to display the total hash rate along side its own contribution.

[jpduhen]

I suspect I2C doesn't have the bandwidth for that. I was thinking of a scenario where you have maybe 10 super mini's all mining, and providing their hashing data to a CYD miner - to display the total hash rate along side its own contribution.

Ok, that's off then. If you use Public-pool.io your total hashrate is already on the display, or isn't that what you're interested in?

[holdupmaster]

Ah that had blanked out for me as I switched from public pool a while back when they kept having outages. I've gone back to it now and you're right it gives the total hash rate- thanks!!

[m8ax]

i fixed it , it was a mistake for me , im in the limit of size of firmware... i put many images and very screens news..

[m8ax]

i run yout versuion and i see the log

[evgenykzz2]

It is not final version. It is necessary to fix network connection issues

[m8ax]

where is to change the 2 decimals of hashrate... you cha ge this no ? where is ?

[m8ax]

:14:38.814 > M8AX - >>> Completados 31 Share(s), 63643 Khashes, Prom. Hashrate 198.3 KH/s 55°
20:14:38.870 > Sending : {"id": 38, "method": "mining.submit", "params": ["bcxxxxxxxxxxxxxxxxxxxxu7r8em.M8AX-NerdMinerV2-001-M8AX","9d660a","00000001","679d20f7","106e22cc"]}
20:14:38.872 > - Current diff share: 0.001012107773
20:14:38.872 > - Current pool diff : 0.001000000000
20:14:38.873 > - TX SHARE: 1f7ab01231c29e0f0b40d3f5c71702ed33b13ed9b813aefcc978a105dc030000
20:14:39.867 > M8AX - >>> Completados 32 Share(s), 63848 Khashes, Prom. Hashrate 194.5 KH/s 55°
20:14:39.875 > Receiving: {"id":38,"error":null,"result":true}
20:14:39.876 > Parsed JSON: Success
20:14:40.921 > M8AX - >>> Completados 32 Share(s), 64053 Khashes, Prom. Hashrate 194.5 KH/s 55°
20:14:41.973 > M8AX - >>> Completados 32 Share(s), 64262 Khashes, Prom. Hashrate 198.7 KH/s 55°
20:14:43.026 > M8AX - >>> Completados 32 Share(s), 64466 Khashes, Prom. Hashrate 193.7 KH/s 55°
20:14:44.080 > M8AX - >>> Completados 32 Share(s), 64675 Khashes, Prom. Hashrate 198.5 KH/s 55°
20:14:44.987 > Sending : {"id": 39, "method": "mining.submit", "params": ["bcxxxxxxxxxxxxxxxxxxxxxxxxxxzdzt0xc8t79jxxxxxxxxxm.M8AX-NerdMinerV2-001-M8AX","9d660a","00000001","679d20f7","10804ac7"]}
20:14:44.988 > - Current diff share: 0.001147313223
20:14:44.989 > - Current pool diff : 0.001000000000
20:14:44.989 > - TX SHARE: eb5052ec4b4eef34e3e5a30c7d31006e21c5a8550590db960882989667030000
20:14:45.133 > M8AX - >>> Completados 33 Share(s), 64880 Khashes, Prom. Hashrate 194.7 KH/s 55°
20:14:45.539 > Receiving: {"id":39,"error":null,"result":true}
20:14:45.539 > Parsed JSON: Success
20:14:46.186 > M8AX - >>> Completados 33 Share(s), 65073 Khashes, Prom. Hashrate 183.3 KH/s 55°
20:14:47.237 > M8AX - >>> Completados 33 Share(s), 65277 Khashes, Prom. Hashrate 193.9 KH/s 55°
20:14:48.290 > M8AX - >>> Completados 33 Share(s), 65486 Khashes, Prom. Hashrate 198.5 KH/s 55°
20:14:49.344 > M8AX - >>> Completados 33 Share(s), 65691 Khashes, Prom. Hashrate 194.7 KH/s 55°
20:14:50.396 > M8AX - >>> Completados 33 Share(s), 65900 Khashes, Prom. Hashrate 198.5 KH/s 55°

[m8ax]

Are you going to make more modifications to the mining speed, or do you think it's already finished?

[evgenykzz2]

Digits fix in monitor.cpp. hashrate is fine ~200Mh/s. I want to try dma for sha. Rp2350 dma hashrate is 280kh/s, so it is probably can be increased for esp32

[m8ax]

ok the files to change for hashrate all the same ever no ? i found the two decimals

[evgenykzz2]

Sorry, I can't understand your question.

[m8ax]

forget it... What's driving me crazy is why in the Bitmaker version, the 32-bit shares don't increase as quickly. Here, they go up much faster in a short amount of time, and I don't understand why. With the Bitmaker version, I could get 1 share in a night, but with yours, it increases a lot more.

[evgenykzz2]

I change nonce couter from zero, but I'm not sure I matters.
According to logs all hashes I fine, server accepts it.
I want to add each submission verification, and not count failed nonces.

[m8ax]

When do you think you will finish everything you want to do on the ESP32?

[m8ax]

what about implementation of dma? Have you made any more changes?

[m8ax]

at how many kh/s arrive now ? the same files to copy So, do you consider the improvement in hashrate to be finished?

[evgenykzz2]

Now it is 205kh/s in average on liligo esp32s3.
Also I've changed utils.cpp,h.
Added crc32 for settings. It was huge value on new board.

[evgenykzz2]

32bit shares count is much lower. I made another check.

[m8ax]

then all now its correct? i dont understand of crc32 , crc32 for what ?

[evgenykzz2]

Crc32 for NV settings validation. Sometimes settings become wrong.
I think it is correct now. Need someone to test more.

[m8ax]

sayme what you want to probe

[evgenykzz2]

It is necessary to test poor internet connection, disconnection, long test.
Also I think - buttons work bad.

[m8ax]

By the way, do you know which is the damn LED to make it blink on the ESP32-S3?
PLATFORM: Espressif 32 (6.6.0) > Espressif ESP32-S3-DevKitC-1-N8 (8 MB QD, No PSRAM)
HARDWARE: ESP32S3 240MHz, 320KB RAM, 8MB Flash
Because there’s no way it blinks.

[evgenykzz2]

Could you share a photo?
It could be uart

[m8ax]

a photho of the board? no im not in home now... but With the model, it should be enough... but those who tell me either reset the device or do nothing.

[evgenykzz2]

Nothing there. My tft works and shows valid digits

[m8ax]

for me with version without avg hashrate run ok the hasrate now sos nan... i dont know what make this

[m8ax]

all compiles ok... i dont undertand

[m8ax]

all data runs ok but currenthashrate shows nan

[evgenykzz2]

Could you compile my repo?

[m8ax]

your repo yes i cmpile ok... then chagen only one file and librarys of my project and only fails currenthasrate all the rest ok... and my tdisplaydriver.cpp yesterday runs okk since you change to avg hashrate run ok... yesterrday i probe your program and 200khs, now nan... and buttons to next screen respond slowly... can you see the monitor.cpp anything rare there ...

[m8ax]

I think everything is correct now, and everything is working fine. There’s no more room to enhance the ESP32-S3, right? I believe it's good as it is now

[evgenykzz2]

Could you provide some photos?
Does nerdminerv2 dev branch work?

[AlVirtu]

There is a backlight on the screen, but as soon as the config is loaded, it disappears.

[AlVirtu]

Nerdminers2 work -240Kh/s

[m8ax]

evgeny have you encounter solution for freeze or rebbots or s3?

[evgenykzz2]

Not yet. It needs lot of time.

[m8ax]

Today I had other things to do, I left the S3 working and it's still working, it hasn't restarted or anything and every 2 hours it also sends information to a telegram channel etc... and the firmware I'm doing has more things... it's been going on for 11 hours and it's going well

[m8ax]

in 11 hours in public pool why 282 kh/s ?

[AlVirtu]

The screen backlight on the ESP32-2432S028R does not work on your firmware because I2C is used. The ESP32-2432S028R backlight is connected to the ESP-WROOM-32 GPIO21, which is I2C SDA. The chip is ESP32-D0WD-V3.

[evgenykzz2]

Thanks, I will remove i2c code

[m8ax]

then the nerdminerv2 code has an error or not ?

[evgenykzz2]

It is hw sha256 but. I will fix it soon

[AlVirtu]

Without I2C, the screen backlight on the ESP32-2432S028R-2USB worked.

[BitMaker-hub]

Current ESP32D has less RAM memory to hold all the new stuff, so this supose loosing WIFI connection and other similar weird things with threads.
I'm sure there are some boards with ESP32D that will not support the upgrade.
So I suggest that @evgenykzz2, as the main part of this improvement creator make PR with this amazing news, when you feel comfortable with it.
I can test and check this on esp32-s3 devices and esp32D. I'll have time this week, sorry for not doing it before

[evgenykzz2]

Utils.c and mining.c

[m8ax]

do you beliee that you fixed the problem ?

[evgenykzz2]

I need few days for long test

[m8ax]

How is it going? Is he still alive?

[evgenykzz2]

3 days without any issues

[sany3001]

Can I help with testing? I have 3 different HW models running.

[m8ax]

any change?

[evgenykzz2]

No changes. I made long test, eps32d worked for 10days. I think we can merge now.
Looks like NMMiner already took my HardwareSHA code.

[m8ax]

What was the problem? Memory leak?

[m8ax]

Evgeby probé this firmware for nerdminerv2 https://m8ax.github.io/MvIiIaX-NerdMiner_V2-DeV/

[sany3001]

I am compiling and flashing from PlatformIO. 2 USB large display runs ok at about 350kH/s. But I do not know how to flash lilygo t-display S3. Using @evgenykzz2 branch.

[sany3001]

Testing Evgeny’s repo. Not the latest yet.

[m8ax]

Try this version of the NerdMiner V2 and let us know what you think... https://m8ax.github.io/MvIiIaX-NerdMiner_V2-DeV/

[andrewjswan]

Try this version of the NerdMiner V2 and let us know what you think...

Let's wait for official changes to the algorithm, in English.

[m8ax]

My version is already make. Try it to see what you think

[andrewjswan]

My version is already make. Try it to see what you think

It is not in English, it has many changes that are not related to the calculation algorithm, the pictures have been changed and all sorts of other things.
Unfortunately, it is not suitable for testing.

[m8ax]

for this version ESP32-2432S028R in globalhashscreen dont show global hassrate and network difficulty

[m8ax]

evgenykzz2 at the end what changed in src? for not reboot ?

[m8ax]

I update mining. Cpp mining.h uiilscpp and h and I one night reboot 2 times

[m8ax]

nmminer has 410kh/s

[x2chilleD4yAx]

Hi M8ax
I'm actually testing your Firmware. Runs since 18hours without any disconnect from public-pool. Interface also very nice. But some things to check. Hashrate goes from 350 to 150-200 after a few hours. Maybe temperature? And, what I would recommend, try to set the configuration page in english. If I was in the miner configuration network, my PC wasn't able to translate. And there is much text in spanish? , much people will not understand (also me). Connection to publicpool works fine, but if I want to use another pool, I don't know, where to write the password for example.........but this firmware seems to be on a good way, great job!!

[HenrysCat]

I would try evgenykzz2's code, but found only the bin files for t-display and devkit. ...actually in my own are s3 dongle and the 2432 with the 2.4display. ..... I installed arduinoio, but definitly not able to compile anything for myself. If there is a flasheble version for one of my devices, I will try instand.

You can try my webflasher with the original evgenykzz2 code if Platformio is not your piece of cookie.

Just tested this and it works well, Thanks

[x2chilleD4yAx]

I also tested, flashing works, but my display was dead....... But it's possible that in my case, also 'only micro usb' version is working. The other one says 'usb-c and usb mini' - my CYD Device has usb-c and micro (not mini) 🤣

[HenrysCat]

@jpduhen
Tried your webflasher. Could flash a 2432 (2xusb) with 'only micro'....when I choose the version with microAndC - it says could not download the firmware.

Should work now, typo in my config ...

@jpduhen your GitHub page does not seem to allow issues

[m8ax]

M8ax has stolen the code from evgenykzz2, THERE IS NO IMPROVEMENT IN THE code of m8ax, the only thing he has done is put his name everywhere, and put too much garbage in the code.

If you want stability and work with the original code with high hashrate try this https://github.com/evgenykzz2/NerdMiner_v2

Tidh when yo think to correct the stolen word? What you don't understand about open source

[m8ax]

I would try evgenykzz2's code, but found only the bin files for t-display and devkit. ...actually in my own are s3 dongle and the 2432 with the 2.4display. ..... I installed arduinoio, but definitly not able to compile anything for myself. If there is a flasheble version for one of my devices, I will try instand.

You can try my webflasher with the original evgenykzz2 code if Platformio is not your piece of cookie.

Explain to tidh666 that not stolen code... It's open source please..

[x2chilleD4yAx]

I got it to work, to create bin files with platformio from evgenyys repo. Flashed on CYD --> works, flashed on c3supermini --> works, flashed on s3 dongle --> doesn't work!! Nothing to see on dongle screen and no configuration wifi 🙄

[m8ax]

I got it to work, to create bin files with platformio from evgenyys repo. Flashed on CYD --> works, flashed on c3supermini --> works, flashed on s3 dongle --> doesn't work!! Nothing to see on dongle screen and no configuration wifi 🙄

The global stats not work well in evgeny down the speed and not See all the data in page bitcoin price too... This is best version, more útil more practical all run OK an you can configuraste a telegram channel So that the Miner sends you stats every 2 hours... https://m8ax.github.io/MvIiIaX-NerdMiner_V2-DeV/

[sniper19p]

Is there any way you could translate all of it to English?

[m8ax]

Is there any way you could translate all of it to English?

If you want to translate to English, you have all the source code in my github... For English there is already the original. I think algjien is translating it... But I'm not sure... I'm not going to translate anything at the moment, I wanted to do a Spanish version... If you want in English use the original firmware, which is more beautiful xd

[x2chilleD4yAx]

I have many (different) esp Boards _ so I try every version of course.
Actually could say: m8ax version runs on my CYD since 3 days without any restart or disconnect. Hashrate always ~350 for a few hours, then 200 for a few hours, and back to 350.
Evgennys version runs on CYD since 5 hours, also without any issues, and also 350, since now, without any slowdown. Evgennys version also runs on c3supermini (price is 1dollar) stable with over 150!!.
Only I don't get a s3 dongle to run, can somebody check this please?

[m8ax]

With evgeny go to screen global stats

[x2chilleD4yAx]

Soo, I will stop testing for today, it's time for bed in Germany.

Last Feedback for the Dev's for today
@evgenykzz2
First reboot on CYD Device after 5 hours,
No reboot on c3supermini
On Lilygo s3 dongle, screen stays black (miner works)

@m8ax
No reboot on CYD, but hashrate switches between 350 and 200 for a few hours 50/50.
On Lilygo s3 dongle, same as Evgenykzz, miner works, but screen shows nothing.

Thanks to all for help and your good work, see you tomorrow

[m8ax]

Any problem for me ever at 350 and 5 days on... Nothing to change

[m8ax]

The two I have, not problems... I have the save stats option unchecked...

The evgeny run worst if change screen... I have not case with slow down with my firm.. Only you and tested 10...any problem with you router

In evgeny if go to screen price btc slow if go to global stats not appear or appear later data....... My firmware From my point of view it is better..

[AlVirtu]

In evgeny if go to screen price btc slow if go to global stats not appear or appear later data....... My firmware From my point of view it is better..

Strange, I don't have that. Your firmware is no different from Evgeniy's firmware, just a different interface. I compared the main code - it's exactly the same as Evgeniy's. But your firmware is nice. Some people might like it more than BitMaker.

[x2chilleD4yAx]

And nobody can check this dongle???🙄

[m8ax]

In evgeny if go to screen price btc slow if go to global stats not appear or appear later data....... My firmware From my point of view it is better..

Strange, I don't have that. Your firmware is no different from Evgeniy's firmware, just a different interface. I compared the main code - it's exactly the same as Evgeniy's. But your firmware is nice. Some people might like it more than BitMaker.

All are the same bitmaker same too in my firmware there is a lot of changes in stratum in interface in functionality and so on. And not slow down I Some screens

[AlVirtu]

What's good about open source is that you can change into your own clothes and now it's something new, you don't even have to remember or thank the person who did it. That's the modern world.

[x2chilleD4yAx]

Lilygo S3-dongle.....can be configurated and starts to work, is shown in public pool but display is black/off or whatever....... Would say, it's a wrong part in the display settings in the firmware. It's also the same in evgenyys version !!!

[m8ax]

Yo ya no voy a renovar más firmwares no puedo publicar mi firmware de 1mh para el cyd 2.8 ni el de 800 para el nerdminerv2, me engañaron y la empresa no era quien decía ser

[HenrysCat]

I'm not going to renew any more firmwares, I can't publish my 1mh firmware for the cyd 2.8 or the 800 for the nerdminerv2, I was deceived and the company wasn't who it said it was

So your full o shit then?

[m8ax]

What do you say? Why you insult me? ...

[m8ax]

I'm not going to renew any more firmwares, I can't publish my 1mh firmware for the cyd 2.8 or the 800 for the nerdminerv2, I was deceived and the company wasn't who it said it was

So your full o shit then?

The firmware 800 kh for nerdminerv2 and 1mh for cyd buyme a company... I can't publish.. The latest firmware I can publish is in my web... If not like it don't install.. But don't insult people

[x2chilleD4yAx]

A question to the devs: isn't it possible, to take the actual nmminer code, and only delete the part for activating the device, or would that be a bigger thing?

[gtawelt]

I will publish a generator for activation

[x2chilleD4yAx]

Sounds good. 😎

[x2chilleD4yAx]

@gtawelt
Do you get something to work?

[gtawelt]

https://nm.broke-it.net/
@x2chilleD4yAx

[holdupmaster]

suspect that would also be copyright theft.

…

On Thu, May 1, 2025 at 10:58 AM x2chilleD4yAx ***@***.***> wrote: A question to the devs: isn't it possible, to take the actual nmminer code, and only delete the part for activating the device, or would that be a bigger thing? — Reply to this email directly, view it on GitHub <#572 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAS3ECOA3ZXJOIBXDAM4MHD24HV4TAVCNFSM6AAAAABV2XQGI6VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTGMBQGI3TGOI> . You are receiving this because you commented.Message ID: ***@***.*** com>