Updated to v0.8.1

ArbitronNL · ArbitronNL · commit 8107b6069b61 · 2025-05-15T14:26:23.000Z
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -21,13 +21,6 @@ jobs:
         with:
           go-version: 1.23
 
-      - name: Caching
-        uses: actions/cache@v4
-        with:
-          path: ~/go/pkg/mod
-          key: go-${{ hashFiles('**/go.sum') }}
-          restore-keys: go-
-
       - name: Dependencies
         run: go mod vendor
 
@@ -36,6 +29,8 @@ jobs:
 
       - name: Codestyle
         uses: golangci/golangci-lint-action@v8
+        with:
+          version: v2.1.6
 
       - name: Golang Vulncheck
         uses: Templum/govulncheck-action@v1.0.2
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -20,13 +20,6 @@ jobs:
         with:
           go-version: 1.23
 
-      - name: Caching
-        uses: actions/cache@v4
-        with:
-          path: ~/go/pkg/mod
-          key: go-${{ hashFiles('**/go.sum') }}
-          restore-keys: go-
-
       - name: Dependencies
         run: go mod vendor
 
diff --git a/internal/bip322/verify_test.go b/internal/bip322/verify_test.go
@@ -113,7 +113,7 @@ func (s *VerifyTestSuite) TestVerifyIncorrect() {
 
 			valid, err := bip322.Verify(address, tt.signedMessage.Message, signatureDecoded)
 			s.Require().EqualError(err, tt.expectedError)
-			s.False(valid)
+			s.Require().False(valid)
 		})
 	}
 }
@@ -183,7 +183,7 @@ func (s *VerifyTestSuite) TestVerify() {
 
 			valid, err := bip322.Verify(address, tt.Message, signatureDecoded)
 			s.Require().NoError(err)
-			s.True(valid)
+			s.Require().True(valid)
 		})
 	}
 }
diff --git a/internal/generic/flags/recovery_flags_test.go b/internal/generic/flags/recovery_flags_test.go
@@ -20,19 +20,19 @@ func TestRecoveryFlagTestSuite(t *testing.T) {
 }
 
 func (s *RecoveryFlagTestSuite) TestAll() {
-	s.Equal([]int{27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42}, flags.All())
+	s.Require().Equal([]int{27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42}, flags.All())
 }
 
 func (s *RecoveryFlagTestSuite) TestCompressed() {
-	s.Equal([]int{31, 32, 33, 34}, flags.Compressed())
+	s.Require().Equal([]int{31, 32, 33, 34}, flags.Compressed())
 }
 
 func (s *RecoveryFlagTestSuite) TestElectrumP2WPKH() {
-	s.Equal([]int{31, 32, 33, 34}, flags.ElectrumP2WPKH())
+	s.Require().Equal([]int{31, 32, 33, 34}, flags.ElectrumP2WPKH())
 }
 
 func (s *RecoveryFlagTestSuite) TestElectrumP2SHAndP2WPKH() {
-	s.Equal([]int{31, 32, 33, 34}, flags.ElectrumP2SHAndP2WPKH())
+	s.Require().Equal([]int{31, 32, 33, 34}, flags.ElectrumP2SHAndP2WPKH())
 }
 
 func (s *RecoveryFlagTestSuite) TestGetKeyID() {
@@ -50,10 +50,8 @@ func (s *RecoveryFlagTestSuite) TestGetKeyID() {
 	}
 
 	for _, tt := range tests {
-		s.T().Run(tt.name, func(t *testing.T) {
-			if got := flags.GetKeyID(tt.recoveryFlag); got != tt.expectedKeyID {
-				t.Errorf("GetKeyID() = %v, want %v", got, tt.expectedKeyID)
-			}
+		s.Run(tt.name, func() {
+			s.Require().Equal(tt.expectedKeyID, flags.GetKeyID(tt.recoveryFlag))
 		})
 	}
 }
@@ -70,26 +68,24 @@ func (s *RecoveryFlagTestSuite) TestShouldBeCompressed() {
 	}
 
 	for _, tt := range tests {
-		s.T().Run(tt.name, func(t *testing.T) {
-			if got := flags.ShouldBeCompressed(tt.recoveryFlag); got != tt.expected {
-				t.Errorf("ShouldBeCompressed() = %v, want %v", got, tt.expected)
-			}
+		s.Run(tt.name, func() {
+			s.Require().Equal(tt.expected, flags.ShouldBeCompressed(tt.recoveryFlag))
 		})
 	}
 }
 
 func (s *RecoveryFlagTestSuite) TestTrezor() {
-	s.Equal([]int{35, 36, 37, 38, 39, 40, 41, 42}, flags.Trezor())
+	s.Require().Equal([]int{35, 36, 37, 38, 39, 40, 41, 42}, flags.Trezor())
 }
 
 func (s *RecoveryFlagTestSuite) TestTrezorP2WPKH() {
-	s.Equal([]int{39, 40, 41, 42}, flags.TrezorP2WPKH())
+	s.Require().Equal([]int{39, 40, 41, 42}, flags.TrezorP2WPKH())
 }
 
 func (s *RecoveryFlagTestSuite) TestTrezorP2SHAndP2WPKH() {
-	s.Equal([]int{35, 36, 37, 38}, flags.TrezorP2SHAndP2WPKH())
+	s.Require().Equal([]int{35, 36, 37, 38}, flags.TrezorP2SHAndP2WPKH())
 }
 
 func (s *RecoveryFlagTestSuite) TestUncompressed() {
-	s.Equal([]int{27, 28, 29, 30}, flags.Uncompressed())
+	s.Require().Equal([]int{27, 28, 29, 30}, flags.Uncompressed())
 }
diff --git a/internal/generic/signature/signature_test.go b/internal/generic/signature/signature_test.go
@@ -47,7 +47,7 @@ func TestServiceTestSuite(t *testing.T) {
 func (s *SignatureTestSuite) TestParseCompactInvalid() {
 	compactedSignature, err := signature.ParseCompact([]byte{})
 	s.Require().EqualError(err, "invalid compact signature size")
-	s.Nil(compactedSignature)
+	s.Require().Nil(compactedSignature)
 }
 
 func (s *SignatureTestSuite) TestParseCompactInvalidRecoveryCode() {
@@ -63,7 +63,7 @@ func (s *SignatureTestSuite) TestParseCompactInvalidRecoveryCode() {
 		0xc9,
 	})
 	s.Require().EqualError(err, "invalid compact signature recovery code")
-	s.Nil(compactedSignature)
+	s.Require().Nil(compactedSignature)
 }
 
 func (s *SignatureTestSuite) TestParseCompact() {
@@ -75,8 +75,8 @@ func (s *SignatureTestSuite) TestParseCompact() {
 	S := s.getFieldFromSignature(compactedSignature, "s")
 
 	// Ensure they match what we defined
-	s.Equal("112454100686917088716763005039207074580155840372180209748670933598947425987108", R.String())
-	s.Equal("23603267825273168310009216611640910854054822424267934178492474518750065713966", S.String())
+	s.Require().Equal("112454100686917088716763005039207074580155840372180209748670933598947425987108", R.String())
+	s.Require().Equal("23603267825273168310009216611640910854054822424267934178492474518750065713966", S.String())
 }
 
 func (s *SignatureTestSuite) TestVerifyInvalidPublicKey() {
@@ -130,7 +130,7 @@ func (s *SignatureTestSuite) getFieldFromSignature(compactedSignature *ecdsa.Sig
 	// Grab the unexported field
 	rReflected := elem.FieldByName(field)
 	m, ok := reflect.NewAt(rReflected.Type(), unsafe.Pointer(rReflected.UnsafeAddr())).Elem().Interface().(btcec.ModNScalar)
-	s.True(ok)
+	s.Require().True(ok)
 
 	// Grab ModNScalar bytes
 	bytes := m.Bytes()
diff --git a/internal/generic/verify_test.go b/internal/generic/verify_test.go
@@ -115,7 +115,7 @@ func (s *VerifyTestSuite) TestVerifyIncorrect() {
 
 			valid, err := generic.Verify(address, tt.signedMessage.Message, signatureDecoded, &chaincfg.MainNetParams)
 			s.Require().EqualError(err, tt.expectedError)
-			s.False(valid)
+			s.Require().False(valid)
 		})
 	}
 }
@@ -305,7 +305,7 @@ func (s *VerifyTestSuite) TestVerify() {
 
 			valid, err := generic.Verify(address, tt.Message, signatureDecoded, &chaincfg.MainNetParams)
 			s.Require().NoError(err)
-			s.True(valid)
+			s.Require().True(valid)
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ func (s *VerifyTestSuite) TestVerifyIncorrect() {`
`113`	`113`
`114`	`114`	`valid, err := bip322.Verify(address, tt.signedMessage.Message, signatureDecoded)`
`115`	`115`	`s.Require().EqualError(err, tt.expectedError)`
`116`		`- s.False(valid)`
	`116`	`+ s.Require().False(valid)`
`117`	`117`	`})`
`118`	`118`	`}`
`119`	`119`	`}`
`@@ -183,7 +183,7 @@ func (s *VerifyTestSuite) TestVerify() {`
`183`	`183`
`184`	`184`	`valid, err := bip322.Verify(address, tt.Message, signatureDecoded)`
`185`	`185`	`s.Require().NoError(err)`
`186`		`- s.True(valid)`
	`186`	`+ s.Require().True(valid)`
`187`	`187`	`})`
`188`	`188`	`}`
`189`	`189`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,19 +20,19 @@ func TestRecoveryFlagTestSuite(t *testing.T) {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`func (s *RecoveryFlagTestSuite) TestAll() {`
`23`		`- s.Equal([]int{27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42}, flags.All())`
	`23`	`+ s.Require().Equal([]int{27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42}, flags.All())`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`func (s *RecoveryFlagTestSuite) TestCompressed() {`
`27`		`- s.Equal([]int{31, 32, 33, 34}, flags.Compressed())`
	`27`	`+ s.Require().Equal([]int{31, 32, 33, 34}, flags.Compressed())`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`func (s *RecoveryFlagTestSuite) TestElectrumP2WPKH() {`
`31`		`- s.Equal([]int{31, 32, 33, 34}, flags.ElectrumP2WPKH())`
	`31`	`+ s.Require().Equal([]int{31, 32, 33, 34}, flags.ElectrumP2WPKH())`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`func (s *RecoveryFlagTestSuite) TestElectrumP2SHAndP2WPKH() {`
`35`		`- s.Equal([]int{31, 32, 33, 34}, flags.ElectrumP2SHAndP2WPKH())`
	`35`	`+ s.Require().Equal([]int{31, 32, 33, 34}, flags.ElectrumP2SHAndP2WPKH())`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`func (s *RecoveryFlagTestSuite) TestGetKeyID() {`
`@@ -50,10 +50,8 @@ func (s *RecoveryFlagTestSuite) TestGetKeyID() {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`for _, tt := range tests {`
`53`		`- s.T().Run(tt.name, func(t *testing.T) {`
`54`		`- if got := flags.GetKeyID(tt.recoveryFlag); got != tt.expectedKeyID {`
`55`		`- t.Errorf("GetKeyID() = %v, want %v", got, tt.expectedKeyID)`
`56`		`- }`
	`53`	`+ s.Run(tt.name, func() {`
	`54`	`+ s.Require().Equal(tt.expectedKeyID, flags.GetKeyID(tt.recoveryFlag))`
`57`	`55`	`})`
`58`	`56`	`}`
`59`	`57`	`}`
`@@ -70,26 +68,24 @@ func (s *RecoveryFlagTestSuite) TestShouldBeCompressed() {`
`70`	`68`	`}`
`71`	`69`
`72`	`70`	`for _, tt := range tests {`
`73`		`- s.T().Run(tt.name, func(t *testing.T) {`
`74`		`- if got := flags.ShouldBeCompressed(tt.recoveryFlag); got != tt.expected {`
`75`		`- t.Errorf("ShouldBeCompressed() = %v, want %v", got, tt.expected)`
`76`		`- }`
	`71`	`+ s.Run(tt.name, func() {`
	`72`	`+ s.Require().Equal(tt.expected, flags.ShouldBeCompressed(tt.recoveryFlag))`
`77`	`73`	`})`
`78`	`74`	`}`
`79`	`75`	`}`
`80`	`76`
`81`	`77`	`func (s *RecoveryFlagTestSuite) TestTrezor() {`
`82`		`- s.Equal([]int{35, 36, 37, 38, 39, 40, 41, 42}, flags.Trezor())`
	`78`	`+ s.Require().Equal([]int{35, 36, 37, 38, 39, 40, 41, 42}, flags.Trezor())`
`83`	`79`	`}`
`84`	`80`
`85`	`81`	`func (s *RecoveryFlagTestSuite) TestTrezorP2WPKH() {`
`86`		`- s.Equal([]int{39, 40, 41, 42}, flags.TrezorP2WPKH())`
	`82`	`+ s.Require().Equal([]int{39, 40, 41, 42}, flags.TrezorP2WPKH())`
`87`	`83`	`}`
`88`	`84`
`89`	`85`	`func (s *RecoveryFlagTestSuite) TestTrezorP2SHAndP2WPKH() {`
`90`		`- s.Equal([]int{35, 36, 37, 38}, flags.TrezorP2SHAndP2WPKH())`
	`86`	`+ s.Require().Equal([]int{35, 36, 37, 38}, flags.TrezorP2SHAndP2WPKH())`
`91`	`87`	`}`
`92`	`88`
`93`	`89`	`func (s *RecoveryFlagTestSuite) TestUncompressed() {`
`94`		`- s.Equal([]int{27, 28, 29, 30}, flags.Uncompressed())`
	`90`	`+ s.Require().Equal([]int{27, 28, 29, 30}, flags.Uncompressed())`
`95`	`91`	`}`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ func (s *VerifyTestSuite) TestVerifyIncorrect() {`
`115`	`115`
`116`	`116`	`valid, err := generic.Verify(address, tt.signedMessage.Message, signatureDecoded, &chaincfg.MainNetParams)`
`117`	`117`	`s.Require().EqualError(err, tt.expectedError)`
`118`		`- s.False(valid)`
	`118`	`+ s.Require().False(valid)`
`119`	`119`	`})`
`120`	`120`	`}`
`121`	`121`	`}`
`@@ -305,7 +305,7 @@ func (s *VerifyTestSuite) TestVerify() {`
`305`	`305`
`306`	`306`	`valid, err := generic.Verify(address, tt.Message, signatureDecoded, &chaincfg.MainNetParams)`
`307`	`307`	`s.Require().NoError(err)`
`308`		`- s.True(valid)`
	`308`	`+ s.Require().True(valid)`
`309`	`309`	`})`
`310`	`310`	`}`
`311`	`311`	`}`