refactor: Move OTP verification check to a dedicated function and update usage in RegistrationService

Author: ujjwalkar0

accounts/services/registration_service.py

@@ -13,9 +13,9 @@
 MAX_OTP_ATTEMPTS = 5
 MAX_RESENDS = 3
 
-# Check if OTP verification is enabled (default: True)
-# Pass --otp-verification=False when running docker to disable
-OTP_VERIFICATION_ENABLED = os.environ.get('OTP_VERIFICATION_ENABLED', 'True').lower() in ('true', '1', 'yes')
+def is_otp_verification_enabled():
+    """Check if OTP verification is enabled at runtime (not at import time)"""
+    return os.environ.get('OTP_VERIFICATION_ENABLED', 'True').lower() in ('true', '1', 'yes')
 
 class RegistrationService:
     """
@@ -53,7 +53,8 @@ def register(username, email, raw_password, first_name="", last_name="", recaptc
         )
 
         # Send email (use Celery in prod)
-        send_otp_email(email, otp, username=username)
+        if is_otp_verification_enabled():
+            send_otp_email(email, otp, username=username)
         return pending
 
     @staticmethod
@@ -90,7 +91,7 @@ def verify_otp_and_create_user(email, otp):
             raise ValueError("No pending registration found")
 
         # Skip OTP verification if disabled via environment variable
-        if OTP_VERIFICATION_ENABLED:
+        if is_otp_verification_enabled():
             # expired
             if pending.is_expired(OTP_EXPIRY_MINUTES):
                 pending.delete()

docker-compose.yml

@@ -1,6 +1,8 @@
 services:
   web:
-    image: ujjwalkar/bizbuch-backend:latest
+    build: .
+    volumes:
+      - .:/app
     command: >
       sh -c "
       python manage.py migrate &&