refactor(ui): simplify ConfirmDialog dialogError prop

BjornMelin · BjornMelin · commit 91faeec2604d · 2026-02-10T12:23:19.000-07:00
diff --git a/src/app/(app)/projects/[projectId]/skills/skills-installed-tab.tsx b/src/app/(app)/projects/[projectId]/skills/skills-installed-tab.tsx
@@ -571,7 +571,7 @@ export function SkillsInstalledTab(
         confirmDisabled={isPending}
         confirmLabel="Delete"
         description="This action cannot be undone."
-        {...(confirmError ? { dialogError: confirmError } : {})}
+        dialogError={confirmError ?? undefined}
         onConfirm={confirmDelete}
         onOpenChange={(open) => {
           if (!open) {
diff --git a/src/components/ui/confirm-dialog.tsx b/src/components/ui/confirm-dialog.tsx
@@ -40,7 +40,7 @@ export type ConfirmDialogProps = Readonly<{
    * This is useful when an async {@link ConfirmDialogProps.onConfirm} fails and
    * the dialog should remain open while showing an actionable error to the user.
    */
-  dialogError?: string;
+  dialogError?: string | undefined;
   /**
    * Confirm button label.
    *

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ export type ConfirmDialogProps = Readonly<{`
`40`	`40`	`* This is useful when an async {@link ConfirmDialogProps.onConfirm} fails and`
`41`	`41`	`* the dialog should remain open while showing an actionable error to the user.`
`42`	`42`	`*/`
`43`		`- dialogError?: string;`
	`43`	`+ dialogError?: string \| undefined;`
`44`	`44`	`/**`
`45`	`45`	`* Confirm button label.`
`46`	`46`	`*`