Pinting The Project

Blair2004 · Blair2004 · commit 1a4e63a9cee1 · 2024-01-24T18:29:06.000Z
diff --git a/app/Crud/CustomerCouponHistoryCrud.php b/app/Crud/CustomerCouponHistoryCrud.php
@@ -166,7 +166,7 @@ public function getLabels(): array
     /**
      * Defines the forms used to create and update entries.
      */
-    public function getForm(?OrderCoupon $entry = null): array
+    public function getForm(OrderCoupon $entry = null): array
     {
         return [
             // ...
diff --git a/app/Crud/CustomerCrud.php b/app/Crud/CustomerCrud.php
@@ -179,7 +179,7 @@ public function hook($query): void
      * @param  object/null
      * @return  array of field
      */
-    public function getForm(?Customer $entry = null)
+    public function getForm(Customer $entry = null)
     {
         return [
             'main' => [
diff --git a/app/Fields/DirectTransactionFields.php b/app/Fields/DirectTransactionFields.php
@@ -12,7 +12,7 @@ class DirectTransactionFields extends FieldsService
 {
     protected static $identifier = Transaction::TYPE_DIRECT;
 
-    public function __construct(?Transaction $transaction = null)
+    public function __construct(Transaction $transaction = null)
     {
         $this->fields = Hook::filter('ns-direct-transactions-fields', [
             [
diff --git a/app/Fields/EntityTransactionFields.php b/app/Fields/EntityTransactionFields.php
@@ -13,7 +13,7 @@ class EntityTransactionFields extends FieldsService
 {
     protected static $identifier = Transaction::TYPE_ENTITY;
 
-    public function __construct(?Transaction $transaction = null)
+    public function __construct(Transaction $transaction = null)
     {
         $this->fields = Hook::filter('ns-direct-transactions-fields', [
             [
diff --git a/app/Fields/ProcurementFields.php b/app/Fields/ProcurementFields.php
@@ -9,7 +9,7 @@ class ProcurementFields extends FieldsService
 {
     protected static $identifier = 'ns.procurement-fields';
 
-    public function get(?Procurement $model = null)
+    public function get(Procurement $model = null)
     {
         $name = new \stdClass;
         $name->name = 'name';
diff --git a/app/Fields/ReccurringTransactionFields.php b/app/Fields/ReccurringTransactionFields.php
@@ -12,7 +12,7 @@ class ReccurringTransactionFields extends FieldsService
 {
     protected static $identifier = Transaction::TYPE_RECURRING;
 
-    public function __construct(?Transaction $transaction = null)
+    public function __construct(Transaction $transaction = null)
     {
         $this->fields = Hook::filter('ns-direct-transactions-fields', [
             [
diff --git a/app/Fields/ResetFields.php b/app/Fields/ResetFields.php
@@ -11,7 +11,7 @@ class ResetFields extends FieldsService
 {
     protected static $identifier = 'ns.reset';
 
-    public function get(?Unit $model = null)
+    public function get(Unit $model = null)
     {
         $this->fields = [
             [
diff --git a/app/Fields/ScheduledTransactionFields.php b/app/Fields/ScheduledTransactionFields.php
@@ -12,7 +12,7 @@ class ScheduledTransactionFields extends FieldsService
 {
     protected static $identifier = Transaction::TYPE_SCHEDULED;
 
-    public function __construct(?Transaction $transaction = null)
+    public function __construct(Transaction $transaction = null)
     {
         $this->fields = Hook::filter('ns-scheduled-transactions-fields', [
             [
diff --git a/app/Fields/UnitsFields.php b/app/Fields/UnitsFields.php
@@ -10,7 +10,7 @@ class UnitsFields extends FieldsService
 {
     protected static $identifier = 'ns.units-fields';
 
-    public function get(?Unit $model = null)
+    public function get(Unit $model = null)
     {
         $name = new \stdClass;
         $name->name = 'name';
diff --git a/app/Fields/UnitsGroupsFields.php b/app/Fields/UnitsGroupsFields.php
@@ -9,7 +9,7 @@ class UnitsGroupsFields extends FieldsService
 {
     protected static $identifier = 'ns.units-group-fields';
 
-    public function get(?UnitGroup $model = null)
+    public function get(UnitGroup $model = null)
     {
         $name = new \stdClass;
         $name->name = 'name';
diff --git a/app/Http/Controllers/Dashboard/OrdersController.php b/app/Http/Controllers/Dashboard/OrdersController.php
@@ -136,7 +136,7 @@ public function deleteOrderProduct($orderId, $productId)
         return $this->ordersService->deleteOrderProduct($order, $productId);
     }
 
-    public function getOrders(?Order $id = null)
+    public function getOrders(Order $id = null)
     {
         if ($id instanceof Order) {
             $id->load('customer');
diff --git a/app/Services/CoreService.php b/app/Services/CoreService.php
@@ -71,7 +71,7 @@ public function routeName(string $name): string
      * Returns a filtred URL to which
      * apply the filter "ns-url" hook.
      */
-    public function url(?string $url = null): string
+    public function url(string $url = null): string
     {
         return url(Hook::filter('ns-url', $url));
     }
diff --git a/app/Services/CrudService.php b/app/Services/CrudService.php
@@ -1092,7 +1092,7 @@ public function getTabsRelations(): array
         return $this->tabsRelations;
     }
 
-    public static function table(array $config = [], ?string $title = null, ?string $description = null, ?string $src = null, ?string $createUrl = null, ?array $queryParams = null): ContractView
+    public static function table(array $config = [], string $title = null, string $description = null, string $src = null, string $createUrl = null, array $queryParams = null): ContractView
     {
         $className = get_called_class();
         $instance = new $className;
diff --git a/app/Services/CurrencyService.php b/app/Services/CurrencyService.php
@@ -196,7 +196,7 @@ public function get()
     /**
      * return a raw value for the provided number
      */
-    public function getRaw(float|null|BigDecimal $value = null): float
+    public function getRaw(float|BigDecimal $value = null): float
     {
         if ($value === null) {
             return $this->value->dividedBy(1, $this->decimal_precision, RoundingMode::HALF_UP)->toFloat();
diff --git a/app/Services/CustomerService.php b/app/Services/CustomerService.php
@@ -653,7 +653,7 @@ public function updateCustomerOwedAmount(Customer $customer)
      * @param array $group
      * @return array $response
      */
-    public function createGroup($fields, ?CustomerGroup $group = null)
+    public function createGroup($fields, CustomerGroup $group = null)
     {
         if ($group === null) {
             $group = CustomerGroup::where('name', $fields[ 'name' ])->first();
diff --git a/app/Services/ModulesService.php b/app/Services/ModulesService.php
@@ -81,7 +81,7 @@ public static function loadModuleFile(string $namespace, string $file): mixed
      *
      * @param string path to load
      */
-    public function load(?string $dir = null): void
+    public function load(string $dir = null): void
     {
         /**
          * If we're not loading a specific module directory
@@ -331,7 +331,7 @@ public function triggerServiceProviders(array $config, string $method, string|bo
      * Will check for a specific module or all the module
      * enabled if there is a dependency error.
      */
-    public function dependenciesCheck(?array $module = null): void
+    public function dependenciesCheck(array $module = null): void
     {
         if ($module === null) {
             collect($this->getEnabled())->each(function ($module) {
diff --git a/app/Services/NotificationService.php b/app/Services/NotificationService.php
@@ -33,7 +33,7 @@ class NotificationService
     /**
      * @param array $config [ 'title', 'url', 'identifier', 'source', 'dismissable', 'description' ]
      */
-    public function create(string|array $title, string $description = '', string $url = '#', ?string $identifier = null, string $source = 'system', bool $dismissable = true)
+    public function create(string|array $title, string $description = '', string $url = '#', string $identifier = null, string $source = 'system', bool $dismissable = true)
     {
         if (is_array($title)) {
             extract($title);
diff --git a/app/Services/Options.php b/app/Services/Options.php
@@ -190,7 +190,7 @@ public function beforeSave(Option $option)
     /**
      * Get options
      **/
-    public function get(?string $key = null, mixed $default = null)
+    public function get(string $key = null, mixed $default = null)
     {
         if ($key === null) {
             return $this->rawOptions;
diff --git a/app/Services/OrdersService.php b/app/Services/OrdersService.php
@@ -84,7 +84,7 @@ public function __construct(
      * @param Order|null $order (optional)
      * @return array
      */
-    public function create($fields, ?Order $order = null)
+    public function create($fields, Order $order = null)
     {
         $isNew = ! $order instanceof Order;
         $customer = $this->__customerIsDefined($fields);
@@ -1223,7 +1223,7 @@ private function __buildOrderProducts($products)
     /**
      * @return SupportCollection $items
      */
-    private function __checkProductStock(SupportCollection $items, ?Order $order = null)
+    private function __checkProductStock(SupportCollection $items, Order $order = null)
     {
         $session_identifier = Str::random('10');
 
@@ -1303,7 +1303,7 @@ private function __checkProductStock(SupportCollection $items, ?Order $order = n
      * @param array Order Product
      * @return array Order Product (updated)
      */
-    public function __buildOrderProduct(array $orderProduct, ?ProductUnitQuantity $productUnitQuantity = null, ?Product $product = null)
+    public function __buildOrderProduct(array $orderProduct, ProductUnitQuantity $productUnitQuantity = null, Product $product = null)
     {
         /**
          * This will calculate the product default field
@@ -1394,7 +1394,7 @@ public function checkQuantityAvailability($product, $productUnitQuantity, $order
         }
     }
 
-    public function computeProduct($fields, ?Product $product = null, ?ProductUnitQuantity $productUnitQuantity = null)
+    public function computeProduct($fields, Product $product = null, ProductUnitQuantity $productUnitQuantity = null)
     {
         $sale_price = ($fields[ 'unit_price' ] ?? $productUnitQuantity->sale_price);
 
diff --git a/app/Services/ProductCategoryService.php b/app/Services/ProductCategoryService.php
@@ -45,7 +45,7 @@ public function getUsingName($name)
      * @param array details
      * @return array
      */
-    public function create($data, ?ProductCategory $productCategory = null)
+    public function create($data, ProductCategory $productCategory = null)
     {
         $category = $productCategory === null ? new ProductCategory : $productCategory;
         $category->author = Auth::id();
diff --git a/app/Services/ProductService.php b/app/Services/ProductService.php
@@ -1194,7 +1194,7 @@ private function handleStockAdjustmentsForGroupedProducts(
         $orderProductQuantity,
         Product $product,
         Unit $parentUnit,
-        ?OrderProduct $orderProduct = null): EloquentCollection
+        OrderProduct $orderProduct = null): EloquentCollection
     {
         $product->load('sub_items');
 
@@ -1391,7 +1391,7 @@ private function handleStockAdjustmentRegularProducts($action, $quantity, $produ
                 unit_id: $unit_id
             );
 
-            if ( $currentQuantity < $quantity ) {
+            if ($currentQuantity < $quantity) {
                 $action = ProductHistory::ACTION_ADDED;
                 $adjustQuantity = $quantity - $currentQuantity;
 
@@ -1401,7 +1401,7 @@ private function handleStockAdjustmentRegularProducts($action, $quantity, $produ
                     quantity: $adjustQuantity,
                     oldQuantity: $currentQuantity
                 );
-            } elseif ( $currentQuantity > $quantity ) {
+            } elseif ($currentQuantity > $quantity) {
                 $action = ProductHistory::ACTION_REMOVED;
                 $adjustQuantity = $currentQuantity - $quantity;
 
@@ -1695,7 +1695,7 @@ public function deleteAllProducts()
      * Will return the last purchase price
      * defined for the provided product
      */
-    public function getLastPurchasePrice(?Product $product, Unit $unit, ?string $before = null): float|int
+    public function getLastPurchasePrice(?Product $product, Unit $unit, string $before = null): float|int
     {
         if ($product instanceof Product) {
             $request = ProcurementProduct::where('product_id', $product->id)
@@ -1861,7 +1861,7 @@ public function generateProductBarcode(Product $product)
      * Convert quantity from a source unit ($from) to a destination unit ($to)
      * using the provided quantity and product.
      */
-    public function convertUnitQuantities(Product $product, Unit $from, float $quantity, Unit $to, ?ProcurementProduct $procurementProduct = null): array
+    public function convertUnitQuantities(Product $product, Unit $from, float $quantity, Unit $to, ProcurementProduct $procurementProduct = null): array
     {
         if ($product->stock_management !== Product::STOCK_MANAGEMENT_ENABLED) {
             throw new NotAllowedException(__('You cannot convert unit on a product having stock management disabled.'));
diff --git a/app/Services/TaxService.php b/app/Services/TaxService.php
@@ -313,7 +313,7 @@ public function getTaxesComputed(string $tax_type, array $rates, float $value):
      * compute the tax added to a
      * product using a defined tax group id and type.
      */
-    public function computeTax(ProductUnitQuantity $unitQuantity, ?int $tax_group_id, ?string $tax_type = null): void
+    public function computeTax(ProductUnitQuantity $unitQuantity, ?int $tax_group_id, string $tax_type = null): void
     {
         $taxGroup = TaxGroup::find($tax_group_id);
 
diff --git a/app/Services/TransactionService.php b/app/Services/TransactionService.php
@@ -97,7 +97,7 @@ public function edit($id, $fields)
      *
      * @throws NotFoundException
      */
-    public function get(?int $id = null): Collection|Transaction
+    public function get(int $id = null): Collection|Transaction
     {
         if ($id === null) {
             return Transaction::get();
@@ -134,7 +134,7 @@ public function delete($id)
      * Retreive a specific account type
      * or all account type
      */
-    public function getTransactionAccountByID(?int $id = null)
+    public function getTransactionAccountByID(int $id = null)
     {
         if ($id !== null) {
             $account = TransactionAccount::find($id);
@@ -355,7 +355,7 @@ public function recordTransactionHistory($transaction)
      *
      * @return array of process results.
      */
-    public function handleRecurringTransactions(?Carbon $date = null)
+    public function handleRecurringTransactions(Carbon $date = null)
     {
         if ($date === null) {
             $date = $this->dateService->copy();
diff --git a/app/Services/UsersService.php b/app/Services/UsersService.php
@@ -271,7 +271,7 @@ public function createAttribute(User $user): void
      * Stores the widgets details
      * on the provided area
      */
-    public function storeWidgetsOnAreas(array $config, ?User $user = null): array
+    public function storeWidgetsOnAreas(array $config, User $user = null): array
     {
         $userId = $user !== null ? $user->id : Auth::user()->id;
 
@@ -314,7 +314,7 @@ public function storeWidgetsOnAreas(array $config, ?User $user = null): array
      * Will generate a token for either the
      * logged user or for the provided user
      */
-    public function createToken($name, ?User $user = null): array
+    public function createToken($name, User $user = null): array
     {
         if ($user === null) {
             /**
@@ -336,7 +336,7 @@ public function createToken($name, ?User $user = null): array
      * Returns all generated token
      * using the provided user or the logged one.
      */
-    public function getTokens(?User $user = null): EloquentCollection
+    public function getTokens(User $user = null): EloquentCollection
     {
         if ($user === null) {
             /**
@@ -348,7 +348,7 @@ public function getTokens(?User $user = null): EloquentCollection
         return $user->tokens()->orderBy('created_at', 'desc')->get();
     }
 
-    public function deleteToken($tokenId, ?User $user = null)
+    public function deleteToken($tokenId, User $user = null)
     {
         if ($user === null) {
             /**
diff --git a/app/Services/WidgetService.php b/app/Services/WidgetService.php
@@ -88,7 +88,7 @@ public function getName(): string
      * Return a boolean if the logged user
      * is allowed to see the current widget
      */
-    public function canAccess(?User $user = null): bool
+    public function canAccess(User $user = null): bool
     {
         return ! $this->permission ?: ($user == null ? Gate::allows($this->permission) : Gate::forUser($user)->allows($this->permission));
     }
diff --git a/tests/Feature/CreateOrderPaidWithCustomerCredit.php b/tests/Feature/CreateOrderPaidWithCustomerCredit.php
@@ -92,7 +92,7 @@ public function test_make_order_on_credit()
         $this->defaultProcessing = false;
     }
 
-    public function processOrders(array $orderDetails, ?callable $callback = null)
+    public function processOrders(array $orderDetails, callable $callback = null)
     {
         $responses = [];
         /**
diff --git a/tests/Feature/TestLanguageFileValidity.php b/tests/Feature/TestLanguageFileValidity.php
@@ -31,7 +31,7 @@ private function checkValidity($content)
         if (! empty($content)) {
             @json_decode($content);
 
-            return  json_last_error() === JSON_ERROR_NONE;
+            return json_last_error() === JSON_ERROR_NONE;
         }
 
         return false;
diff --git a/tests/Traits/WithTaxTest.php b/tests/Traits/WithTaxTest.php
@@ -163,7 +163,7 @@ protected function attemptVariableVat()
         $this->assertCheck($details);
     }
 
-    private function assertCheck($details, ?callable $callback = null)
+    private function assertCheck($details, callable $callback = null)
     {
         /**
          * @var TaxService

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ public function getLabels(): array`
`166`	`166`	`/**`
`167`	`167`	`* Defines the forms used to create and update entries.`
`168`	`168`	`*/`
`169`		`- public function getForm(?OrderCoupon $entry = null): array`
	`169`	`+ public function getForm(OrderCoupon $entry = null): array`
`170`	`170`	`{`
`171`	`171`	`return [`
`172`	`172`	`// ...`
Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ public function hook($query): void`
`179`	`179`	`* @param object/null`
`180`	`180`	`* @return array of field`
`181`	`181`	`*/`
`182`		`- public function getForm(?Customer $entry = null)`
	`182`	`+ public function getForm(Customer $entry = null)`
`183`	`183`	`{`
`184`	`184`	`return [`
`185`	`185`	`'main' => [`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ class DirectTransactionFields extends FieldsService`
`12`	`12`	`{`
`13`	`13`	`protected static $identifier = Transaction::TYPE_DIRECT;`
`14`	`14`
`15`		`- public function __construct(?Transaction $transaction = null)`
	`15`	`+ public function __construct(Transaction $transaction = null)`
`16`	`16`	`{`
`17`	`17`	`$this->fields = Hook::filter('ns-direct-transactions-fields', [`
`18`	`18`	`[`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ class EntityTransactionFields extends FieldsService`
`13`	`13`	`{`
`14`	`14`	`protected static $identifier = Transaction::TYPE_ENTITY;`
`15`	`15`
`16`		`- public function __construct(?Transaction $transaction = null)`
	`16`	`+ public function __construct(Transaction $transaction = null)`
`17`	`17`	`{`
`18`	`18`	`$this->fields = Hook::filter('ns-direct-transactions-fields', [`
`19`	`19`	`[`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ class ProcurementFields extends FieldsService`
`9`	`9`	`{`
`10`	`10`	`protected static $identifier = 'ns.procurement-fields';`
`11`	`11`
`12`		`- public function get(?Procurement $model = null)`
	`12`	`+ public function get(Procurement $model = null)`
`13`	`13`	`{`
`14`	`14`	`$name = new \stdClass;`
`15`	`15`	`$name->name = 'name';`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ class ReccurringTransactionFields extends FieldsService`
`12`	`12`	`{`
`13`	`13`	`protected static $identifier = Transaction::TYPE_RECURRING;`
`14`	`14`
`15`		`- public function __construct(?Transaction $transaction = null)`
	`15`	`+ public function __construct(Transaction $transaction = null)`
`16`	`16`	`{`
`17`	`17`	`$this->fields = Hook::filter('ns-direct-transactions-fields', [`
`18`	`18`	`[`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ class ResetFields extends FieldsService`
`11`	`11`	`{`
`12`	`12`	`protected static $identifier = 'ns.reset';`
`13`	`13`
`14`		`- public function get(?Unit $model = null)`
	`14`	`+ public function get(Unit $model = null)`
`15`	`15`	`{`
`16`	`16`	`$this->fields = [`
`17`	`17`	`[`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ class ScheduledTransactionFields extends FieldsService`
`12`	`12`	`{`
`13`	`13`	`protected static $identifier = Transaction::TYPE_SCHEDULED;`
`14`	`14`
`15`		`- public function __construct(?Transaction $transaction = null)`
	`15`	`+ public function __construct(Transaction $transaction = null)`
`16`	`16`	`{`
`17`	`17`	`$this->fields = Hook::filter('ns-scheduled-transactions-fields', [`
`18`	`18`	`[`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ class UnitsFields extends FieldsService`
`10`	`10`	`{`
`11`	`11`	`protected static $identifier = 'ns.units-fields';`
`12`	`12`
`13`		`- public function get(?Unit $model = null)`
	`13`	`+ public function get(Unit $model = null)`
`14`	`14`	`{`
`15`	`15`	`$name = new \stdClass;`
`16`	`16`	`$name->name = 'name';`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ class UnitsGroupsFields extends FieldsService`
`9`	`9`	`{`
`10`	`10`	`protected static $identifier = 'ns.units-group-fields';`
`11`	`11`
`12`		`- public function get(?UnitGroup $model = null)`
	`12`	`+ public function get(UnitGroup $model = null)`
`13`	`13`	`{`
`14`	`14`	`$name = new \stdClass;`
`15`	`15`	`$name->name = 'name';`