NexoPOS 6.0.5

[Blair2004]

This minor update fixes issues reported by @ayoub-hs. We've also changed the way NexoPOS was tested through CI/CD. Here is a full breakdown.

Changelog:

• Fix: Unhandled accounting misconfiguration [Issue] error when paying holded ticket #2430
• Fix: unit test with missing module directory
• Fix: no validation error for invalid on the quick products [Issue] create product button not responding , in pos screen #2429
• Fixed: Component Visual Sizes
• Updating instructions

---

This discussion was created from the release NexoPOS 6.0.5.

[ayoub-hs]

did you test the create product issue ?
its not fixed when i tested

[Blair2004]

The issue you have is because the unit is not selected make sure to select it. We’ll review this

…

On Thu, 11 Sep 2025 at 12:20 ayoub-hs ***@***.***> wrote: did you test the create product issue ? its not fixed when i tested — Reply to this email directly, view it on GitHub <#2434 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIFR76BRBPJUNEGFRKICMT3SFLHFAVCNFSM6AAAAACGEVNR32VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTIMZXGMYTQMA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ayoub-hs]

[ayoub-hs]

when i click on create i get this error in console
TypeError: Unexpected type of argument in function subtractScalar (expected: number or bigint or string or boolean or BigNumber or Complex or Fraction, actual: identifier | undefined, index: 1)
at s.R [as createError] (bootstrap-636aee05.js:97:6056)
at s.onMismatch (bootstrap-636aee05.js:97:44837)
at subtract.Do (bootstrap-636aee05.js:97:13569)
at subtract.subtractScalar (bootstrap-636aee05.js:97:14004)
at i. (bootstrap-636aee05.js:147:1326)
at K.proceedProductTaxComputation (pos-init-03b5de4e.js:1:57587)
at K.computeCustomProductTax (pos-init-03b5de4e.js:1:57940)
at K.computeProductTax (pos-init-03b5de4e.js:1:57204)
at Proxy.addProduct (ns-pos-cart-0ea38112.js:1:18024)

[ayoub-hs]

fixed with chatgpt .
here’s a drop-in, fully fixed addProduct() you can paste into ns-pos-quick-product-popup.vue.
It includes: the filter bug fix, numeric normalization, safe lookups, and a try/catch with a helpful error.

async addProduct() {
  try {
    console.log('[quick-product-popup] Create clicked');

    // 1) Extract current values from the configured fields
    const extractedAll = this.validation.extractFields(this.fields);

    // 2) Keep ONLY visible fields:
    //    - no "show" rule  => always visible
    //    - has "show" and it returns true for current form => visible
    const visibleFields = this.fields.filter(field => {
      return !field.show || (typeof field.show === 'function' && field.show(extractedAll));
    });

    // 3) Validate only the visible fields
    const valid = this.validation.validateFields(visibleFields);
    if (!valid) {
      return nsSnackBar.error(__('Unable to proceed. The form is not valid.'));
    }

    // 4) Build the product object from the visible fields
    let product = this.validation.extractFields(visibleFields);

    // --- Helpers & guards ----------------------------------------------------
    const toNum = (v, def = 0) => {
      const n = Number(v);
      return Number.isFinite(n) ? n : def;
    };

    // Normalize fundamental values to avoid math.js errors (undefined/NaN)
    product.product_type = product.product_type || 'product'; // 'product' or 'service'
    product.unit_price   = toNum(product.unit_price, 0);
    product.quantity     = toNum(product.quantity, 1);
    product.discount     = toNum(product.discount, 0);
    product.discount_type = product.discount_type || 'amount'; // or 'percent' per your app
    product.tax_type     = product.tax_type || 'exclusive';

    // Safe tax group (computeProductTax may read from $original().tax_group.rate)
    let tg = (this.tax_groups || []).find(
      g => String(g.id) === String(product.tax_group_id)
    );
    if (!tg) tg = { id: 0, name: 'No Tax', rate: 0 };

    // $original is used by POS helpers; give it a safe, stable shape
    product.$original = () => ({
      stock_management: 'disabled',
      category_id: 0,
      tax_group: tg,
      tax_group_id: tg.id,
      tax_type: product.tax_type
    });

    // For "product" type, resolve unit info; for "service", keep defaults
    if (product.product_type === 'product') {
      const unit = (this.units || []).find(
        u => String(u.id) === String(product.unit_id)
      );
      product.unit_name = unit ? unit.name : __('N/A');

      // initialize price fields as numbers so later math ops are safe
      product.mode              = 'custom';
      product.price_with_tax    = toNum(product.price_with_tax, product.unit_price);
      product.price_without_tax = toNum(product.price_without_tax, product.unit_price);
      product.tax_value         = toNum(product.tax_value, 0);
    } else {
      product.unit_name         = __('N/A');
      product.quantity          = toNum(product.quantity, 1);
      product.unit_price        = toNum(product.unit_price, 0);
      product.price_with_tax    = toNum(product.price_with_tax, product.unit_price);
      product.price_without_tax = toNum(product.price_without_tax, product.unit_price);
      product.tax_value         = toNum(product.tax_value, 0);
    }

    // 5) Define quantities (awaited) and attach a getter the POS code expects
    const quantities = await POS.defineQuantities(product, this.units || []);
    product.$quantities = () => quantities;

    // 6) Final numeric coercions right before tax compute (belt & suspenders)
    product.unit_price        = toNum(product.unit_price, 0);
    product.quantity          = toNum(product.quantity, 1);
    product.discount          = toNum(product.discount, 0);
    product.price_with_tax    = toNum(product.price_with_tax, product.unit_price);
    product.price_without_tax = toNum(product.price_without_tax, product.unit_price);
    product.tax_value         = toNum(product.tax_value, 0);
    // ensure $original().tax_group.rate is numeric
    const og = product.$original();
    if (!og.tax_group) og.tax_group = tg;
    og.tax_group.rate = toNum(og.tax_group.rate, 0);

    // 7) Compute tax and push to cart
    product = POS.computeProductTax(product);
    POS.addToCart(product);

    // 8) Close the popup
    this.close();
  } catch (err) {
    console.error('[quick-product-popup] Create failed:', err);
    nsSnackBar.error(__('Something went wrong while creating the product.'));
  }
},

Why this version won’t break

• Filter bug fixed: we properly respect show() when deciding which fields to validate/extract.
• No undefined math: any number the pricing/tax code touches is coerced to a finite number.
• Safe tax group & unit: lookups are guarded; missing data defaults to neutral values.
• Error handling: any unexpected issue shows a snackbar and logs details to the console.

Paste this over your existing addProduct() and retest. If anything still throws, the console log will show exactly which part to inspect next.