fix: validation update fields

Author: unrealtim-tech

rust_session/student_registry/src/main.rs

@@ -9,6 +9,13 @@ use registry::Registry;
 use student_struct::Student;
 
 fn main() {
+    fn print_separator() {
+        println!("                                                          ");
+        println!("==========================================================");
+        println!("==========================================================");
+        println!("                                                          ");
+    }
+
     let sex = Sex::Male;
     println!("sex: {:?}", sex.to_str());
 
@@ -30,13 +37,20 @@ fn main() {
     registry.add("Mark", 20, Sex::Male, Grade::First, 72.0);
     registry.add("Janet", 20, Sex::Female, Grade::First, 82.0);
     let custom_id = registry.students[2].id;
+    print_separator();
     registry.list_all();
     let updated_student: Student =
-        Student::new(3, "Fin".to_string(), 18, Sex::Female, Grade::Third, 40.5);
-    registry.update_by_index(2, updated_student);
+        Student::new(3, "Fin".to_string(), 17, Sex::Female, Grade::First, 12.0);
+    print_separator();
+    registry.update(3, updated_student);
+    print_separator();
     registry.list_all();
+    print_separator();
     registry.delete(3);
+    print_separator();
+    registry.list_all();
     registry.delete(custom_id);
+    print_separator();
     registry.list_all();
 }
 
@@ -69,7 +83,6 @@ fn main() {
 //     registry.list_all();
 //     let updated_student: Student =
 //         Student::new("Fin".to_string(), 18, Sex::Female, Grade::Third, 40.5);
-//     registry.update_by_index(2, updated_student);
 //     registry.list_all();
 //     registry.delete(custom_id);
 // }

rust_session/student_registry/src/registry.rs

@@ -53,20 +53,26 @@ impl Registry {
     }
 
     pub fn update(&mut self, id: u32, student: Student) {
-        match self.students.iter_mut().find(|s| s.id == id) {
-            Some(s30) => {
-                *s = student;
-            }
-            None => println!("Student with ID {} not found", id),
+        let Some(s) = self.students.iter().find(|s| s.id == id) else {
+            println!("Student with ID {} not found", id);
+            return;
+        };
+
+        if student.name == s.name
+            && student.age == s.age
+            && student.grade == s.grade
+            && student.score == s.score
+        {
+            println!("No updates found, cannot make update.");
+            return;
         }
-    }
 
-    pub fn update_by_index(&mut self, index: usize, student: Student) {
-        match self.students.get_mut(index) {
+        match self.students.iter_mut().find(|s| s.id == id) {
             Some(s) => {
                 *s = student;
+                println!("Student with ID {} updated", id);
             }
-            None => println!("Student at index {} not found", index),
+            None => println!("Student with ID {} not found", id),
         }
     }
 

rust_session/student_registry/src/registry_uuid.rs

@@ -54,20 +54,25 @@ impl Registry {
     }
 
     pub fn update(&mut self, id: Uuid, student: Student) {
-        match self.students.iter_mut().find(|s| s.id == id) {
-            Some(s) => {
-                *s = student;
-            }
-            None => println!("Student with ID {} not found", id),
+        let Some(s) = self.students.iter().find(|s| s.id == id) else {
+            println!("Student with ID {} not found", id);
+            return;
+        };
+
+        if student.name == s.name
+            || student.age == s.age
+            || student.grade == s.grade
+            || student.score == s.score
+        {
+            println!("No updates found, cannot make update.");
+            return;
         }
-    }
 
-    pub fn update_by_index(&mut self, index: usize, student: Student) {
-        match self.students.get_mut(index) {
+        match self.students.iter_mut().find(|s| s.id == id) {
             Some(s) => {
                 *s = student;
             }
-            None => println!("Student at index {} not found", index),
+            None => println!("Student with ID {} not found", id),
         }
     }