Skip to content

Commit bdb9cbc

Browse files
committed
Remove/hide Jump to Message feature
1 parent 546172e commit bdb9cbc

File tree

2 files changed

+6
-59
lines changed

2 files changed

+6
-59
lines changed

lib/app/layouts/conversation_attachments/widgets/attachment_popup.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -619,10 +619,10 @@ class _AttachmentPopupState extends OptimizedState<AttachmentPopup> with SingleT
619619
onTap: share,
620620
action: DetailsMenuAction.Share,
621621
),
622-
DetailsMenuActionWidget(
623-
onTap: jumpToMessage,
624-
action: DetailsMenuAction.JumpToMessage,
625-
),
622+
// DetailsMenuActionWidget(
623+
// onTap: jumpToMessage,
624+
// action: DetailsMenuAction.JumpToMessage,
625+
// ),
626626
if (showDownload)
627627
DetailsMenuActionWidget(
628628
onTap: redownload,

lib/app/layouts/fullscreen_media/fullscreen_holder.dart

Lines changed: 2 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
import 'package:bluebubbles/app/components/avatars/contact_avatar_widget.dart';
21
import 'package:bluebubbles/app/components/circle_progress_bar.dart';
3-
import 'package:bluebubbles/app/layouts/conversation_view/pages/conversation_view.dart';
42
import 'package:bluebubbles/app/wrappers/stateful_boilerplate.dart';
53
import 'package:bluebubbles/utils/logger/logger.dart';
64
import 'package:bluebubbles/helpers/helpers.dart';
@@ -93,7 +91,7 @@ class FullscreenMediaHolderState extends OptimizedState<FullscreenMediaHolder> {
9391
child: Scaffold(
9492
appBar: !iOS || !showAppBar
9593
// AppBar placeholder to prevent shifting of content when toggling the app bar
96-
? PreferredSize(preferredSize: Size.fromHeight(attachment.message.target == null ? 56 : 88), child: Container())
94+
? PreferredSize(preferredSize: const Size.fromHeight(56), child: Container())
9795
: AppBar(
9896
leading: XGestureDetector(
9997
supportTouch: true,
@@ -122,57 +120,6 @@ class FullscreenMediaHolderState extends OptimizedState<FullscreenMediaHolder> {
122120
centerTitle: iOS,
123121
iconTheme: IconThemeData(color: context.theme.colorScheme.primary),
124122
backgroundColor: context.theme.colorScheme.properSurface,
125-
bottom: (attachment.message.target == null) ? null : PreferredSize(
126-
preferredSize: const Size.fromHeight(32),
127-
child: Column(
128-
children : [
129-
RawChip(
130-
tapEnabled: true,
131-
side: BorderSide(color: context.theme.colorScheme.outline.withOpacity(0.1)),
132-
shape: RoundedRectangleBorder(borderRadius: BorderRadius.circular(20)),
133-
avatar: (attachment.message.target?.isFromMe == true) ?
134-
ContactAvatarWidget(contact: Contact(id : 'you', displayName : ss.settings.userName.value, emails : [ss.settings.iCloudAccount.value])) :
135-
ContactAvatarWidget(handle: attachment.message.target?.handle ?? attachment.message.target?.getHandle()),
136-
label: Wrap(
137-
spacing : 4,
138-
crossAxisAlignment: WrapCrossAlignment.center,
139-
children: [
140-
Text('From ${attachment.message.target?.isFromMe == true ? 'You' : attachment.message.target?.handle?.displayName}',
141-
style: TextStyle(
142-
fontSize: 14,
143-
fontWeight: FontWeight.normal,
144-
color: context.theme.colorScheme.onSurface
145-
)
146-
),
147-
Icon(
148-
iOS ? CupertinoIcons.chevron_right : Icons.chevron_right,
149-
color: context.theme.colorScheme.onSurface.withOpacity(0.6),
150-
size: 14,
151-
),
152-
],
153-
),
154-
onSelected: (selected) {
155-
if (attachment.message.target?.chat.target != null) {
156-
final attachmentChat = attachment.message.target!.chat.target!;
157-
final service = ms(attachmentChat.guid);
158-
service.method = "network";
159-
service.struct.addMessages([attachment.message.target!]);
160-
ns.pushAndRemoveUntil(
161-
context,
162-
ConversationView(
163-
chat: attachmentChat,
164-
customService: service,
165-
),
166-
(route) => route.isFirst,
167-
);
168-
} else {
169-
// Gracefully show a "Failed to jump to message" pill notification
170-
}
171-
},
172-
)
173-
]
174-
)
175-
),
176123
systemOverlayStyle: context.theme.colorScheme.brightness == Brightness.dark
177124
? SystemUiOverlayStyle.light
178125
: SystemUiOverlayStyle.dark,
@@ -363,4 +310,4 @@ class FullscreenMediaHolderState extends OptimizedState<FullscreenMediaHolder> {
363310
),
364311
);
365312
}
366-
}
313+
}

0 commit comments

Comments
 (0)