BUG: Fixes compile errors due to missing implementations.

This bug was revealed using Xcode 16.3 on a MacOS Sequoia 15.4 machine

Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>

Author: imikejackson

CMakeLists.txt

@@ -15,7 +15,7 @@ set(CMAKE_CXX_EXTENSIONS OFF)
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 
 # set project's name
-project(EbsdLibProj VERSION 1.0.37)
+project(EbsdLibProj VERSION 1.0.38)
 
 # ---------- Setup output Directories -------------------------
 set(CMAKE_LIBRARY_OUTPUT_DIRECTORY

Source/EbsdLib/Math/Matrix3X3.hpp

@@ -129,9 +129,9 @@ class Matrix3X3
    * @param rhs
    * @return
    */
-  Matrix3X3& multiplyInPlace(SelfType& rhs)
+  SelfType& multiplyInPlace(SelfType& rhs)
   {
-    Matrix3X3 outMat;
+    SelfType outMat;
     outMat[0] = m_Data[0] * rhs[0] + m_Data[1] * rhs[3] + m_Data[2] * rhs[6];
     outMat[1] = m_Data[0] * rhs[1] + m_Data[1] * rhs[4] + m_Data[2] * rhs[7];
     outMat[2] = m_Data[0] * rhs[2] + m_Data[1] * rhs[5] + m_Data[2] * rhs[8];
@@ -150,9 +150,9 @@ class Matrix3X3
    * @param rhs
    * @param outMat
    */
-  Matrix3X3 operator+(const Matrix3X3& rhs) const
+  SelfType operator+(const Matrix3X3& rhs) const
   {
-    Matrix3X3 outMat;
+    SelfType outMat;
     outMat[0] = m_Data[0] + rhs[0];
     outMat[1] = m_Data[1] + rhs[1];
     outMat[2] = m_Data[2] + rhs[2];
@@ -170,9 +170,9 @@ class Matrix3X3
    * @param rhs
    * @param outMat
    */
-  Matrix3X3 operator-(const Matrix3X3& rhs) const
+  SelfType operator-(const SelfType& rhs) const
   {
-    Matrix3X3 outMat;
+    SelfType outMat;
     outMat[0] = m_Data[0] - rhs[0];
     outMat[1] = m_Data[1] - rhs[1];
     outMat[2] = m_Data[2] - rhs[2];
@@ -217,7 +217,7 @@ class Matrix3X3
    * @brief Multiplies each element of a 3x1 matrix by a scalar value and returns the result
    * @param scalar to multiply each element by.
    */
-  Matrix3X3 operator*(T scalar)
+  SelfType operator*(T scalar)
   {
     return {
         m_Data[0] * scalar, m_Data[1] * scalar, m_Data[2] * scalar, m_Data[3] * scalar, m_Data[4] * scalar, m_Data[5] * scalar, m_Data[6] * scalar, m_Data[7] * scalar, m_Data[8] * scalar,
@@ -230,9 +230,9 @@ class Matrix3X3
    * @param outMat
    */
 
-  Matrix3X3 transpose() const
+  SelfType transpose() const
   {
-    Matrix3X3 outMat;
+    SelfType outMat;
     outMat[0] = m_Data[0];
     outMat[1] = m_Data[3];
     outMat[2] = m_Data[6];
@@ -249,7 +249,7 @@ class Matrix3X3
    * @brief Inverts the 3x3 matrix and returns the result
    * @return outMat
    */
-  void invert()
+  SelfType invert()
   {
     SelfType adjoint = this->adjoint();
     T oneOverDeterminant = 1.0 / this->determinant();
@@ -261,7 +261,7 @@ class Matrix3X3
    * @return outMat
    */
 
-  void adjoint()
+  SelfType adjoint()
   {
     SelfType temp = this->cofactor();
     return temp.transpose();
@@ -274,7 +274,7 @@ class Matrix3X3
 
   SelfType cofactor() const
   {
-    SelfType temp = this->minors3X3();
+    SelfType temp = this->minors();
     SelfType outMat;
 
     // Row 0
@@ -292,14 +292,14 @@ class Matrix3X3
     return outMat;
   }
 
-  /**
+  /**b
    * @brief Calculates the matrix of minors of the 3x3 matrix and places the result into outMat
    * @return outMat
    */
 
-  Matrix3X3 minors()
+  SelfType minors() const
   {
-    Matrix3X3 outMat;
+    SelfType outMat;
     outMat[0] = m_Data[4] * m_Data[8] - m_Data[7] * m_Data[5];
     outMat[1] = m_Data[3] * m_Data[8] - m_Data[6] * m_Data[5];
     outMat[2] = m_Data[3] * m_Data[7] - m_Data[6] * m_Data[4];
@@ -329,7 +329,7 @@ class Matrix3X3
    * @param g
    */
 
-  Matrix3X3 identity()
+  SelfType identity()
   {
     return {1.0f, 0.0f, 0.0f, 0.0f, 1.0f, 0.0f, 0.0f, 0.0f, 1.0f};
   }
@@ -339,7 +339,7 @@ class Matrix3X3
    * @param g
    */
 
-  Matrix3X3 normalize() const
+  SelfType normalize() const
   {
     T denom = m_Data[0] * m_Data[0] + m_Data[3] * m_Data[3] + m_Data[6] * m_Data[6];
     if(denom == 0.0)

Source/Test/TextureTest.cpp

@@ -49,6 +49,7 @@
 #include "EbsdLib/LaueOps/TriclinicOps.h"
 #include "EbsdLib/LaueOps/TrigonalLowOps.h"
 #include "EbsdLib/LaueOps/TrigonalOps.h"
+#include "EbsdLib/Math/Matrix3X3.hpp"
 #include "EbsdLib/Texture/StatsGen.hpp"
 #include "EbsdLib/Texture/Texture.hpp"
 
@@ -186,13 +187,35 @@ class TextureTest
     TestTextureOdf<TrigonalOps>();
   }
 
+  void TestMatrix3X3()
+  {
+    EbsdLib::Matrix3X3F matrix(1.0f, 2.0f, 3.0, 4.0f, 5.0f, 6.0f, 7.0, 8.0f, 9.0f);
+    matrix[0] = 10.0f;
+    matrix.data()[0] = 12.0f;
+    matrix = matrix * matrix;
+    matrix = matrix.multiplyInPlace(matrix);
+    matrix = matrix + matrix;
+    matrix = matrix - matrix;
+    matrix = matrix * 22.0f;
+
+    matrix = matrix.transpose();
+    matrix = matrix.invert();
+    matrix = matrix.adjoint();
+    matrix = matrix.cofactor();
+    matrix = matrix.minors();
+    float det = matrix.determinant();
+    matrix = matrix.normalize();
+    matrix = matrix.identity();
+  }
+
   void operator()()
   {
     std::cout << "<===== Start " << getNameOfClass() << std::endl;
 
     int err = EXIT_SUCCESS;
     DREAM3D_REGISTER_TEST(TestOdfGeneration())
     DREAM3D_REGISTER_TEST(TestMdfGeneration())
+    DREAM3D_REGISTER_TEST(TestMatrix3X3())
   }
 
 public: