Skip to content

Validation fails in CI if no value is provided for the methodology_transparency field #72

@demeringo

Description

@demeringo

Bug description

See the failed validation of this PR #71

To Reproduce

Creat a new entry (new tool), without providing a value of the field methodology_transparency.

=> validation fails in CI

With this error:

Valid: 32 Columns: ("tool_name", "organization", "website", "sub_module", "environmental_indicator", "quick_description", "assessment_type", "main_perimeter", "other_perimeters", "assessed_functional_unit", "data_entry_points", "life_cycle_steps", "ghg_scope", "focus", "licence", "self_hostable", "originating_country", "logo", "inside_models", "methodology_transparency", "ref_sources", "status", "Creator", "Creation date", "Creator_comment", "reviewer_1", "review_1_date", "review_1_explanation", "reviewer_2", "review_2_date", "review_2_explanation", "Linked Publications"); Records: 74; Delimiter: ,
─────────────────────────────────── Dataset ────────────────────────────────────
                dataset                
┏━━━━━━━┳━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━┓
┃ name  ┃ type  ┃ path      ┃ status  ┃
┡━━━━━━━╇━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━┩
│ tools │ table │ tools.csv │ INVALID │
└───────┴───────┴───────────┴─────────┘
──────────────────────────────────── Tables ────────────────────────────────────
                                     tools                                      
┏━━━━━┳━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Row ┃ Field ┃ Type             ┃ Message                                     ┃
┡━━━━━╇━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ 75  │ 20    │ constraint-error │ The cell "null" in row at position "75" and │
│     │       │                  │ field "methodology_transparency" at         │
│     │       │                  │ position "20" does not conform to a         │
│     │       │                  │ constraint: constraint "enum" is            │
│     │       │                  │ "['Undisclosed', 'Disclosed only to         │
│     │       │                  │ internal stakeholders or clients',          │
│     │       │                  │ 'Disclosed to a scientific panel who did    │
│     │       │                  │ not share the results', 'Disclosed to a     │
│     │       │                  │ scientific panel who shared the results',   │
│     │       │                  │ 'Fully Disclosed', 'Not Applicable']"       │
└─────┴───────┴──────────────────┴─────────────────────────────────────────────┘

Validation fails

Expected behavior

Either make the field not mandatory in validation, or initialize it with a default value.

JSON OUTPUT

Additional context

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions