Weird colors when using screen capture for HX8357D

[CNC-Designs]

Hello,
I'm using an Adafruit 480x320 display that has the HX8357D driver in it. It's an STM32 using 8bit parallel mode. When I try to use the screen capture through the processing sketch, I get something close, but not quite the correct screen. I've tried all of the different options around line 409 and none of them make it display quite right.
I've tried each of these

//stroke( (rgb[0] & 0x1F)<<3, (rgb[0] & 0xE0)>>3 | (rgb[1] & 0x07)<<5, (rgb[1] & 0xF8));
//stroke( (rgb[1] & 0x1F)<<3, (rgb[1] & 0xE0)>>3 | (rgb[0] & 0x07)<<5, (rgb[0] & 0xF8));
stroke( (rgb[0] & 0xF8), (rgb[1] & 0xE0)>>3 | (rgb[0] & 0x07)<<5, (rgb[1] & 0x1F)<<3);
//stroke( (rgb[1] & 0xF8), (rgb[0] & 0xE0)>>3 | (rgb[1] & 0x07)<<5, (rgb[0] & 0x1F)<<3);

Here's a screenshot taken with the default line selected. Changing to different ones alters the colors, but none of them are correct.

Here's an actual picture of what the screen looks like.

[Bodmer]

Run the TFT_ReadWrite_Test "Test and diagnostics" sketch and check the values reported in the serial window are correct. Post the example output. This test does a walking 1 test and helps identify the read format.

The problem is that displays do not always return the expected colour format.

[CNC-Designs]

Ah, that makes sense that they don't always return the expected format.
So it looks like the values it's reading are incorrect based on that test.

Pixel value written = 1
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 2
 Pixel value read    = 1
 ERROR                 ^^^^
 Pixel value written = 4
 Pixel value read    = 2
 ERROR                 ^^^^
 Pixel value written = 8
 Pixel value read    = 4
 ERROR                 ^^^^
 Pixel value written = 10
 Pixel value read    = 8
 ERROR                 ^^^^
 Pixel value written = 20
 Pixel value read    = 410
 ERROR                 ^^^^
 Pixel value written = 40
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 80
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 100
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 200
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 400
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 800
 Pixel value read    = 4000
 ERROR                 ^^^^
 Pixel value written = 1000
 Pixel value read    = 8000
 ERROR                 ^^^^
 Pixel value written = 2000
 Pixel value read    = 20
 ERROR                 ^^^^
 Pixel value written = 4000
 Pixel value read    = 40
 ERROR                 ^^^^
 Pixel value written = 8000
 Pixel value read    = 2080
 ERROR                 ^^^^
 Pixel value written = 1
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 2
 Pixel value read    = 1
 ERROR                 ^^^^
 Pixel value written = 4
 Pixel value read    = 2
 ERROR                 ^^^^
 Pixel value written = 8
 Pixel value read    = 4
 ERROR                 ^^^^
 Pixel value written = 10
 Pixel value read    = 8
 ERROR                 ^^^^
 Pixel value written = 20
 Pixel value read    = 410
 ERROR                 ^^^^
 Pixel value written = 40
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 80
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 100
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 200
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 400
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 800
 Pixel value read    = 4000
 ERROR                 ^^^^
 Pixel value written = 1000
 Pixel value read    = 8000
 ERROR                 ^^^^
 Pixel value written = 2000
 Pixel value read    = 20
 ERROR                 ^^^^
 Pixel value written = 4000
 Pixel value read    = 40
 ERROR                 ^^^^
 Pixel value written = 8000
 Pixel value read    = 2080
 ERROR                 ^^^^
 Pixel value written = 1
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 2
 Pixel value read    = 1
 ERROR                 ^^^^
 Pixel value written = 4
 Pixel value read    = 2
 ERROR                 ^^^^
 Pixel value written = 8
 Pixel value read    = 4
 ERROR                 ^^^^
 Pixel value written = 10
 Pixel value read    = 8
 ERROR                 ^^^^
 Pixel value written = 20
 Pixel value read    = 410
 ERROR                 ^^^^
 Pixel value written = 40
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 80
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 100
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 200
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 400
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 800
 Pixel value read    = 4000
 ERROR                 ^^^^
 Pixel value written = 1000
 Pixel value read    = 8000
 ERROR                 ^^^^
 Pixel value written = 2000
 Pixel value read    = 20
 ERROR                 ^^^^
 Pixel value written = 4000
 Pixel value read    = 40
 ERROR                 ^^^^
 Pixel value written = 8000
 Pixel value read    = 2080
 ERROR                 ^^^^
 Pixel value written = 1
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 2
 Pixel value read    = 1
 ERROR                 ^^^^
 Pixel value written = 4
 Pixel value read    = 2
 ERROR                 ^^^^
 Pixel value written = 8
 Pixel value read    = 4
 ERROR                 ^^^^
 Pixel value written = 10
 Pixel value read    = 8
 ERROR                 ^^^^
 Pixel value written = 20
 Pixel value read    = 410
 ERROR                 ^^^^
 Pixel value written = 40
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 80
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 100
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 200
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 400
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 800
 Pixel value read    = 4000
 ERROR                 ^^^^
 Pixel value written = 1000
 Pixel value read    = 8000
 ERROR                 ^^^^
 Pixel value written = 2000
 Pixel value read    = 20
 ERROR                 ^^^^
 Pixel value written = 4000
 Pixel value read    = 40
 ERROR                 ^^^^
 Pixel value written = 8000
 Pixel value read    = 2080
 ERROR                 ^^^^
 Pixel value written = 1
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 2
 Pixel value read    = 1
 ERROR                 ^^^^
 Pixel value written = 4
 Pixel value read    = 2
 ERROR                 ^^^^
 Pixel value written = 8
 Pixel value read    = 4
 ERROR                 ^^^^
 Pixel value written = 10
 Pixel value read    = 8
 ERROR                 ^^^^
 Pixel value written = 20
 Pixel value read    = 410
 ERROR                 ^^^^
 Pixel value written = 40
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 80
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 100
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 200
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 400
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 800
 Pixel value read    = 4000
 ERROR                 ^^^^
 Pixel value written = 1000
 Pixel value read    = 8000
 ERROR                 ^^^^
 Pixel value written = 2000
 Pixel value read    = 20
 ERROR                 ^^^^
 Pixel value written = 4000
 Pixel value read    = 40
 ERROR                 ^^^^
 Pixel value written = 8000
 Pixel value read    = 2080
 ERROR                 ^^^^
 Pixel value written = 1
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 2
 Pixel value read    = 1
 ERROR                 ^^^^
 Pixel value written = 4
 Pixel value read    = 2
 ERROR                 ^^^^
 Pixel value written = 8
 Pixel value read    = 4
 ERROR                 ^^^^
 Pixel value written = 10
 Pixel value read    = 8
 ERROR                 ^^^^
 Pixel value written = 20
 Pixel value read    = 410
 ERROR                 ^^^^
 Pixel value written = 40
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 80
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 100
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 200
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 400
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 800
 Pixel value read    = 4000
 ERROR                 ^^^^
 Pixel value written = 1000
 Pixel value read    = 8000
 ERROR                 ^^^^
 Pixel value written = 2000
 Pixel value read    = 20
 ERROR                 ^^^^
 Pixel value written = 4000
 Pixel value read    = 40
 ERROR                 ^^^^
 Pixel value written = 8000
 Pixel value read    = 2080
 ERROR                 ^^^^
 Pixel value written = 1
 Pixel value read    = 0
 ERROR                 ^^^^
 Pixel value written = 2
 Pixel value read    = 1
 ERROR                 ^^^^
 Pixel value written = 4
 Pixel value read    = 2
 ERROR                 ^^^^
 Pixel value written = 8
 Pixel value read    = 4
 ERROR                 ^^^^
 Pixel value written = 10
 Pixel value read    = 8
 ERROR                 ^^^^

[Bodmer]

The readPixel function is here:
https://github.com/Bodmer/TFT_eSPI/blob/master/TFT_eSPI.cpp#L1136

Some displays send a dummy byte, then 2 or 3 colour bytes. Red and blue may be swapped too! The data sheets are sometimes wrong which makes experimentation necessary!

I don't have time to look at it at the moment. There is also a read block/rectangle function that would need adapting.

[CNC-Designs]

OK, fair enough.
I'll dig through the code and the datasheet and see if I have any luck. I'll let you know if I end up figuring anything out.

Thanks for taking a look. All of your hard work on this library is much appreciated!