hide bulk menu when no role is selected

Includes server protection for attempting writes with no selected role

Author: zsigmas

R/mod_listings.R

@@ -598,10 +598,25 @@ listings_server <- function(module_id,
                  targets = review_column_indices[[4]])            
           )
         )
+
+        # TODO: find a place for this if
+        if (checkmate::test_string(input[[REV$ID$ROLE]], min.chars = 1)) {
+          bulk_render <-  sprintf(
+            "function(settings, json) {
+              dv_listings.render_bulk_menu(settings.sTableId + \"_wrapper\", [%s], '%s');
+            }", paste(paste0("'", review[["choices"]], "'"), collapse = ", "),
+            ns(REV$ID$REVIEW_SELECT)
+            )
+        } else {
+          bulk_render <- ""
+        }
       } else {
+        bulk_render <- ""
         review_col_count <- 0        
       }
 
+     
+
       DT::datatable(
         data = table_data[["data"]],
         colnames = table_data[["col_names"]],
@@ -619,14 +634,7 @@ listings_server <- function(module_id,
           # FIXME: Update to use https://datatables.net/reference/option/layout
           dom = "<'top'>rtilp", # Buttons, filtering, processing display element, table, information summary, length, pagination
           fixedColumns = list(left = review_col_count),
-          initComplete = htmlwidgets::JS(
-            sprintf(
-            "function(settings, json) {
-              dv_listings.render_bulk_menu(settings.sTableId + \"_wrapper\", [%s], '%s');
-            }", paste(paste0("'", review[["choices"]], "'"), collapse = ", "),
-            ns(REV$ID$REVIEW_SELECT)
-            )
-          ),
+          initComplete = htmlwidgets::JS(bulk_render),
           drawCallback = htmlwidgets::JS("
             function (settings) {  
               $(settings.nTableWrapper).find('thead input[type=\"search\"]').removeAttr('disabled');

R/review.R

@@ -513,6 +513,14 @@ REV_logic_2 <- function(ns, state, input, review, datasets, selected_dataset_lis
   shiny::observeEvent(input[[REV$ID$REVIEW_SELECT]], {
     role <- input[[REV$ID$ROLE]]
 
+    if (!checkmate::test_string(role, min.chars = 1)) {
+      msg <- "Attempted write with unset role"
+      shiny::showNotification(msg, type = "warning")
+      warning(msg)
+      shiny::req(FALSE)
+    }
+    
+
     dataset_list_name <- selected_dataset_list_name() 
     dataset_name <- selected_dataset_name()