Merge pull request #67 from Boehringer-Ingelheim/357288-review-empty-datasets

357288 review empty datasets

Author: ml-ebs-ext

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: dv.listings
 Type: Package
 Title: Data listings module
-Version: 4.3.4-9001
+Version: 4.3.4-9002
 Authors@R: 
     c(
       person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")),

NEWS.md

@@ -1,3 +1,7 @@
+# dv.listings 4.3.4-9002
+- Review functionality:
+  - Cope with initially empty datasets
+
 # dv.listings 4.3.4-9001
 - Review functionality:
   - Allow expanding review choices

R/review.R

@@ -451,7 +451,7 @@ REV_load_annotation_info <- function(folder_contents, review, dataset_lists) {
         function(indices) df_map_st[indices]
       })
 
-      dataset_review_df[["timestamp"]] <- base_timestamp
+      dataset_review_df[["timestamp"]] <- rep(base_timestamp, nrow(dataset_review_df)) # rep for `nrow(...) == 0`
       dataset_review_df[["data_timestamps"]] <- map_canonical_data_into_current_order(data_timestamps_st)
 
       # <domain>_<ROLE>.review      

R/review_structures.R

@@ -188,8 +188,6 @@ RS_compute_id_hashes <- function(df, id_vars) {
 RS_compute_base_memory <- function(df_id, df, id_vars, tracked_vars) {
   checkmate::assert_string(df_id, min.chars = 1, max.chars = 65535)
   checkmate::assert_data_frame(df)
-
-  ; if (nrow(df) == 0) return(simpleCondition("Refusing to review 0-row dataset"))
 
   id_vars <- sort(id_vars)
   tracked_vars <- sort(tracked_vars)

inst/validation/specs.R

@@ -31,7 +31,7 @@ review <- specs_list(
   , review_per_row = "review feature offers per-row reviews"
   , review_per_role = "review feature offers per-role reviews"
   , review_delta_detection = "review feature detects changes in tracked variables across dataset updates"
-  , review_reject_empty_dataset = "review feature refuses to review empty datasets"
+  , review_accept_empty_dataset = "review feature copes with empty datasets"
   , review_hash_no_false_negatives = "review hash function catches all cell changes up to four changes per row"
   , review_change_attribution = "review hash function changes can be attributed to specific modified cells"
   , review_reject_removal_of_rows_by_default = "review feature flags the removal of previously known rows"

tests/testthat/test-review.R

@@ -53,14 +53,14 @@ local({
   })
 
   test_that("Review routines produce a descriptive error when asked to review an empty dataset" |>
-              vdoc[["add_spec"]](specs$review_reject_empty_dataset), {
+              vdoc[["add_spec"]](specs$review_accept_empty_dataset), {
     dataset_lists <- list(
       dataset_list = list(
         ae = head(safetyData::sdtm_ae, 0)
       )
     )
     info <- REV_load_annotation_info(folder_contents = NULL, review, dataset_lists)
-    expect_equal(info[["error"]], "Refusing to review 0-row dataset")
+    expect_length(info[["error"]], 0)
   })
 
   test_that("Review routines cope with 1-row datasets", {