Merge pull request #59 from Boehringer-Ingelheim/test

v 4.3.2 release

Author: ml-ebs-ext

.Rbuildignore

@@ -8,3 +8,6 @@
 ^\.github
 ^doc$
 ^Meta$
+^\.git-blame-ignore-revs$
+^\.lintr.R$
+\.gitempty$

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: dv.listings
 Type: Package
 Title: Data listings module
-Version: 4.3.1
+Version: 4.3.2
 Authors@R: 
     c(
       person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")),
@@ -26,7 +26,8 @@ Suggests:
     pharmaverseadam (>= 0.1.0),
     shinytest2 (>= 0.3.1),
     testthat (>= 3.0.2),
-    safetyData
+    safetyData,
+    jsonlite
 Config/testthat/edition: 3
 Imports: 
     checkmate (>= 2.1.0),
@@ -41,13 +42,11 @@ Imports:
     shinyFeedback (>= 0.4.0),
     shinyjs (>= 2.1.0),
     shinyWidgets (>= 0.8.0),
-    tibble (>= 3.2.1),
-    xxhashlite,
     base64enc,
-    htmltools,
-    jsonlite
+    htmltools
 Depends: R (>= 4.1.0)
 RoxygenNote: 7.3.2
 Roxygen: list(markdown = TRUE)
-Remotes: boehringer-ingelheim/dv.manager@main
+Remotes: boehringer-ingelheim/dv.manager
 VignetteBuilder: knitr
+URL: https://github.com/Boehringer-Ingelheim/dv.listings, https://boehringer-ingelheim.github.io/dv.listings

LICENSE

@@ -1,4 +1,4 @@
-Copyright 2024 Boehringer-Ingelheim Pharma GmbH & Co.KG
+Copyright 2024-2026 Boehringer-Ingelheim Pharma GmbH & Co.KG
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

NAMESPACE

@@ -8,3 +8,4 @@ export(mod_listings)
 import(shiny)
 importFrom(shiny,NS)
 importFrom(shiny,tagList)
+useDynLib(dv.listings, .registration=TRUE)

NEWS.md

@@ -1,3 +1,13 @@
+# dv.listings 4.3.2
+
+- Limited support for column width resizing
+- Remove dependencies on jsonlite and lastpage.sty latex package
+- Review functionality:
+  - Per-role undo of review actions
+  - Faster response to review actions
+  - Progress indicators during long review actions
+  - Improved checks for asynchronous javascript-mediated review write actions
+
 # dv.listings 4.3.1
 
 - Guard against selection of nested or conflicting review storage location.

R/CM.R

@@ -790,7 +790,7 @@ CM <- local({ # _C_hecked _M_odule
 
     df_to_string <- function(df) {
       names(df) <- sprintf("[%s] ", names(df))
-      lines <- capture.output(print(as.data.frame(df), right = FALSE, row.names = FALSE, quote = TRUE)) |> trimws()
+      lines <- utils::capture.output(print(as.data.frame(df), right = FALSE, row.names = FALSE, quote = TRUE)) |> trimws()
       return(paste(lines, collapse = "\n"))
     }
 

R/aaa_preface.R

@@ -1,6 +1,9 @@
 # THIS FILE IS NAMED aaa_preface.R SO IT IS LOADED BEFORE ALL OTHER FILES
 # DO NOT CHANGE ITS NAME. IT MUST BE THE FIRST ONE ALPHABETICALLY.
 
+#' @useDynLib dv.listings, .registration=TRUE
+NULL
+
 #' Build a collection of named constants
 #'
 #' @param ... Named parameters to be collected as constants

R/export_helpers.R

@@ -351,7 +351,7 @@ pdf_preprocessing <- function(df, ref) {
 
   # Create index list which contains for every page the start and end row and the start and end column
   index_list <- lapply(1:n_rows_pages, function(i) {
-    return(lapply(seq_len(length(start_new_page)), function(j) {
+    return(lapply(seq_along(start_new_page), function(j) {
       ind_i <- ifelse(i < n_rows_pages, i * PDF_EXP$N_ROWS, nrow(df))
       ind_j <- ifelse(j < length(start_new_page), start_new_page[j + 1] - 1, ncol(df))
       return(c((i - 1) * PDF_EXP$N_ROWS + 1, ind_i, start_new_page[j], ind_j))