add res NA check and update test to use safetyData::adam_Adsl

Author: gm-ebs-ext

R/data_prep.R

@@ -9,22 +9,22 @@
 #'
 #' @return A list containing datasets for patient information and plots
 pt_info_data_filter <- function(df, subjid_var, columns, selected_key) {
-
   res <- NA
+  res_logical_check <- FALSE
   row_index <- which(df[[subjid_var]] == selected_key)
   if (length(row_index) == 1) {
     res <- df[row_index, columns]
+    res_logical_check <- TRUE
   }
 
   # re-apply data labels for data.frames
-  if (! inherits(df, "tbl") && inherits(df, "data.frame")) {
+  if (res_logical_check && ! inherits(df, "tbl") && inherits(df, "data.frame")) {
     df_labels <- structure(get_labels(df), names = names(df))[columns] #extract and save labels
     # re-apply saved labels
     for (i in columns) {
       attr(res[[i]], "label") <- df_labels[[i]]
     }
   }
-
   return(res)
 }
 

tests/testthat/test-data_prep.R

@@ -1,18 +1,16 @@
 test_that("pt_info_data_filter preserves data.frame labels", {
 
-  df <- datasets::iris |>
-    dplyr::group_by(Species) |>
-    dplyr::slice(1) |>
-    as.data.frame()
+  df <- as.data.frame(safetyData::adam_adsl)
+  mock_labels <- c(LETTERS, letters)
 
   for (i in seq_len(ncol(df))) {
-    attr(df[[i]], "label") <- LETTERS[i]
+    attr(df[[i]], "label") <- mock_labels[i]
   }
 
   expected_labels <- get_labels(df)
 
   output <- pt_info_data_filter(
-    df, subjid_var = "Species", columns = names(df), selected_key = "setosa"
+    df, subjid_var = "USUBJID", columns = names(df), selected_key = "01-701-1015"
   )
 
   testthat::expect_identical(get_labels(output), expected_labels)