Merge pull request #32 from Boehringer-Ingelheim/290181-fix-SAE-labels

290181 fix sae labels

Author: iglauss

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: dv.papo
 Title: Patient Profile
-Version: 2.0.7.9000
+Version: 2.0.1-9008
 Date: 2024-08-13
 Authors@R: 
     c(person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")),

NEWS.md

@@ -1,19 +1,12 @@
-# dv.papo 2.0.7.9000
-- Fixes missing palette colours for AE, CM grading values.
+# dv.papo 2.0.1-9008
 
-# dv.papo 2.0.6.9000
+- Improves SAE label positioning.
+- Fixes missing palette colours for AE, CM grading values.
 - Update to provide early error feedback if a sender_id is not available in list of modules.
-
-# dv.papo 2.0.4.9000
 - Fixes issue with labels not working fully if a data.frame is passed as input.
-
-# dv.papo 2.0.3.9000
 - Fixes y-axis getting squashed if blank values present in DECODE variable for AE/CM plots.
-
-# dv.papo 2.0.2.9000
 - Fixes Serious AE labels mapping when the column is a "Y/N" `character` or `factor` variable instead of `logical`.
 
-
 # dv.papo 2.0.1
 
 - Fixes failed first interaction when a participant is selected from another module

R/create_plots.R

@@ -46,13 +46,14 @@ create_ae_cm_plot <- function(data, x_limits, palette, sl_info, vline_vars, vlin
 
   if ("serious_ae" %in% names(data)) {
     sae_labels <- ifelse(data[["serious_ae"]], "SAE", "")
+    t_diff <- as.numeric(x_limits[2] - x_limits[1])
     p <- p + ggplot2::geom_text(
       ggplot2::aes(
         x = .data[["start_day_z"]],
         y = .data[["decode"]],
         label = sae_labels
       ),
-      colour = "red", nudge_y = 0.25, nudge_x = 1, size = 3
+      colour = "red", nudge_y = 0.25, nudge_x = 0.01 * t_diff, size = 3
     )
   }
 

R/mod_plots.R

@@ -219,7 +219,7 @@ patient_plot_server <- function(id, subject_var,
             if ("grading" %in% names(vars)) df[["grading"]] <- df[[vars[["grading"]]]]
             if ("serious_ae" %in% names(vars)) {
               # FIXME: This is a temporal patch while we fix the modular API part
-              if (!is.logical(df[["serious_ae"]])) {
+              if (!is.logical(df[[vars[["serious_ae"]]]])) {
                 df[["serious_ae"]] <- df[[vars[["serious_ae"]]]] == "Y"
               } else {
                 df[["serious_ae"]] <- df[[vars[["serious_ae"]]]]