remove app continuing past wrong sender_ids

Author: gm-ebs-ext

R/check_papo_call_manual.R

@@ -93,7 +93,7 @@ check_papo_call <- function(datasets, module_id, subject_level_dataset_name, sub
   # TODO: sender_ids
   if (!missing(sender_ids) && !is.null(sender_ids)) {
     unknown_sender_ids <- setdiff(sender_ids, names(afmm_module_names))
-    assert_warn(
+    assert_err(
       length(unknown_sender_ids) < 1,
       sprintf(
         "The `sender_ids` - %s - are not available. The modules available are - %s.

R/mod_patient_profile.R

@@ -30,9 +30,6 @@ mod_patient_profile_UI <- function(id) { # nolint
 #' @param id `[character]` Unique shiny ID. Must match the ID provided to [mod_patient_profile_UI()].
 #' @param subject_level_dataset `[reactive(data.frame)]` Visit-independent subject information.
 #' @param extra_datasets `[reactive(data.frame(n))]` Visit-dependent subject datasets.
-#' @param sender_id_info `[NULL | list(2)]` NULL or named list containing original sender ids and the ones identified as available from module list.
-#' @param afmm_param `[list(1+) | NULL]` Named list of a selection of arguments from module manager. Expects
-#' at least 1 element: \code{module_names}, a character vector whose entries have the corresponding module IDs as names.
 #' @inheritParams mod_patient_profile
 #' @seealso [mod_patient_profile()] and [mod_patient_profile_UI()]
 #'
@@ -68,14 +65,6 @@ mod_patient_profile_server <- function(id, subject_level_dataset, extra_datasets
     id,
     function(input, output, session) {
       ns <- session[["ns"]]
-      testing <- isTRUE(getOption("shiny.testmode"))
-      if (testing) {
-        exported_test_data <<- list()
-        shiny::exportTestValues(test_data = exported_test_data)
-        exported_test_data[["afmm_module_names"]] <<- afmm_param[["module_names"]]
-        exported_test_data[["sender_ids"]] <<- sender_id_info[["sender_ids"]]
-        exported_test_data[["known_sender_ids"]] <<- unlist(sender_id_info["known_sender_ids"])
-      }
 
       output[["ui"]] <- shiny::renderUI({
         res <- NULL
@@ -381,18 +370,12 @@ mod_patient_profile <- function(module_id = "",
         return(datasets[plot_dataset_names])
       })
 
-      # filter missing sender_ids so app doesn't error.
-      known_sender_ids <- sender_ids
-      if (!is.null(sender_ids)) {
-        known_sender_ids <- intersect(sender_ids, names(afmm[["module_names"]]))
-      }
-
       dv.papo::mod_patient_profile_server(
         id = module_id,
         subject_level_dataset = subject_level_dataset,
         extra_datasets = extra_datasets,
         subjid_var = subjid_var,
-        sender_ids = lapply(known_sender_ids, function(x) {
+        sender_ids = lapply(sender_ids, function(x) {
           shiny::reactive(afmm[["module_output"]]()[[x]])
         }),
         summary = summary,

man/mod_patient_profile_server.Rd

@@ -348,26 +348,3 @@ test_that(
     app$stop()
   }
 )
-
-test_that("missing sender_ids are identified and omitted and app continues." |>
-            vdoc[["add_spec"]](c(specs$common$missing_sender_ids)), {
-    app <- shinytest2::AppDriver$new(
-      app_dir = "apps/missing_sender_ids/",
-      name = "missing_sender_id_app"
-    )
-    vals <- app$get_value(export = "papo1-test_data")
-    input_sender_ids <- c("random2", "listings1", "listings2", "random1")
-
-    expect_equal(vals$sender_ids, input_sender_ids)
-    expect_length(vals$known_sender_ids, 0) # check missing sender_ids are identified and omitted.
-
-    vals <- app$get_value(output = "papo1-listings-listing") # check app continued to generate listings.
-    expect_no_error(vals)
-
-    vals <- app$get_value(output = "papo1-selector")
-    expect_true(grepl('option value="01-701-1015"', vals$html)) # check app continues past missing sender_ids.
-
-    app$stop()
-
-  }
-)