refactor(lint): eat our own dogfood ;)

Author: Hecht,Matthias (IT EDP) BIG-DE-B

eslint.config.ts

@@ -1,16 +1,15 @@
-import eslint from '@eslint/js';
-import perfectionist from 'eslint-plugin-perfectionist';
 import { defineConfig } from 'eslint/config';
 import globals from 'globals';
+import strict from './src/configs/strict.js';
 
-export default defineConfig(eslint.configs.recommended, perfectionist.configs['recommended-natural'], {
+export default defineConfig(strict, {
   languageOptions: {
     globals: {
       ...globals.node,
     },
     parserOptions: {
       projectService: {
-        allowDefaultProject: ['*.js', '*.ts'],
+        allowDefaultProject: ['*.*js', '*.*ts'],
       },
     },
   },
@@ -21,6 +20,7 @@ export default defineConfig(eslint.configs.recommended, perfectionist.configs['r
         partitionByComment: true,
       },
     ],
+    'sonarjs/todo-tag': 'warn',
     'sort-keys': 'off', // disabled due to conflict with eslint-plugin-perfectionist
   },
 });

src/configs/base.ts

@@ -1,10 +1,9 @@
 import * as eslint from '@eslint/js';
-import { defineConfig } from 'eslint/config';
 import * as importPlugin from 'eslint-plugin-import';
 import * as perfectionist from 'eslint-plugin-perfectionist';
 import * as sonarjs from 'eslint-plugin-sonarjs';
+import { defineConfig } from 'eslint/config';
 import * as tseslint from 'typescript-eslint';
-
 import {
   PERFECTIONIST_SETTINGS,
   SORT_CLASSES_GROUPS,

src/configs/nextjs.ts

@@ -1,6 +1,5 @@
 import * as nextPlugin from '@next/eslint-plugin-next';
 import { defineConfig } from 'eslint/config';
-
 import { NEXTJS_ROUTING_FILES } from '../lib/nextjs.utils.js';
 import react from './react.js';
 

src/configs/playwright.ts

@@ -1,5 +1,5 @@
-import { defineConfig } from 'eslint/config';
 import * as playwright from 'eslint-plugin-playwright';
+import { defineConfig } from 'eslint/config';
 
 const playwrightPlugin = playwright as typeof playwright & {
   configs: {

src/configs/prettier-disable.ts

@@ -1,5 +1,5 @@
-import { defineConfig } from 'eslint/config';
 import * as prettier from 'eslint-config-prettier';
+import { defineConfig } from 'eslint/config';
 
 export default defineConfig({
   ...prettier,

src/configs/react.ts

@@ -1,18 +1,33 @@
-import { defineConfig } from 'eslint/config';
 import jsxA11y from 'eslint-plugin-jsx-a11y';
 import react from 'eslint-plugin-react';
 import reactHooks from 'eslint-plugin-react-hooks';
 import reactRefresh from 'eslint-plugin-react-refresh';
+import { defineConfig } from 'eslint/config';
 import globals from 'globals';
-
 import { PERFECTIONIST_SETTINGS, SORT_IMPORTS_GROUPS } from '../lib/eslint-plugin-perfectionist.js';
 import base from './base.js';
 
+const reactRecommendedConfig = react.configs.flat.recommended;
+
+if (!reactRecommendedConfig) {
+  throw new Error(
+    'Expected to find the "flat/recommended" configuration in the eslint-plugin-react plugin, but it was not found.',
+  );
+}
+
+const reactJsxRuntimeConfig = react.configs.flat['jsx-runtime'];
+
+if (!reactJsxRuntimeConfig) {
+  throw new Error(
+    'Expected to find the "flat/jsx-runtime" configuration in the eslint-plugin-react plugin, but it was not found.',
+  );
+}
+
 export default defineConfig(
   ...base,
   jsxA11y.flatConfigs.recommended,
-  react.configs.flat.recommended!,
-  react.configs.flat['jsx-runtime']!,
+  reactRecommendedConfig,
+  reactJsxRuntimeConfig,
   reactRefresh.configs.recommended,
   {
     languageOptions: {

src/configs/strict.ts

@@ -1,13 +1,18 @@
 import { defineConfig } from 'eslint/config';
 import * as tseslint from 'typescript-eslint';
-
 import base from './base.js';
 
 const strictTemplateExpressionsRule = (
   tseslint.plugin as typeof tseslint.plugin & {
     rules: Record<string, { meta: { docs: { recommended: { strict: [Record<string, unknown>] } } } }>;
   }
-).rules['restrict-template-expressions']!;
+).rules['restrict-template-expressions'];
+
+if (!strictTemplateExpressionsRule) {
+  throw new Error(
+    'Expected to find the "restrict-template-expressions" rule in the typescript-eslint plugin, but it was not found.',
+  );
+}
 
 export default defineConfig(...base, tseslint.configs.strictTypeChecked, {
   rules: {

src/lib/include-ignore-file.ts

@@ -1,6 +1,6 @@
-import { includeIgnoreFile as includeIgnoreFileAbsolute } from '@eslint/compat';
 import * as path from 'node:path';
 import { cwd } from 'node:process';
+import { includeIgnoreFile as includeIgnoreFileAbsolute } from '@eslint/compat';
 
 /**
  * Reads an ignore file (e.g. `.gitignore`) and returns an object with the ignore patterns.
@@ -10,7 +10,7 @@ import { cwd } from 'node:process';
  * @throws {Error} If the provided path is an empty string.
  * @returns {import('@eslint/compat').FlatConfig} The result of including the ignore file at the resolved absolute path.
  */
-export const includeIgnoreFile = (ignoreFilePath: string = '.gitignore') => {
+export const includeIgnoreFile = (ignoreFilePath = '.gitignore') => {
   if (typeof ignoreFilePath !== 'string') {
     throw new TypeError('Expected a string');
   }