Merge pull request #14 from BofAI/feat/windows-support

feat: windows compatibale

Author: Will-Guan

.github/workflows/ci.yml

@@ -9,8 +9,11 @@ on:
 
 jobs:
   python:
-    name: Python
-    runs-on: ubuntu-latest
+    name: Python (${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest]
 
     defaults:
       run:
@@ -42,9 +45,21 @@ jobs:
       - name: Build
         run: python -m build --no-isolation
 
+      - name: Smoke test CLI
+        env:
+          AGENT_WALLET_DIR: ${{ runner.temp }}/agent-wallet-python-smoke
+        run: |
+          agent-wallet init -p "Abc12345!"
+          agent-wallet add local_secure -w wallet_1 -g -p "Abc12345!"
+          agent-wallet sign msg "hello world" -n tron -p "Abc12345!"
+          python -c "from pathlib import Path; import os; d = Path(os.environ['AGENT_WALLET_DIR']); expected = ['master.json', 'wallets_config.json', 'secret_wallet_1.json']; missing = [name for name in expected if not (d / name).exists()]; assert not missing, f'Missing files in {d}: {missing}'; print(sorted(p.name for p in d.iterdir()))"
+
   typescript:
-    name: TypeScript
-    runs-on: ubuntu-latest
+    name: TypeScript (${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest]
 
     defaults:
       run:
@@ -77,3 +92,12 @@ jobs:
 
       - name: Build
         run: pnpm build
+
+      - name: Smoke test CLI
+        env:
+          AGENT_WALLET_DIR: ${{ runner.temp }}/agent-wallet-typescript-smoke
+        run: |
+          node dist/delivery/bin.js init -p "Abc12345!"
+          node dist/delivery/bin.js add local_secure -w wallet_1 -g -p "Abc12345!"
+          node dist/delivery/bin.js sign msg "hello world" -n tron -p "Abc12345!"
+          node -e "const fs = require('node:fs'); const path = require('node:path'); const dir = process.env.AGENT_WALLET_DIR; const expected = ['master.json', 'wallets_config.json', 'secret_wallet_1.json']; const missing = expected.filter((name) => !fs.existsSync(path.join(dir, name))); if (missing.length) { throw new Error('Missing files in ' + dir + ': ' + missing.join(', ')) } console.log(fs.readdirSync(dir).sort())"

packages/python/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "bankofai-agent-wallet"
-version = "2.3.0"
+version = "2.3.1"
 description = "Universal multi-chain secure signing SDK for AI agents"
 readme = "README.md"
 license = {text = "MIT"}

packages/python/src/agent_wallet/core/providers/config_provider.py

@@ -3,8 +3,6 @@
 from __future__ import annotations
 
 import json
-import os
-import stat
 from collections.abc import Callable
 from pathlib import Path
 
@@ -21,6 +19,7 @@
 from agent_wallet.core.providers.wallet_builder import (
     create_adapter,
 )
+from agent_wallet.core.utils import safe_chmod
 
 
 class ConfigWalletProvider(WalletProvider):
@@ -158,7 +157,7 @@ async def get_active_wallet(self, network: str | None = None) -> Wallet:
     def _ensure_dir(self) -> None:
         path = Path(self._config_dir)
         path.mkdir(parents=True, exist_ok=True)
-        os.chmod(path, stat.S_IRWXU)
+        safe_chmod(path, 0o700)
 
     def _persist(self) -> None:
         self._ensure_dir()

packages/python/src/agent_wallet/core/utils.py

@@ -0,0 +1,19 @@
+"""Cross-platform utilities."""
+
+from __future__ import annotations
+
+import os
+import warnings
+from pathlib import Path
+
+
+def safe_chmod(path: str | Path, mode: int) -> None:
+    """Attempt ``os.chmod`` and warn instead of crashing on unsupported platforms."""
+    try:
+        os.chmod(path, mode)
+    except (OSError, NotImplementedError):
+        warnings.warn(
+            f"Could not set file permissions on {path}. "
+            "On Windows this is expected — secrets are still protected by encryption.",
+            stacklevel=2,
+        )

packages/python/src/agent_wallet/delivery/cli.py

@@ -6,7 +6,6 @@
 import json
 import os
 import secrets
-import stat
 import string
 import sys
 from pathlib import Path
@@ -37,6 +36,7 @@
     derive_key_from_mnemonic,
     parse_network_family,
 )
+from agent_wallet.core.utils import safe_chmod
 from agent_wallet.local.kv_store import SecureKVStore
 from agent_wallet.local.secret_loader import load_local_secret
 
@@ -659,7 +659,7 @@ def start(
                     auto_generated = True
 
             secrets_path.mkdir(parents=True, exist_ok=True)
-            os.chmod(secrets_path, stat.S_IRWXU)
+            safe_chmod(secrets_path, 0o700)
             kv_store = SecureKVStore(dir, pw)
             kv_store.init_master()
             provider.ensure_storage()
@@ -756,7 +756,7 @@ def init(
         raise typer.Exit(1)
 
     secrets_path.mkdir(parents=True, exist_ok=True)
-    os.chmod(secrets_path, stat.S_IRWXU)  # 700
+    safe_chmod(secrets_path, 0o700)
 
     provider = _get_provider(dir)
     console.print(PASSWORD_REQUIREMENTS_HINT)

packages/python/src/agent_wallet/local/kv_store.py

@@ -11,6 +11,7 @@
 from eth_hash.auto import keccak
 
 from agent_wallet.core.errors import DecryptionError
+from agent_wallet.core.utils import safe_chmod
 
 # Keystore V3 scrypt parameters
 SCRYPT_N = 262144
@@ -167,3 +168,4 @@ def _write_json(self, filename: str, data: dict) -> None:
             json.dumps(data, indent=2, ensure_ascii=False) + "\n",
             encoding="utf-8",
         )
+        safe_chmod(path, 0o600)

packages/python/tests/test_utils.py

@@ -0,0 +1,32 @@
+"""Tests for cross-platform utilities."""
+
+from __future__ import annotations
+
+import os
+import stat
+import warnings
+from pathlib import Path
+from unittest.mock import patch
+
+from agent_wallet.core.utils import safe_chmod
+
+
+def test_safe_chmod_sets_permissions(tmp_path: Path) -> None:
+    f = tmp_path / "secret.json"
+    f.write_text("{}")
+    safe_chmod(f, stat.S_IRUSR | stat.S_IWUSR)
+    if os.name == "nt":
+        assert f.exists()
+        return
+    assert f.stat().st_mode & 0o777 == 0o600
+
+
+def test_safe_chmod_warns_on_failure(tmp_path: Path) -> None:
+    f = tmp_path / "secret.json"
+    f.write_text("{}")
+    with patch("agent_wallet.core.utils.os.chmod", side_effect=OSError("not supported")):
+        with warnings.catch_warnings(record=True) as w:
+            warnings.simplefilter("always")
+            safe_chmod(f, stat.S_IRUSR | stat.S_IWUSR)
+            assert len(w) == 1
+            assert "Could not set file permissions" in str(w[0].message)

packages/typescript/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bankofai/agent-wallet",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "description": "Universal multi-chain secure signing SDK for AI agents",
   "type": "module",
   "main": "./dist/index.cjs",

packages/typescript/src/core/resolver.ts

@@ -83,7 +83,7 @@ export async function resolveWallet(options?: {
 // ---------------------------------------------------------------------------
 
 function expandTilde(p: string): string {
-  if (p === '~' || p.startsWith('~/')) return join(homedir(), p.slice(1))
+  if (p === '~' || p.startsWith('~/') || p.startsWith('~\\')) return join(homedir(), p.slice(2))
   return p
 }
 

packages/typescript/src/delivery/cli.ts

@@ -63,8 +63,8 @@ export function deriveKeyFromMnemonic(
   return privateKey
 }
 
-function expandTilde(p: string): string {
-  if (p === '~' || p.startsWith('~/')) return join(homedir(), p.slice(1))
+export function expandTilde(p: string): string {
+  if (p === '~' || p.startsWith('~/') || p.startsWith('~\\')) return join(homedir(), p.slice(2))
   return p
 }