Skip to content

Inconsistent arguments for perform() #805

@jenstroeger

Description

@jenstroeger

Just an observation: the GenericActor class calls the perfom() function like so

def __call__(self, *args, **kwargs):
return self.perform(*args, **kwargs)
but doesn’t actually declare those arguments here
def perform(self):
"""This is the method that gets called when the actor receives
a message. All non-abstract subclasses must implement this
method.
"""
raise NotImplementedError("%s does not implement perform()" % self.__name__)

I’m not sure if the generic module is used or maintained much, but I think that’s an inconsistency that ought to be addressed.

Happy to provide a PR and add the args into the function.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions